From: "Khan, Sabeeh" <sabeeh-khan@ti.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>,
<arend.vanspriel@broadcom.com>, <kvalo@kernel.org>
Cc: <knaerzche@gmail.com>, <leitao@debian.org>,
<linus.walleij@linaro.org>, <javierm@redhat.com>,
<linux-wireless@vger.kernel.org>, <brcm80211@lists.linux.dev>,
<brcm80211-dev-list.pdl@broadcom.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH wireless-next v2 2/3] wifi: wlcore: sdio: Make use of irq_get_trigger_type()
Date: Mon, 9 Sep 2024 13:36:19 +0400 [thread overview]
Message-ID: <7a7f5870-b74e-4c0e-8d76-b97b45bae963@ti.com> (raw)
In-Reply-To: <20240904154919.118513-3-vassilisamir@gmail.com>
Hi Vasileios,
On 9/4/2024 7:49 PM, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
> drivers/net/wireless/ti/wlcore/sdio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
> index 92fb5b8dcdae..9e1b644beba9 100644
> --- a/drivers/net/wireless/ti/wlcore/sdio.c
> +++ b/drivers/net/wireless/ti/wlcore/sdio.c
> @@ -324,15 +324,13 @@ static int wl1271_probe(struct sdio_func *func,
> memset(res, 0x00, sizeof(res));
>
> res[0].start = irq;
> - res[0].flags = IORESOURCE_IRQ |
> - irqd_get_trigger_type(irq_get_irq_data(irq));
> + res[0].flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> res[0].name = "irq";
>
>
> if (wakeirq > 0) {
> res[1].start = wakeirq;
> - res[1].flags = IORESOURCE_IRQ |
> - irqd_get_trigger_type(irq_get_irq_data(wakeirq));
> + res[1].flags = IORESOURCE_IRQ | irq_get_trigger_type(wakeirq);
> res[1].name = "wakeirq";
> num_irqs = 2;
> } else {
Reviewed-by: Sabeeh Khan <sabeeh-khan@ti.com>
Tested-by: Sabeeh Khan <sabeeh-khan@ti.com>
next prev parent reply other threads:[~2024-09-09 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:49 [PATCH wireless-next v2 0/3] Use functionality of Vasileios Amoiridis
2024-09-04 15:49 ` [PATCH wireless-next v2 1/3] wifi: brcmfmac: of: Make use of irq_get_trigger_type() Vasileios Amoiridis
2024-09-18 13:53 ` Kalle Valo
2024-09-04 15:49 ` [PATCH wireless-next v2 2/3] wifi: wlcore: sdio: " Vasileios Amoiridis
2024-09-09 9:36 ` Khan, Sabeeh [this message]
2024-09-04 15:49 ` [PATCH wireless-next v2 3/3] wifi: wlcore: sdio: Use helper to define resources Vasileios Amoiridis
2024-09-09 9:38 ` Khan, Sabeeh
2024-09-10 21:58 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a7f5870-b74e-4c0e-8d76-b97b45bae963@ti.com \
--to=sabeeh-khan@ti.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=javierm@redhat.com \
--cc=knaerzche@gmail.com \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®