From: oulijun <oulijun@huawei.com>
To: Colin King <colin.king@canonical.com>,
Wei Hu <huwei87@hisilicon.com>, Weihang Li <liweihang@huawei.com>,
Doug Ledford <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq
Date: Fri, 29 May 2020 15:26:30 +0800 [thread overview]
Message-ID: <7a803901-5405-4837-3fa8-d81e8bdfc067@huawei.com> (raw)
In-Reply-To: <20200528150427.420624-1-colin.king@canonical.com>
在 2020/5/28 23:04, Colin King 写道:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index 8ff6b922b4d7..d02207cd30df 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev)
> static int hns_roce_raq_init(struct hns_roce_dev *hr_dev)
> {
> struct hns_roce_v1_priv *priv = hr_dev->priv;
> - struct hns_roce_raq_table *raq = raq = &priv->raq_table;
> + struct hns_roce_raq_table *raq = &priv->raq_table;
> struct device *dev = &hr_dev->pdev->dev;
> int raq_shift = 0;
> dma_addr_t addr;
>
thanks
next prev parent reply other threads:[~2020-05-29 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 15:04 Colin King
2020-05-29 7:26 ` oulijun [this message]
2020-05-29 18:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a803901-5405-4837-3fa8-d81e8bdfc067@huawei.com \
--to=oulijun@huawei.com \
--cc=colin.king@canonical.com \
--cc=dledford@redhat.com \
--cc=huwei87@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®