From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C65CC77B7C for ; Fri, 12 May 2023 21:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236876AbjELVCh (ORCPT ); Fri, 12 May 2023 17:02:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236116AbjELVCe (ORCPT ); Fri, 12 May 2023 17:02:34 -0400 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 061AB3A84 for ; Fri, 12 May 2023 14:02:29 -0700 (PDT) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230512210227euoutp024f2fdcabdfeb4b59aa56c58d278a8583~egS6EUjBH1824918249euoutp02b for ; Fri, 12 May 2023 21:02:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230512210227euoutp024f2fdcabdfeb4b59aa56c58d278a8583~egS6EUjBH1824918249euoutp02b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1683925347; bh=snYc3AaUnMxozrOKWE2koPU90RtCRf+1sDe5897xL1I=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=lWGPKarD3uqVcSItshPBXVFEKINSdjcrzSzY0viuAWXBEcjkI6Ao2e6pKxgLWAWve ILUWNlIrruRln5DnkcPfKixsv2++NiLt5veQnw4znHrwdP7g/e/GNhr5OA42n5l0ua 1Tb3HjIl9S2mqqdDKEQ0dULZLOaGbmeqBgDPx2zg= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230512210226eucas1p197f78c33383550b74ca3e04056887013~egS5Zo6Pi1153111531eucas1p1D; Fri, 12 May 2023 21:02:26 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id E7.9A.35386.269AE546; Fri, 12 May 2023 22:02:26 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230512210225eucas1p1709c154945bfbcaf221eef18dec31672~egS4qR6Sx0341103411eucas1p1I; Fri, 12 May 2023 21:02:25 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230512210225eusmtrp2667401bccef92188a70c106e5d8480b8~egS4pnHqY0884508845eusmtrp2N; Fri, 12 May 2023 21:02:25 +0000 (GMT) X-AuditID: cbfec7f4-cc9ff70000028a3a-29-645ea96269d0 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8C.5E.14344.169AE546; Fri, 12 May 2023 22:02:25 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230512210225eusmtip28124dbb9b691ef97b4f38d8e161ca1a8~egS33gBNB0166201662eusmtip2C; Fri, 12 May 2023 21:02:25 +0000 (GMT) Message-ID: <7a83b8c1-88ff-0ae6-9c3b-d49fc08c7ac0@samsung.com> Date: Fri, 12 May 2023 23:02:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH V5 5/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing Content-Language: en-US To: Adam Ford , Lucas Stach Cc: dri-devel@lists.freedesktop.org, Marek Vasut , Neil Armstrong , Jernej Skrabec , Robert Foss , Jonas Karlman , aford@beaconembedded.com, Frieder Schrempf , linux-kernel@vger.kernel.org, Michael Walle , Laurent Pinchart , Andrzej Hajda , Chen-Yu Tsai , Jagan Teki From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFKsWRmVeSWpSXmKPExsWy7djP87pJK+NSDPY/UbO4c/s0s8Xuq93s FvcXf2axuPL1PZtF79JzrBZfNk1gs3g+fx2jxck3V1ksHsy9yWTROXEJu8XlXXPYLN60NTJa vD29gd3i/c5bjBaT5t1ktZjRdpnVQcBj7cf7rB4vlzcwe8xuuMjiMW/WCRaPnbPusnvM7pjJ 6rF4z0smj02rOtk8jlxdzOpxYsIlJo871/awedzvPs7k0f/XwOPzJjmPA3tb2AL4o7hsUlJz MstSi/TtErgyNl8/yVbwWKBi+uOwBsbFvF2MnBwSAiYSu57uY+1i5OIQEljBKHFs/2MmCOcL o8STs7fYQaqEBD4zSixapAXTcXDyHzaI+HJGifYmfYiGj4wSa3+8YAZJ8ArYSbx+d4cJxGYR UJV49m42O0RcUOLkzCcsILaoQKrEqs0XweqFBaIkDn5cCTaUWUBc4taT+WC9IgIeEgeOXGQB WcAsMJtF4sHZZWCD2AQMJbredgE1cHBwCgRK7LjKDdErL9G8dTYzSL2EwCtOiZlbP7FDXO0i seXDekYIW1ji1fEtUHEZif875zNBNLQzSiz4fR/KmcAo0fD8FlSHtcSdc7/AtjELaEqs36UP EXaU2H2rCSwsIcAnceOtIMQRfBKTtk1nhgjzSnS0CUFUq0nMOr4Obu3BC5eYJzAqzUIKlllI 3p+F5J1ZCHsXMLKsYhRPLS3OTU8tNspLLdcrTswtLs1L10vOz93ECEyep/8d/7KDcfmrj3qH GJk4GA8xSnAwK4nwvl0SnSLEm5JYWZValB9fVJqTWnyIUZqDRUmcV9v2ZLKQQHpiSWp2ampB ahFMlomDU6qBKUuoRttYXVGqL9C2/CLLr0ezmY97dXqUNTocqjIM+jvROF92+5q7KU13eZY2 p/FsMDZoYrdyXHvGyiHjnOxd6Ye7D+sJ74865Z98tu2QabYW+9m5jJO0kldclnmlv95qWa7T 3pvG7lGLO1RUdy6WO86gtytYd7USg+zKZya9zeyb3jyRdfjY/0hge0t/238l9WqNiu0N99U/ uD5lnsJxeP3fK60VP0584Tv64evVnvDqeds5t3kap603/F9Zfiny0Yd6t9tf4ot0/Wb869vj c69a0Xal4m7dO0+D/r1o6ru33Cdu09lOG+OD502fnlx28Uzha/f5ojNq8m75J+zJevekZtqm 8FndN0982OC0UImlOCPRUIu5qDgRABSc87MNBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e/4Pd3ElXEpBtfuGlrcuX2a2WL31W52 i/uLP7NYXPn6ns2id+k5VosvmyawWTyfv47R4uSbqywWD+beZLLonLiE3eLyrjlsFm/aGhkt 3p7ewG7xfuctRotJ826yWsxou8zqIOCx9uN9Vo+XyxuYPWY3XGTxmDfrBIvHzll32T1md8xk 9Vi85yWTx6ZVnWweR64uZvU4MeESk8eda3vYPO53H2fy6P9r4PF5k5zHgb0tbAH8UXo2Rfml JakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZm6+fZCt4LFAx /XFYA+Ni3i5GTg4JAROJg5P/sHUxcnEICSxllDjY0c4OkZCRODmtgRXCFpb4c60Lqug9o8Tq x+tZQBK8AnYSr9/dYQKxWQRUJZ69m80OEReUODnzCViNqECqxMmlN8BsYYEoiYMfV7KB2MwC 4hK3nswH6xUR8JA4cOQiC8gCZoG5LBIN67cxgySEBI4wSWyZnghiswkYSnS9BbmCg4NTIFBi x1VuiDlmEl1buxghbHmJ5q2zmScwCs1CcsYsJOtmIWmZhaRlASPLKkaR1NLi3PTcYiO94sTc 4tK8dL3k/NxNjMB0se3Yzy07GFe++qh3iJGJg/EQowQHs5II79sl0SlCvCmJlVWpRfnxRaU5 qcWHGE2BYTGRWUo0OR+YsPJK4g3NDEwNTcwsDUwtzYyVxHk9CzoShQTSE0tSs1NTC1KLYPqY ODilGpjyLQ5zd558PEOtRSIi6MDdrVnqxQ/+hf2bF3zkhdTsfOuIepddH5vdn6g/X27ps4GL V3m76T5+5v1PHdx6+D/P/TVv4ccip9nbXvFKXDS8ZePsUhMccit6C7Pp0i/xm3df7DKaVvPI UJExZ1+DxOXPfVb+UbUzrr510ttTt2FN+d98JZYucavo5r+bxLMvG398euKzaMW/33qfN2pP OPlCtCn4rk+7dGzTRNHeq8lzPL6FP2FjPvhgM6OT1L9WvzUFmZmWCZnKwbfqdXe8Pd/b/yJS qNr3zXIOyyNPfv0QTj/+amqJvSa735SSZTFZc4WlKrTPfpnz1b8vVnhRb9ycH+GmPy23mj2b E6T7Z4YSS3FGoqEWc1FxIgDzNsHCoAMAAA== X-CMS-MailID: 20230512210225eucas1p1709c154945bfbcaf221eef18dec31672 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20230512200115eucas1p180198d430c17b044e34d66b7246d4a7b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230512200115eucas1p180198d430c17b044e34d66b7246d4a7b References: <20230506192453.725621-1-aford173@gmail.com> <20230506192453.725621-6-aford173@gmail.com> <275064c0e6c814d8e8fda6bcf70d6e8c3bdc3011.camel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.05.2023 22:00, Adam Ford wrote: > On Fri, May 12, 2023 at 2:37 PM Lucas Stach wrote: >> Am Samstag, dem 06.05.2023 um 14:24 -0500 schrieb Adam Ford: >>> The DPHY timings are currently hard coded. Since the input >>> clock can be variable, the phy timings need to be variable >>> too. Add an additional variable to the driver data to enable >>> this feature to prevent breaking boards that don't support it. >>> >>> The phy_mipi_dphy_get_default_config function configures the >>> DPHY timings in pico-seconds, and a small macro converts those >>> timings into clock cycles based on the pixel clock rate. >>> >> This week I finally had some time to take a deeper look at this series >> and test it on some of my systems. > Thanks for testing this! >> This patch causes issues when the burst clock rate is fixed by >> supplying the DT entry. Instead of describing the issue below, I'm >> attaching the patch that makes things work on my system. > Oops, sorry about that. > >> I would appreciate if you could test this one on your side. Feel free >> to squash it into yours if you find it working properly. > I reviewed your patch, and it looks like it makes a lot of sense. > If it works, I'll squash them together and add your name to the sign-off. > >> Also I would almost bet that dynamic_dphy is working on the Exynos >> boards with that fix added. So if anyone with access to those boards >> would like to give it a shot, we may be able to get rid of the >> hardcoded PHY parameters altogether, which would be a nice cleanup. > I wondered the same thing, but I didn't want to create more work for > Marek S and since there was so much churn getting the original driver > ported, I thought it would be the safest thing to try to give the > imx8m m/n/p the features without breaking the Exynos. > > Marek S - Do you want me to post this file without the extra checks to > see if it still works with Exynos? Feel free to send me patches to test or just point to your work-in-progress git repo. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland