mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: change array type to u8
Date: Tue, 11 Sep 2018 04:23:22 -0700	[thread overview]
Message-ID: <7a842c452d57684377eb3fb50984d130d7dc0401.camel@perches.com> (raw)
In-Reply-To: <20180910203805.10342-1-straube.linux@gmail.com>

On Mon, 2018-09-10 at 22:38 +0200, Michael Straube wrote:
> The the last two parameters of write_cam() have type u8.
> Change the type of the passed arrays from unsigned char to u8.
> Clears a line over 80 characters checkpatch warning.
> 
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> index 3e0801858737..fb496ab5a862 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> @@ -454,9 +454,9 @@ void write_cam(struct adapter *padapter, u8 entry, u16 ctrl, u8 *mac, u8 *key)
>  
>  void clear_cam_entry(struct adapter *padapter, u8 entry)
>  {
> -	unsigned char null_sta[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
> -	unsigned char null_key[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> -				    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
> +	u8 null_sta[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
> +	u8 null_key[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +			 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};

static const

could also be written

	static const u8 null_sta[ETH_ALEN] = {};
	static const u8 null_key[16] = {};

>  
>  	write_cam(padapter, entry, 0, null_sta, null_key);
>  }

      reply	other threads:[~2018-09-11 21:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 20:38 Michael Straube
2018-09-11 11:23 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a842c452d57684377eb3fb50984d130d7dc0401.camel@perches.com \
    --to=joe@perches.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®