From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F90C47092 for ; Wed, 2 Jun 2021 13:30:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA34360BD3 for ; Wed, 2 Jun 2021 13:30:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbhFBNcR (ORCPT ); Wed, 2 Jun 2021 09:32:17 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:46785 "EHLO mail-ed1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbhFBNcJ (ORCPT ); Wed, 2 Jun 2021 09:32:09 -0400 Received: by mail-ed1-f48.google.com with SMTP id r11so2886340edt.13 for ; Wed, 02 Jun 2021 06:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZONPVevPrQ8kgbLjTG/JbKJkdCcwfXG19PWEk0gLLz8=; b=Pu00urgWpWIirMQ/SnHIyILnSmFYl5efJUfM/avAHQoV3zciv3sBvGrz7KcB1nBokf zwNvbSkdBvO49VNx5q2Zj81dNtjrqU0Mz+qPuJkdsJo78RVM8/dV2qHIfxaYpVJlYDbg dgz5Hs352CDX5gEp4NB0OXazoWWv8JXoqsGS76P4ZbjazJVoqRKLaEoIB6Vy5jZdh+vc WnHc25WuYaTkqfkm6ar44Z9TEw3TMPZL2w7RLyfBAeO4Am+XtJrB/06/Sllg5A+DYzXl XBFNCZkaz3FVB3cqym2YDeY+sVuAx2b0E2SWqoSZrZc+BohhpYlCDIKa9JMAGyjCiFNy 74NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZONPVevPrQ8kgbLjTG/JbKJkdCcwfXG19PWEk0gLLz8=; b=rm0tJ9uzrwNxipF1ZNOmdK/Pu1c7vNhcYIRBp93a4oLJVkcOhqQLAh/UsHgmsSr71I 81tIVJsEN0pd54ZLKd+ZSH4zme+/RBnLwp6+nvS28dxP8vI8u11BiYk6Q/3yPddNkV7W V3DWm/31Sna3woFPs6cYj5Bgq+iamB7JwXGTxDQCFPPGl56uhr3M9u0yh2IGZRACVLGH e9u6CHMrSmSEBMKSvNROPEY0XPRF3pRe6jADRXQaHTotMH7hRA67G5Sfh4igO0nuKcBw sTwfXlB2A8I9V7EWbFbcQT47f+mdAyf9ct31cIke8LLbpwkC/xFTdjmM0rgf0z0q1oIh PyzA== X-Gm-Message-State: AOAM5322uhtCegSh/Fdkv+z/gbOHWb+fuTYoWQPm6VlgygUDW2Aig4xa aPJhL6fxduZKSJaIbUP2wSsYgQ== X-Google-Smtp-Source: ABdhPJywkRCY1c6rYh5cyHIY/U67rtIChrhtM3oBEa7Sqq51T+PU5O6ZFcrUf1JWHwutz6QUObW9Mg== X-Received: by 2002:aa7:cc97:: with SMTP id p23mr38160427edt.372.1622640550284; Wed, 02 Jun 2021 06:29:10 -0700 (PDT) Received: from [192.168.1.28] (hst-221-100.medicom.bg. [84.238.221.100]) by smtp.googlemail.com with ESMTPSA id b22sm1337371eds.71.2021.06.02.06.29.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 06:29:09 -0700 (PDT) Subject: Re: [PATCH 1/3] v4l: Add Qualcomm custom compressed pixel formats To: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-api@vger.kernel.org Cc: Mauro Carvalho Chehab References: <20210429105815.2790770-1-stanimir.varbanov@linaro.org> <20210429105815.2790770-2-stanimir.varbanov@linaro.org> From: Stanimir Varbanov Message-ID: <7a8a3b86-0c0a-f190-b6e7-d83d7d6b6433@linaro.org> Date: Wed, 2 Jun 2021 16:29:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/21 12:56 PM, Hans Verkuil wrote: > On 29/04/2021 12:58, Stanimir Varbanov wrote: >> Here we add custom Qualcomm raw compressed pixel formats. They are >> used in Qualcomm SoCs to optimaize the interconnect bandwidth. > > optimize > >> >> Signed-off-by: Stanimir Varbanov >> --- >> .../userspace-api/media/v4l/pixfmt-reserved.rst | 12 ++++++++++++ >> drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ >> include/uapi/linux/videodev2.h | 2 ++ >> 3 files changed, 16 insertions(+) >> >> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >> index 0b879c0da713..30b9cef4cbf0 100644 >> --- a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >> +++ b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >> @@ -260,6 +260,18 @@ please make a proposal on the linux-media mailing list. >> of tiles, resulting in 32-aligned resolutions for the luminance plane >> and 16-aligned resolutions for the chrominance plane (with 2x2 >> subsampling). >> + * .. _V4L2-PIX-FMT-QC8C: >> + >> + - ``V4L2_PIX_FMT_QC8C`` >> + - 'QC8C' >> + - Compressed Macro-tile 8Bit YUV420 format used by Qualcomm platforms. > > 8Bit -> 8-bit > >> + The compression is lossless. It contains four planes. >> + * .. _V4L2-PIX-FMT-QC10C: >> + >> + - ``V4L2_PIX_FMT_QC10C`` >> + - 'QC10C' >> + - Compressed Macro-tile 10Bit YUV420 format used by Qualcomm platforms. > > 10Bit -> 10-bit > >> + The compression is lossless. It contains four planes. > > What is not clear from this description is if these formats are opaque, i.e. the > only way to decompress is through hardware, or if they can be decompressed in > software. If so, a reference to Qualcomm documentation would be useful. See e.g. > the V4L2_PIX_FMT_MT21C description (that's an opaque format). Yes, the formats are opaque and can be decompressed by hardware blocks only. I'll clear that in v2. Thanks for the review. -- regards, Stan