mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Joe Perches <joe@perches.com>,
	linux-kernel@vger.kernel.org, apw@canonical.com
Cc: fbarrat@linux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines
Date: Mon, 6 Aug 2018 18:37:37 +1000	[thread overview]
Message-ID: <7a9ee916-bf83-1f84-1799-9e668d0b3712@au1.ibm.com> (raw)
In-Reply-To: <c99001394ca5cb13fefc56d5b854be1f4c7e0624.camel@perches.com>

On 06/08/18 15:07, Joe Perches wrote:
> The multiple line block code can be difficult to read.

I 100% agree!

> My suggestion is to instead write a subroutine to get the
> commit description and compare that against the returned
> git commit description.

I'll try and do it up more neatly when I've got some spare time over the 
next few days and send a v2.

Thanks,
-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited


      reply	other threads:[~2018-08-06  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06  3:58 Andrew Donnellan
2018-08-06  3:58 ` [RFC PATCH 2/2] checkpatch: Fix commit ID test when "commit" and hash on different lines Andrew Donnellan
2018-08-06  5:07 ` [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines Joe Perches
2018-08-06  8:37   ` Andrew Donnellan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a9ee916-bf83-1f84-1799-9e668d0b3712@au1.ibm.com \
    --to=andrew.donnellan@au1.ibm.com \
    --cc=apw@canonical.com \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®