mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Hammer Hsieh <hammerh0314@gmail.com>,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, p.zabel@pengutronix.de
Cc: wells.lu@sunplus.com, hammer.hsieh@sunplus.com
Subject: Re: [PATCH v7 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver
Date: Tue, 8 Feb 2022 07:27:04 +0100	[thread overview]
Message-ID: <7aa14a1e-2814-0014-a682-f40666f635ac@kernel.org> (raw)
In-Reply-To: <1644213481-20321-3-git-send-email-hammerh0314@gmail.com>

Hi,

On 07. 02. 22, 6:58, Hammer Hsieh wrote:
> +static void sunplus_shutdown(struct uart_port *port)
> +{
> +	unsigned long flags;
> +	unsigned int isc;
> +
> +	spin_lock_irqsave(&port->lock, flags);
> +
> +	isc = readl(port->membase + SUP_UART_ISC);
> +	isc &= ~(SUP_UART_ISC_RXM | SUP_UART_ISC_TXM);

Is this correct? I mean: will the SUP_UART_ISC read contain the control 
bits, not only status bits?

> +	writel(isc, port->membase + SUP_UART_ISC);
> +
> +	spin_unlock_irqrestore(&port->lock, flags);
> +
> +	free_irq(port->irq, port);

I am still waiting for explanation why this is safe with respect to 
posted writes.

regards,
-- 
js
suse labs

  parent reply	other threads:[~2022-02-08  6:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  5:57 [PATCH v7 0/2] Add UART driver for Suplus SP7021 SoC Hammer Hsieh
2022-02-07  5:58 ` [PATCH v7 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver Hammer Hsieh
2022-02-07  5:58 ` [PATCH v7 2/2] serial:sunplus-uart:Add " Hammer Hsieh
2022-02-07  7:18   ` Greg KH
2022-02-07 11:28     ` hammer hsieh
2022-02-08  6:27   ` Jiri Slaby [this message]
2022-02-08 11:16     ` hammer hsieh
2022-02-08 11:31       ` Greg KH
2022-02-09 10:53         ` hammer hsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aa14a1e-2814-0014-a682-f40666f635ac@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hammer.hsieh@sunplus.com \
    --cc=hammerh0314@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=wells.lu@sunplus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®