mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Renate Meijer <kleuske@xs4all.nl>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: stable@kernel.org, Greg KH <gregkh@suse.de>,
	jdike@karaya.com, linux-kernel@vger.kernel.org
Subject: Re: [08/08] uml: va_copy fix
Date: Tue, 5 Apr 2005 22:18:26 +0200	[thread overview]
Message-ID: <7aa6252d5a294282396836b1a27783e8@xs4all.nl> (raw)
In-Reply-To: <200504052053.20078.blaisorblade@yahoo.it>


On Apr 5, 2005, at 8:53 PM, Blaisorblade wrote:

> On Tuesday 05 April 2005 20:47, Renate Meijer wrote:
>> On Apr 5, 2005, at 6:48 PM, Greg KH wrote:
>>> -stable review patch.  If anyone has any objections, please let us
>>> know.
>>>
>>> ------------------
>>>
>>> Uses __va_copy instead of va_copy since some old versions of gcc
>>> (2.95.4
>>> for instance) don't accept va_copy.
>>
>> Are there many kernels still being built with 2.95.4? It's quite
>> antiquated, as far as
>> i'm aware.
>>
>> The use of '__' violates compiler namespace.
> Why? The symbol is defined by the compiler itself.

If a function is prefixed with a double underscore, this implies the 
function is internal to
the compiler, and may change at any time, since it's not governed by 
some sort of standard.
Hence that code may start suffering from bitrot and complaining to the 
compiler guys won't help.

They'll just tell you to RTFM.

>> If 2.95.4 were not easily
>> replaced by
>> a much better version (3.3.x? 3.4.x) I would see a reason to disregard
>> this, but a fix
>> merely to satisfy an obsolete compiler?
>
> Let's not flame, Linus Torvalds said "we support GCC 2.95.3, because 
> the newer
> versions are worse compilers in most cases".

You make it sound as if you were reciting Ye Holy Scribings. When did 
Linus Thorvalds say this? In the Redhat-2.96 debacle? Before or after 
3.3? I have searched for that quote, but could not find it, and having
suffered under 3.1.1, I can well understand his wearyness for the 
earlier versions.

See

http://kerneltrap.org/node/4126, halfway down.

For the cold, hard facts...

http://www.suse.de/~aj/SPEC/

<snip>

> Consider me as having no opinion on this except not wanting to break 
> on purpose Debian users.

If Debian users are stuck with a pretty outdated compiler, i'd 
seriously suggest migrating to some
other distro which allows more freedom. If linux itself is holding them 
back, there's a need for some serious patching. If there are serious 
issues in the gcc compiler, which hinder migration to a more up-to-date 
version our efforts should be directed at solving them in that project, 
not this.

> If you want, submit a patch removing Gcc 2.95.3 from supported 
> versions, and get ready to fight
> for it (and probably loose).

I don't fight over things like that, i'm not interested in politics. I 
merely point out the problem. And yes.
I do think support for obsolete compiler should be dumped in favor of a 
more modern version. Especially if that compiler requires invasions of 
compiler-namespace. The patch, as presented, is not guaranteed to be 
portable over versions, and may thus introduce another problem with 
future versions of GCC.

> Also, that GCC has discovered some syscall table errors in UML - I 
> sent a
> separate patch, which was a bit big sadly (in the reduced version, 
> about 70
> lines + description).

I am not quite sure what is intended here... Please explain.

timeo hominem unius libri

Thomas van Aquino


  reply	other threads:[~2005-04-05 20:34 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-05 16:45 [00/11] -stable review Greg KH
2005-04-05 16:46 ` [01/08] Fix Oops with ALSA timer event notification Greg KH
2005-04-05 16:46 ` [02/08] Prevent race condition in jbd Greg KH
2005-04-05 16:46 ` [03/08] fix ia64 syscall auditing Greg KH
2005-04-05 20:27   ` David Mosberger
2005-04-05 20:49     ` Greg KH
2005-04-05 21:01       ` Randy.Dunlap
2005-04-05 23:46       ` Ryan Anderson
2005-04-06  0:05         ` Greg KH
2005-04-06  0:48           ` Dave Jones
2005-04-06 22:43         ` Andrew Morton
2005-04-05 16:47 ` [04/08] I2C: Fix oops in eeprom driver Greg KH
2005-04-05 16:47 ` [05/08] [IPSEC]: Do not hold state lock while checking size Greg KH
2005-04-05 16:47 ` [06/08] rwsem fix Greg KH
2005-04-05 16:47 ` [07/08] [TCP] Fix BIC congestion avoidance algorithm error Greg KH
2005-04-05 18:22   ` Theodore Ts'o
2005-04-05 18:26     ` David S. Miller
2005-04-05 18:32       ` Stephen Hemminger
2005-04-05 16:48 ` [08/08] uml: va_copy fix Greg KH
2005-04-05 18:47   ` Renate Meijer
2005-04-05 18:53     ` Blaisorblade
2005-04-05 20:18       ` Renate Meijer [this message]
2005-04-06 11:32         ` Jörn Engel
2005-04-06 12:04           ` Renate Meijer
2005-04-06 12:27             ` Jörn Engel
2005-04-06 15:46               ` [stable] " Greg KH
2005-04-06 17:29                 ` Renate Meijer
2005-04-06 17:33                   ` Jörn Engel
2005-04-06 17:58                     ` Renate Meijer
2005-04-06 18:13                       ` Jörn Engel
2005-04-06 19:13             ` Blaisorblade
2005-04-06 19:09         ` Blaisorblade
2005-04-06 19:30           ` Jörn Engel
2005-04-07  9:16           ` Renate Meijer
2005-04-07 18:25             ` Blaisorblade
2005-04-05 17:28 ` [00/11] -stable review Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aa6252d5a294282396836b1a27783e8@xs4all.nl \
    --to=kleuske@xs4all.nl \
    --cc=blaisorblade@yahoo.it \
    --cc=gregkh@suse.de \
    --cc=jdike@karaya.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®