From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E2AC433E0 for ; Tue, 12 Jan 2021 00:49:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9596F2251F for ; Tue, 12 Jan 2021 00:49:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404746AbhALAZA (ORCPT ); Mon, 11 Jan 2021 19:25:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403948AbhAKXQL (ORCPT ); Mon, 11 Jan 2021 18:16:11 -0500 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C20CBC061786 for ; Mon, 11 Jan 2021 15:15:30 -0800 (PST) Received: by mail-il1-x129.google.com with SMTP id w17so1014642ilj.8 for ; Mon, 11 Jan 2021 15:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FwCcHXIwvmfHyHokPaF3+kDwTlr3KIMrsOj6iB1l8/Q=; b=qL/hoG0x3VGuUVJz3XLblstAzv7RI+xZIW3smtXYnQRW4+8KdZGgHmfTh688qhpLeg iqg+P6k87I7DbzWA3juYgmQ9CrQLYfEoDydeKLUCRaxv6UX9bw4nzW8jjnEcSD63jde+ kyGB0VQJgBHRWdCjUdFu08B1Sbs6YdmdHfe1/JB3b0H+Qa2xXiQRqZJq/4fuPSKbvO+o iUoQFhMzWrgfYsMJk7LmBGcYJHjr88tPPkAPogG21vpJ9CkTy/S5d3J/NAGfj+VWFm+v ehHacRctZyNAknOwDjjpOv8AbXcHVukwo+JPhEvA1OKyrhbTZ6qdjevI2PQpJQI2nPPZ U3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FwCcHXIwvmfHyHokPaF3+kDwTlr3KIMrsOj6iB1l8/Q=; b=qr+ZxamlIxaXDF89K0NqZOp53vIXey4pR+YSm3ooBdQ8LsZBpyjKrdyChiHOESt754 45/8kF6+v5IjldpaIDPaAlKc/JyFBmj2JNTpLM64vxLCTI2AFH/CIsqQCNNYLCOUko2D Sfyoytv3FFrQxHdeYT7dIeuC/A/br6jYT8k4qXrkMUYOxkWgtXUIgdSrzZ21hE48iNkB K/5Z2JJWnAzq+D1RFNRy4dhEIcC8Yw+sCDicMSVjF7f9mH3+fMqf6nxeUQJnbBHd4WBN 8XGQiXLi76ulCddBFuWH8WuS0sIuciDSw2G2j3N0g7+FJ4Vo51ce112WQzRJGN7dzAed oQZw== X-Gm-Message-State: AOAM533r2fugfi13B44zRiG/QWWF8Ko5nfkkKDsS/dq7z4nP6a6bu0vz zAQlktzOkRL/KMR51loqLDTkDw== X-Google-Smtp-Source: ABdhPJzE5u69CLhCljTsjOjdO9D9yYr3OMEAqnW01A3juxITd/peCCFGR8IZn1ZeYZKw+NT0vaCZhA== X-Received: by 2002:a92:bbcb:: with SMTP id x72mr1315983ilk.104.1610406930122; Mon, 11 Jan 2021 15:15:30 -0800 (PST) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id y5sm867733ilh.24.2021.01.11.15.15.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 15:15:29 -0800 (PST) Subject: Re: [PATCH 2/6] thermal/core: Remove unused functions rebind/unbind exception To: Daniel Lezcano , rui.zhang@intel.com Cc: mjg59@codon.org.uk, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, amitk@kernel.org References: <20201214233811.485669-1-daniel.lezcano@linaro.org> <20201214233811.485669-2-daniel.lezcano@linaro.org> From: Thara Gopinath Message-ID: <7aa8396e-9dab-09ad-0eb6-86b412fccd02@linaro.org> Date: Mon, 11 Jan 2021 18:15:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201214233811.485669-2-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/20 6:38 PM, Daniel Lezcano wrote: > The functions thermal_zone_device_rebind_exception and > thermal_zone_device_unbind_exception are not used from anywhere. > > Remove that code. > > Signed-off-by: Daniel Lezcano Reviewed-by: Thara Gopinath > --- > drivers/thermal/thermal_core.c | 37 ---------------------------------- > drivers/thermal/thermal_core.h | 4 ---- > 2 files changed, 41 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index 567bc6f254c0..a0f0c33c8d9c 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -598,26 +598,6 @@ static void thermal_zone_device_check(struct work_struct *work) > thermal_zone_device_update(tz, THERMAL_EVENT_UNSPECIFIED); > } > > -void thermal_zone_device_rebind_exception(struct thermal_zone_device *tz, > - const char *cdev_type, size_t size) > -{ > - struct thermal_cooling_device *cdev = NULL; > - > - mutex_lock(&thermal_list_lock); > - list_for_each_entry(cdev, &thermal_cdev_list, node) { > - /* skip non matching cdevs */ > - if (strncmp(cdev_type, cdev->type, size)) > - continue; > - > - /* re binding the exception matching the type pattern */ > - thermal_zone_bind_cooling_device(tz, THERMAL_TRIPS_NONE, cdev, > - THERMAL_NO_LIMIT, > - THERMAL_NO_LIMIT, > - THERMAL_WEIGHT_DEFAULT); > - } > - mutex_unlock(&thermal_list_lock); > -} > - > int for_each_thermal_governor(int (*cb)(struct thermal_governor *, void *), > void *data) > { > @@ -685,23 +665,6 @@ struct thermal_zone_device *thermal_zone_get_by_id(int id) > return match; > } > > -void thermal_zone_device_unbind_exception(struct thermal_zone_device *tz, > - const char *cdev_type, size_t size) > -{ > - struct thermal_cooling_device *cdev = NULL; > - > - mutex_lock(&thermal_list_lock); > - list_for_each_entry(cdev, &thermal_cdev_list, node) { > - /* skip non matching cdevs */ > - if (strncmp(cdev_type, cdev->type, size)) > - continue; > - /* unbinding the exception matching the type pattern */ > - thermal_zone_unbind_cooling_device(tz, THERMAL_TRIPS_NONE, > - cdev); > - } > - mutex_unlock(&thermal_list_lock); > -} > - > /* > * Device management section: cooling devices, zones devices, and binding > * > diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h > index 8df600fa7b79..e50c6b2909fe 100644 > --- a/drivers/thermal/thermal_core.h > +++ b/drivers/thermal/thermal_core.h > @@ -118,10 +118,6 @@ struct thermal_instance { > > int thermal_register_governor(struct thermal_governor *); > void thermal_unregister_governor(struct thermal_governor *); > -void thermal_zone_device_rebind_exception(struct thermal_zone_device *, > - const char *, size_t); > -void thermal_zone_device_unbind_exception(struct thermal_zone_device *, > - const char *, size_t); > int thermal_zone_device_set_policy(struct thermal_zone_device *, char *); > int thermal_build_list_of_policies(char *buf); > > -- Warm Regards Thara