From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04D922157F for ; Wed, 30 Apr 2025 21:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746050301; cv=none; b=opTkGwSQ15AMswDsvVbU6N4dWwCVSru3ihO421slpVzfFgRvs4JC9HZkSm3dE7ACYMPKbi82CVshdM+rGyfm6oILZJo52Z1dBayt+YcMziR7F6vjKiALGkaJmwvoZEhVK/3mSRmikpYM5rXd7Jf1B8+sBuOhFWl6TvHvqN3Hjtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746050301; c=relaxed/simple; bh=OSlLfiT7oPSVW0Vhu/WXB7k0cz6UDEiznLAGwSMZ3m4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=poyHuOYe/Xp0LA8AfLS2Woz+QK69SD+HLNKd9QH4hbKkxWZ89o7dRQ5+D5fCFlIX2bpoQZyAig4QtOwz/G40a0GJOJctbQtZjEpj9P6QP8UclANHxWB8IP590I33OW4R6V/qTSmCWN1tVu81TY5QC1Hlrm4xZUkyr5iCwTu65cM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HoX5RiQG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HoX5RiQG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746050298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZAaCJDVeUqC/iRZsZzcfKKZg/z12nJeHt7AWXEHu+W8=; b=HoX5RiQGLIidIw2Md4LUVntAS+IRVwQ14lphCL6SCDI3d0j6spTYADveqJHh9TLg+2n0tZ q6ZrSFdEnyLmF08P9ulidUf4VkqFFgZVjaODpSOQ9xyzhhzIaecaGFBsoaMQ4cv5+GMJ++ kHyJbjSjb0CDthtY5V0lHFibkQnHCAw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-m9JwZXUjO3mnGQO35otclQ-1; Wed, 30 Apr 2025 17:58:17 -0400 X-MC-Unique: m9JwZXUjO3mnGQO35otclQ-1 X-Mimecast-MFC-AGG-ID: m9JwZXUjO3mnGQO35otclQ_1746050296 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39130f02631so76024f8f.2 for ; Wed, 30 Apr 2025 14:58:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746050296; x=1746655096; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZAaCJDVeUqC/iRZsZzcfKKZg/z12nJeHt7AWXEHu+W8=; b=AmLXgAkmtFFs+Ko6qDjA6r/bBJKd3kfH6PHc1Z82m+S4SX522dtzdoEcJwH8KZDD9k Zu1eCScVdHQeV2HslYq5Sv0NTOM1nC388Nlw1Ib+b/wWxXcGcE5lmnTU7u+KATdVoy1W O4H16xog2D94XFSE9j23wu+fUmV/yzohQ5ugCCE88Kbnak09MHmwb9eSsEbh0jo68mAY b4zADQiMgT8JglJMB7WxKGU7mJPsi4NFTeqiXNSqHPOHiIvA1JUNFkYvCDWTvRKfs+bx lsBHcg2zHSttuTs1fvNAbi7fEew+TDPgltVL9C7ZNYPEfWqXzQP4SkNQH+96mLM4RVL4 x42w== X-Forwarded-Encrypted: i=1; AJvYcCU5LxzWx5lQDLxrajMNmIcErksmI9kHqHKpJFQwIJoZ40v40LKJPxzkcKEEeAl4u3wCaT2ZFQ+HjNC8dp0=@vger.kernel.org X-Gm-Message-State: AOJu0YyjGJ1fbNy3RvnSQ4oWleangwD7XhyMoHOnYrepLgINu09YZWoN FIMbuvWu120DirIQ/drzIECCocPVH8tM7Ru/jgwDJE6y5LtbFqMAQC35xSzroqXo7xv8yUIMR4L 5smg1/nhsDsRc5qYzYNIvEwlZ0vCxOoZy6431yZK2xYF1q34l6fjGWWMaycm+eg== X-Gm-Gg: ASbGncuYb/toDAw7yX8TSgSuurkXi7niovmKrzK+3tnO1w6ZuACJ9DbMZyruvu6QiDv 2HnwBMaG90bvyzQLCgot1loSuA4Fy+Vxo7f7XNV21ZlN+y0Y9XWe8hwzq1BYNk0FSVW1rtCntTH +tHMte6Ybr8X3DFenDX5jM0h5IwubAqxy7HDnVxPSeeDzP1cSEYpG51m+KG0elxenWMJEqz/nFQ qrWlHLWP/Tz9VJRjSd6nMFdP146BWQZ8M9mT0UJidpk8JEyOh+OUlS3b/qAsTJxSH8EDMCYP1WU 6wJgNs0zroW6QXXVcT8zAi5HOA9KRG9A563wdgJk0g== X-Received: by 2002:a5d:64a5:0:b0:39f:efb:c2f6 with SMTP id ffacd0b85a97d-3a094053655mr72097f8f.33.1746050296029; Wed, 30 Apr 2025 14:58:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIUfs9wV073mQDXRyQLoTF/v/RVuHpOr0Qx8MhdARsvRHVgQY3znuEKqA1Jf53XmKmX6ViRw== X-Received: by 2002:a5d:64a5:0:b0:39f:efb:c2f6 with SMTP id ffacd0b85a97d-3a094053655mr72076f8f.33.1746050295698; Wed, 30 Apr 2025 14:58:15 -0700 (PDT) Received: from [192.168.3.141] (p4ff231f0.dip0.t-ipconnect.de. [79.242.49.240]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5d264sm18470464f8f.95.2025.04.30.14.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:58:15 -0700 (PDT) Message-ID: <7ab1743b-8826-44e8-ac11-283731ef51e1@redhat.com> Date: Wed, 30 Apr 2025 23:58:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/3] mm: introduce new .mmap_proto() f_op callback To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , Michal Hocko References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.04.25 21:54, Lorenzo Stoakes wrote: > Provide a means by which drivers can specify which fields of those > permitted to be changed should be altered to prior to mmap()'ing a > range (which may either result from a merge or from mapping an entirely new > VMA). > > Doing so is substantially safer than the existing .mmap() calback which > provides unrestricted access to the part-constructed VMA and permits > drivers and file systems to do 'creative' things which makes it hard to > reason about the state of the VMA after the function returns. > > The existing .mmap() callback's freedom has caused a great deal of issues, > especially in error handling, as unwinding the mmap() state has proven to > be non-trivial and caused significant issues in the past, for instance > those addressed in commit 5de195060b2e ("mm: resolve faulty mmap_region() > error path behaviour"). > > It also necessitates a second attempt at merge once the .mmap() callback > has completed, which has caused issues in the past, is awkward, adds > overhead and is difficult to reason about. > > The .mmap_proto() callback eliminates this requirement, as we can update > fields prior to even attempting the first merge. It is safer, as we heavily > restrict what can actually be modified, and being invoked very early in the > mmap() process, error handling can be performed safely with very little > unwinding of state required. > > Update vma userland test stubs to account for changes. > > Signed-off-by: Lorenzo Stoakes I really don't like the "proto" terminology. :) [yes, David and his naming :P ] No, the problem is that it is fairly unintuitive what is happening here. Coming from a different direction, the callback is trigger after __mmap_prepare() ... could we call it "->mmap_prepare" or something like that? (mmap_setup, whatever) Maybe mmap_setup and vma_setup_param? Just a thought ... In general (although it's late in Germany), it does sound like an interesting approach. How feasiable is it to remove ->mmap in the long run, and would we maybe need other callbacks to make that possible? -- Cheers, David / dhildenb