From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628D83AB289 for ; Tue, 30 Jun 2026 04:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782793704; cv=none; b=s+mf3hlrPj0oukwJq1TW4G0QYKO4p0tHFCcUvQ3I81kgTGwM186R3/RzmnyB9Iws07L+r5E7yYGgzf4imOru1MCeu05AfH5FkFpDyl8xlpok7+sLdVxdZbfOZ2adkZ0yNufGVP/bbEy6STs6+K4zAI1R1Rcgi/8fFqOQY+RqiFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782793704; c=relaxed/simple; bh=xJKT55bm34PbDyZKSs2QdqQluEMDHDryBLZVBk7djFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CwCUlR/pewM2bS3p6fHWQhfMPlnwcgAanInURUEsyflWW2yDCSMOiw/1C+hyPvLq5HyHbDgzh2WIzY/0dwJnaaze24DCxpPcp0czvGzOAPTkGFSiOkV0jiAzbS7OGgo97JNDtO/IdrGAtbAyGyt4L23e10CcqOXqNTWyHcLkJkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r3HZ8/9m; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r3HZ8/9m" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2c95a0c0aa2so27793235ad.3 for ; Mon, 29 Jun 2026 21:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782793703; x=1783398503; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xJKT55bm34PbDyZKSs2QdqQluEMDHDryBLZVBk7djFA=; b=r3HZ8/9msLIpgw+ISFgpy1eV2Gds6rEsI75BCnNwt5dkRCSQ5z/hfJFSc2GhrTmY5u dmX+uRoDYzh99D0wucNxazvWLjimWc20cVzSaYGXuyaKqd8nuwWxSQWwAgA3RZHElLMP SzqScWz2+QBEqVbskGY7qZuy0O6mFrExY4WqtkUtfix7DZpKRz3eK8J8zMTdFSYMb4qJ sW6I1byowW5bG8uIVP/gEtVEN7qegD8vkh1YjMbLCwkZoB97S98pS4f5eDvzozzco0qo 8/3N76vgPF4+nFUqaffuNSGjxuhEOw62a9WSJCY49ZwfazXv2EadAq8QkIkoFTCGvWdf +/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782793703; x=1783398503; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xJKT55bm34PbDyZKSs2QdqQluEMDHDryBLZVBk7djFA=; b=PkG5fqO6n+GTjM/krHR0+GFSEp6ONg/XWZaX2cw757MOixWdZNLtprSABqFRKbWFmW m6LB+vwcwyWn1Eg7Hupo8//ophg2rSe8hlISyZqSSWvAX/Mc+2FvzcBgFmJOVWxVp49T 5Q5gSASu/c+kLcraQ3rGVyWOa+a8j993vbVh49O91eChi9P1xeSNtdVl2LDt1eaAqLhS KW0Hh/vrwud6OOyJ6ORH/DjjktSBwSDiVHuuMM+fUzugEt7UBfZoFV1928Ul66mYxhdy tVYvJWU6hqbEx5CHK68jUhrOWhXSfGjiw9MNfVAPRMtI+bdyAZzl5dQXDsR+P/pfmWUR nvYQ== X-Forwarded-Encrypted: i=1; AHgh+Rp3DfXlA1yg7+daMCj+Uk+c1gKtgHGq4g1ygGCjfas54+P5icBGyiM4UPa8MFGQ3L447z9ViIeXuLsHG7g=@vger.kernel.org X-Gm-Message-State: AOJu0YxPQJEh8Hpo02xK31/8zWSxnDmwmjFisCWF1J3omMSSXF9Uil7r piSmsNJeT6P2XFlCoITgCtr4aNHIZKtXUwrAcGKGv3OM/3LYJ5ZvYUfb X-Gm-Gg: AfdE7ckF15Uxll7Hh+u+45rjoLZjQD8izUDmLyTf+dv39Y7wpJ5TWL0XVFhBWVzJXra 5vEk8AVkNWOHKPIXkrEQR8qZEQE5JDmCt0KHgctk4dsReBqiLVB4HhaHTEb3nl/DOgc870Vhnwe ODq1smnTP3cUjf3mbex6Wv0QO9C0wP456ELGoXHYm0tO6OGVpPVto+RFtVpfPwVsvoxtm0F61Z5 iHALBgWg+COROIoAgAvvf/IJMUE7YvOi/gxvZXnlmwtgewdxxHKCeLL2E3w6EC+OOuqz7fETc8R FnxSj95Ss/y5b0JF4qbM/ByINjwS34phY7IoyTN11yaLY5Y3pQI/17XAhiE7vDB7pKuZyicMlNt gW0gTVjPI96aUWSlbX5EzAzVQ/QvxBJejWVYKruosptGV0WZ/ydUyPiaDuPQIjGAxT+aJQ1s/MR v59hD/3ZeC92nEA6eVIpXPTI2q9beFmgoWk1gutdJG218GTawGWNYeRumHsqodb/dt X-Received: by 2002:a17:903:291:b0:2c1:e426:70f4 with SMTP id d9443c01a7336-2ca2e71453bmr14983255ad.23.1782793702521; Mon, 29 Jun 2026 21:28:22 -0700 (PDT) Received: from [172.19.1.42] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca37a70812sm5085795ad.16.2026.06.29.21.28.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 21:28:21 -0700 (PDT) Message-ID: <7ab78656-3413-4230-8214-8cecaaf62735@gmail.com> Date: Tue, 30 Jun 2026 12:28:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] iio: adc: Add Nuvoton MA35D1 EADC driver To: David Lechner , jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: nuno.sa@analog.com, andy@kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cwweng@nuvoton.com References: <20260625110638.38438-1-cwweng.linux@gmail.com> <20260625110638.38438-3-cwweng.linux@gmail.com> <66ad5723-6589-473a-91da-b13e2ba90aeb@baylibre.com> <5e65eabd-699b-4587-bb38-d8ef5c6d2aaa@gmail.com> Content-Language: en-US From: Chi-Wen Weng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi David, Thanks for the clarification, and sorry for top-posting. I will reply inline and trim the irrelevant context next time. > This is a simple/small enough driver that it would be fine to still > keep all of those features in v2. It would still be fine to split > them into separate patches, but you could still send them all as > a single patch series. Understood. I will keep the driver as a single driver patch in v2, but I will keep the features in the patch and fix the issues raised during review instead of dropping them only to reduce the initial scope. For v2, I will keep direct reads, differential channels and triggered buffer support in the driver patch. DMA support will still not be used by the driver yet, although the binding will describe the optional DMA property as discussed in the binding review. I will address the driver comments in v2, including: - use regmap for register access and update_bits, - add optional vref-supply handling and avoid forcing the external   reference path unconditionally, - add IIO_CHAN_INFO_SCALE based on the selected reference source, - handle differential channels with the proper hardware constraints and   signed output handling, - fix the buffered scan sequencing so samples are read only after the   requested scan has completed, - avoid an unpaced software re-triggering loop, - use IIO_DECLARE_BUFFER_WITH_TS() for the scan buffer, - use the new scan_type.format field, - drop datasheet_name, - use device_for_each_child_node_scoped(), - use devm_mutex_init(), - remove the unused struct device pointer and other cleanup items. Thanks, Chi-Wen