From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DCAE28EF; Wed, 9 Oct 2024 06:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728454628; cv=none; b=cqUQnBKvfN9KT/E2v0nvxl3LKGWe5rne1HhiHp4HuIhE/XWqKNNJCpekRKDrKdnnc0uEoLZVSTnqAVgt4XQA5/A5LvS/rzHh44cnFhGVAbR7awT2HzTo3VU7T+CCSaNL1ITV8VYRNwDf2bqUxi6CzJDGoSkzq0Cpz0oofvLyxmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728454628; c=relaxed/simple; bh=kz72Yil0BN0zjjhcaXqOgmx3Nd4JYoqOO7331BxY1ZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j5G1F9H4/h9y0Fwbj/cVqazVg44hqTXphOIN5hjs66OMkOQle4oRwKs1+yE54L24beTTEShJBt2+QO6N24dVOdQ1klgMpj1SuRtYNs4DAbFO1pCSo25ft0t9m8hqkFwUV68pOW4co35OlSMJNtKDg3lFk4yhDrzpnLePsG148+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=scwr3xuq; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=VxK3l/3L; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=scwr3xuq; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=VxK3l/3L; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="scwr3xuq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="VxK3l/3L"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="scwr3xuq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="VxK3l/3L" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4418D21E4F; Wed, 9 Oct 2024 06:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728454625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yQSa54OpTxsEjyT43avn9SR6hd1EaptYXueVbG9dBU=; b=scwr3xuq9oZC+0wpE5+v4NnIXxO+TQ9QAwX6v7fctizgArpEm9MGLH1NmCwOLvY65s9af7 dJnRZ9ximaCSRZpMgw892MEEzf3hcdJWD69vk0FRnMOP/7VIgMSA24ZdVGajODDaOOCrFc Mze8jw3XqlVl+xjmqNeDBVfh3y8BpYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728454625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yQSa54OpTxsEjyT43avn9SR6hd1EaptYXueVbG9dBU=; b=VxK3l/3Lu6fSvIwJhPZcHg5SOFmiifiH498h/qH0VMCO/9JESDaO36sAmGcOsH7WdTDyf4 jWNuEOYS9F37vTCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1728454625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yQSa54OpTxsEjyT43avn9SR6hd1EaptYXueVbG9dBU=; b=scwr3xuq9oZC+0wpE5+v4NnIXxO+TQ9QAwX6v7fctizgArpEm9MGLH1NmCwOLvY65s9af7 dJnRZ9ximaCSRZpMgw892MEEzf3hcdJWD69vk0FRnMOP/7VIgMSA24ZdVGajODDaOOCrFc Mze8jw3XqlVl+xjmqNeDBVfh3y8BpYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1728454625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yQSa54OpTxsEjyT43avn9SR6hd1EaptYXueVbG9dBU=; b=VxK3l/3Lu6fSvIwJhPZcHg5SOFmiifiH498h/qH0VMCO/9JESDaO36sAmGcOsH7WdTDyf4 jWNuEOYS9F37vTCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E4A53136BA; Wed, 9 Oct 2024 06:17:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id y2QuNeAfBmcnJQAAD6G6ig (envelope-from ); Wed, 09 Oct 2024 06:17:04 +0000 Message-ID: <7aba8d61-c68d-49ee-990e-e5c0381296ba@suse.de> Date: Wed, 9 Oct 2024 08:17:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] nvme: add rotational support To: =?UTF-8?Q?Matias_Bj=C3=B8rling?= , kbusch@kernel.org, hch@lst.de, dlemoal@kernel.org, cassel@kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?Q?Matias_Bj=C3=B8rling?= References: <20241008145503.987195-1-m@bjorling.me> <20241008145503.987195-3-m@bjorling.me> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20241008145503.987195-3-m@bjorling.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.30 X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Level: On 10/8/24 16:55, Matias Bjørling wrote: > From: Matias Bjørling > > Rotational devices, such as hard-drives, can be detected using > the rotational bit in the namespace independent identify namespace > data structure. Make the bit visible to the block layer through the > rotational queue setting. > > Note that rotational devices typically can be used to generate random > entropy, the device is therefore also added as a block device that adds > entropy. > > Signed-off-by: Matias Bjørling > --- > drivers/nvme/host/core.c | 5 +++++ > include/linux/nvme.h | 1 + > 2 files changed, 6 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich