From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2231FC04AB6 for ; Tue, 28 May 2019 15:33:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB5CE208C3 for ; Tue, 28 May 2019 15:33:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sUW0yH/D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727789AbfE1PdE (ORCPT ); Tue, 28 May 2019 11:33:04 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:38263 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727612AbfE1PdD (ORCPT ); Tue, 28 May 2019 11:33:03 -0400 Received: by mail-lj1-f195.google.com with SMTP id 14so18160497ljj.5 for ; Tue, 28 May 2019 08:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GFLFkfjER8yL0H13A8BMLU3btt+GcTnhvj0Q8M7v0E4=; b=sUW0yH/DHleYp4sJI/bVaDZt5qvr8E6UIkaysC4wZPNI6XDJxwa+CKO4WnHcm1X9OZ /8DSnruvVAETlk/ATFMFFxgQgkG0K2bkAaTFDYQqQ06O0cH77QiYapa6H7c/rDtW45ok 4lSAIbfXrX7CwarfK3aoEMDunQsHt0JilelbA/AvZbTacD5d4Tqu5GnHO5jUlp4bMsfT qAbJasWJLtPmhpwvIXEI4iCcJa107QL5m+Afe45M/ufQxQBGTKmtuA/eAnlvwe2FsugX eguwVDyN4a/KTlmjAo9gP3G3Vp+x5TBOWTxhgSPKIAJ/2q0zfbfHe/DYh3I9wf2mvxMa zDXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=GFLFkfjER8yL0H13A8BMLU3btt+GcTnhvj0Q8M7v0E4=; b=EbHwusy0xhPWSl7g5PNAME38vuwU/Pfy0x9LqOeRCd0aPDs1YXTJlOFy303JdN2gWd p/LOb/CBLqknbwUUxC3BJ579I5KI9aFvYlRzFm33waVZorUPVHI+euU8ubHbAx3i/n5B ZjNuX9zDA3qPtGRzjnxTBDviz6r/y2bqNq09BHskIueIzV1swHUgKjvGeuA2uKxsC0aS g5v2WzoQfw7q2TcAmWJSkDgxgQ0yqLvWDwo+GyyVSecR557V4QXQfsIt5yBtyXABHJa0 IrxDNzJKQKUzdtxbFCix/x+fVIdCr3w1ecomDmCuvkYJoQv1EJ/D6iUxVhfKMd6xBsj+ FXfA== X-Gm-Message-State: APjAAAUY/Ps5ZXsU9D4rDRKFZu6uLOSpTgS8hASG1N8CqhSpV2fKX3kw KTw0hgQreq0Ozb6FpPM6iS6KtGyk/5c= X-Google-Smtp-Source: APXvYqxLYiaF2ZOfIffa+xDKkNnBnwp+g8saMY9mxAWYXdcb2Vl+IGE8J579xnYxRHQpoDf5p3qqjg== X-Received: by 2002:a2e:7212:: with SMTP id n18mr12309566ljc.209.1559057580562; Tue, 28 May 2019 08:33:00 -0700 (PDT) Received: from [192.168.1.15] (2-111-15-75-dynamic.dk.customer.tdc.net. [2.111.15.75]) by smtp.gmail.com with ESMTPSA id c10sm2935951lfh.79.2019.05.28.08.32.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 08:32:59 -0700 (PDT) Subject: Re: [PATCH] trace: Avoid memory leak in predicate_parse() To: Steven Rostedt Cc: mingo@redhat.com, linux-kernel@vger.kernel.org References: <20190528134659.4041-1-tomasbortoli@gmail.com> <20190528104400.388e4c3f@gandalf.local.home> <1a9137e1-bcc3-787f-267c-8b76dea41fbb@gmail.com> <20190528112956.4cf2dd9c@gandalf.local.home> From: Tomas Bortoli Openpgp: preference=signencrypt Autocrypt: addr=tomasbortoli@gmail.com; prefer-encrypt=mutual; keydata= mQINBFpCTZMBEADNZ1+Ibh0Z4pgGRcd1aOUMbe/YfHktmajjcoTnKmZZunjoUVAl8waeLITd BC2c8i1wHzHcnthrmb1izs5XlG6PZnl8n5tjysSNbwggzS1NcEK1qgn5VjNlHQ5aRMUwCC51 kicBiNmlQk2UuzzWwdheRGnaf+O1MNhC0GBeEDKQAL5obOU92pzflv6wWNACr+lHxdnpyies mOnRMjH16NjuTkrGbEmJe+MKp0qbjvR3R/dmFC1wczniRMQmV5w3MZ/N9wRappE+Atc1fOM+ wP7AWNuPvrKg4bN5uqKZLDFH7OFpxvjgVdWM40n0cQfqElWY9as+228Sltdd1XyHtUWRF2VW O1l5L0kX0+7+B5k/fpLhXqD3Z7DK7wRXpXmY59pofk7aFdcN97ZK+r6R7mqrwX4W9IpsPhkT kUyg3/Dx/khBZlJKFoUP325/hoH684bSiPEBroel9alB7gTq2ueoFwy6R3q5CMUw3D+CZWHA 3xllu46TRQ/Vt2g0cIHQNPoye2OWYFJ6kSEvaLpymjNDJ9ph2EuHegonDfOaYSq34ic2BcdB JkCgXRLP5K7KtRNJqqR+DM8xByeGmQv9yp6S97el+SiM9R53RhHawJZGz0EPl+2Q6+5mgh3u wXOlkmGrrSrlB8lc567l34ECl6NFtUPIL7H5vppIXAFl7JZUdQARAQABtB50b21hcyA8dG9t YXNib3J0b2xpQGdtYWlsLmNvbT6JAlQEEwEIAD4WIQSKOZIcNF9TdAG6W8ARUi5Y8x1zLgUC WkJNkwIbIwUJCWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRARUi5Y8x1zLvCXD/9h iaZWJ6bC6jHHPGDMknFdbpNnB5w1hBivu9KwAm4LyEI+taWhmUg5WUNO1CmDa2WGSUSTk9lo uq7gH8Y7zwGrYOEDVuldjRjPFR/1yW2JdAmbwzcYkVU0ZUhyo2XzgFjsnv3vJGHk/afEopce U6mOc2BsGDpo2izVTE/HVaiLE9jyKQF6Riy04QBRAvxbDvx1rl26GIxVI6coBFf4SZhZOnc0 dzsip0/xaSRRIMG0d75weezIG49qK3IHyw2Fw5pEFY8tP0JJVxtrq2MZw+n4WmW9BVD/oCd/ b0JZ4volQbOFmdLzcAi2w7DMcKVkW11I1fiRZ/vLMvA4b79r6mn3WJ8aMIaodG6CQzmDNcsF br+XVp8rc58m9q69BTzDH0xTStxXiwozyISAe2VGbGUbK9ngU/H1RX0Y01uQ9Dz0KfyjA0/Z QOBa4N1n1qoKFzoxTpu0Vyumkc5EnTk8NdWszt7UAtNSaIZcBuWHR7Kp0DqRHwom0kgTiNXJ 8uNgvvFTkPd2Pdz1BqbpN1Fj856xPuKIiqs5qXI2yh3GhntFDbTOwOU3rr3x5NEv3wFVojdi HcLM+KVf29YkRHzuEQT5YT9h6qTk2aFRqq3HSXrP56hQ3whR7bQtziJspkuj+ekeTxcZ5lr4 9FJI03hQJ4HbHn6x/Xw0+WjIOo4jBeUEI7kCDQRaQk2TARAA4JCPcQcISPAKKC1n9VQxgdH3 oMqxhJ+gh/0Yb394ZYWLf7qOVQf/MgALPQIIFpcwYrw7gK4hsN7kj1vwPFy9JIqZtkgbmJHm aCj1LkZuf8tp5uvqzMZGcgm28IO6qDhPggeUE3hfA/y5++Vt0Jsmrz5zVPY0bOrLh1bItLnF U3uoaHWkAi/rhM6WwlsxemefzKulXoR9PIGVZ/QGjBGsTkNbTpiz2KsN+Ff/ZgjBJzGQNgha kc6a+eXyGC0YE8fRoTQekTi/GqGY7gfRKkgZDPi0Ul0sPZQJo07Dpw0nh5l6sOO+1yXygcoA V7I4bUeANZ9QJzbzZALgtxbT6jTKC0HUbF9iFb0yEkffkQuhhIqud7RkITe25hZePN8Y6Px0 yF4lEVW/Ti91jMSb4mpZiAaIFcdDV0CAtIYHAcK1ZRVz//+72o4gMZlRxowxduMyRs3L5rE0 ZkFQ6aPan+NBtEk1v3RPqnsQwJsonmiEgfbvybyBpP5MzRZnoAxfQ9vyyXoI5ofbl/+l9wv8 mosKNWIjiQsX3KiyaqygtD/yed5diie5nA7eT6IjL92WfgSelhBCL4jV0fL4w8hah2Azu0Jg 1ZtjjgoDObcAKQ5dLJA0IDsgH/X/G+ZMvkPpPIVaS5QWkiv66hixdKte/4iUrN+4waxJLCit 1KGC2xPJ2UUAEQEAAYkCPAQYAQgAJhYhBIo5khw0X1N0AbpbwBFSLljzHXMuBQJaQk2TAhsM BQkJZgGAAAoJEBFSLljzHXMuOb0P/1EnY4Y6LfQ6bmhJQ6epA3fB70hRWCQsuPYLAgPKRoXy kmWH4ljqQDbA55TtIpnod/woR0IDnZcD7E9cyGzM2rHvSLXTkHhgIWacZHZopAUzq4j0lhiJ Wu57freQPU4rzMVGZXBktUsDMsJwp/3Tl2Kjqylh90qIOlB9laUusLIbl4w5J3EscIJzWvdL y1lJLtBmus/t75wN/aIB8l9YBKGuy0L4SAmjhN52pCgP/S+ANEKvdghQco51a4jD2Pv2uYH7 nUU/Y70AmqOHjPR+qZ0hAUw6B+UtWQ+Fl587Qqi2XPUzdA8G2EjGFFPRlnhf2H/gOyAfeVYL NDwDgm9Yzp7Rx0O1QOnQsXTHqk7K38AdSdM2li/I/zegeblInnLi08Gq6mT6RkD6wV9HE5U3 EIU0rDPyJo54MW39wGjfC2+PM5I0xebbxtnuTewRchVVfm7UWgLAy11pV3xM4wMSJOuqVMOz jYpWKYxDTpvsZ0ginUUY993Gb8k/CxjABEMUGVHhQPZ0OzjHIKS6cTzN6ue8bB+CGOLCaQp1 C0NRT5Tn9zpLxtf5nBExFd/zVENY5vAV2ZbKQdemO54O7j6B9DSgVRrm83GCZxbL4d+qTYBF 3tSCWw/6SG1F3q9gR9QrSC2YRjCmhijUVEh6FhZwB58TNZ1sEEttrps8TDa5tUd9 Message-ID: <7abc7172-11fd-b0e3-6381-f976c5450d4f@gmail.com> Date: Tue, 28 May 2019 17:32:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190528112956.4cf2dd9c@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/28/19 5:29 PM, Steven Rostedt wrote: > On Tue, 28 May 2019 17:18:59 +0200 > Tomas Bortoli wrote: > >>>> + memset(prog_stack, 0, nr_preds * sizeof(*prog_stack)); >>>> + >>> >>> Can you instead just switch the allocation of prog_stack to use >>> kcalloc()? >> >> kmalloc_array() is safe against arithmetic overflow of the arguments. >> Using kcalloc() directly we wouldn't check for that. Not really ideal in >> my opinion. And there's no kcalloc_array() apparently! > > But doesn't kcalloc() simply call kmalloc_array() with the GFP_ZERO > flag? > It does! Oops, I'll send it shortly Tomas