From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39515ECE58C for ; Tue, 15 Oct 2019 19:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0ECBC20663 for ; Tue, 15 Oct 2019 19:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="GtKf/9+n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729489AbfJOTgN (ORCPT ); Tue, 15 Oct 2019 15:36:13 -0400 Received: from mout.gmx.net ([212.227.15.18]:40803 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfJOTgN (ORCPT ); Tue, 15 Oct 2019 15:36:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1571168148; bh=8CtZdk//uT3mD5UzLBd+cEolu2bZMY/XSWPKvl77iw0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=GtKf/9+n3AwqBfQQfX9adpD3gPsyKPR2YKPBuvzNb5Qd3jN8m0kO9xrMsMNxbeERW y27/AeTxcmP5rcgwgWWPNyGMDCISMV8/p7yeARZymdLWC5Y6TpLcsHfKh66lYdUm8K JkkHCq8aDPiNal0Zt/OS73x4NFmqvqy0Tr/g5pJE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.112]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MJmKh-1iearN1SK9-00K63U; Tue, 15 Oct 2019 21:35:48 +0200 Subject: Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4 To: Florian Fainelli , matthias.bgg@kernel.org, "David S . Miller" Cc: Mark Rutland , devicetree@vger.kernel.org, Matthias Brugger , Nicolas Saenz Julienne , linux-kernel@vger.kernel.org, Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20191011184822.866-1-matthias.bgg@kernel.org> <20191011184822.866-4-matthias.bgg@kernel.org> From: Stefan Wahren Message-ID: <7ac16f46-8f75-a91a-c096-7645da8f044a@gmx.net> Date: Tue, 15 Oct 2019 21:35:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Provags-ID: V03:K1:WJUZ0VvS2rEzkhQZcFikR4IvYJzLmGQBvy4te06VSqGg/4lR+v8 gH+1SiXGIh2ZeN2Bidjxg1HQMyO8XuwtSk5bAflNdJx3XLft2M4Y7VrABhA9dFsMVpSqBGP wgvvuLzS03PwqHCefpFa8n4CkYSy+c7kvVEntLdYiPuSySrVcsYiYmkplEDK9LJ3BNpbMBN 6NBpyK9r3gyxIzqAgeg0Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:6NCl5YU0F1c=:UqxKtymJXFQBSh/VJde4rl H/4yHI7y4KLeiL0vJQbqhPKjoE9y4ynssQ5MG6pWmiQqRa9B1T1FW7QZMJmydiX+Z2nkdjpcI qHjtTP4DxUMM+WehFU9H9uq4Qtgd1muixOn8U9C+BHzha/coD2kyz3vH2px0d+Qn2N5ITyx/9 0l5hbATotfHHCkRyX1ARgtaDhNX+tifYuySkq996cDYbNwSkf7oSVO2hakgL2NF9ffGpkKD8L YTURIf8B0wQ7aQqW81v2St891OWA5G7ZhNqlpCpgsFE/Rl4NlX5pX6fxrz8MYbSpRZ0rCdAbF 8YCnV44MjA2rVMD9FxuL7Ym40V+KeCEkXNa44ssHhr/YlXln1dIehgfrpUHHXJd4VKi0yQklR CseAlSLrfvLhIeBAeEcR/Ew7H6OtTGzNmUw2Hg/hIFNoUmAQTm/TXxIondk9SeQh07pg24/sO oA8FgvvoQNokuC26xvilTkWAk8wwY2bNVKh/y/7REgn8wsVx/vPTRHfp248ONJIi2sgJVVq6f PXufm7dVLil8xugop8WIDpoL5PL1mIufaLsKcIj9fR0HjifASfA2saId8BOOMDrckVV38ZZO0 wz8jQU8Q1uFwycupylT5wQPDLQpJv5WFs7dmiBJew7qGNih/0kJsCTuWhG8YaQ5/V3D8EwC5k kO9rUFFYigyhaDonSx8dtI+HVb3OWrjtf+CYgNJQIdIKh1uIKdKsNpC2cOKS+MuXBME/onRhL XKCIB78Zt8p1JZFJEWGvdGeHZooVU3M+NRt37XoTqGpwKq16aRnucUuTwWYBWT2fA9auE1BGg Hnmen07mk/6KU/20M9pXaEyb8OjnBM7VUL9EorseyP+QaXYnPprjowfyb++2kfSEdgCrrxnJX uOilv3uXgpLjr8SyDkrbo//hWsPDt6XqnwECfZSOqHAWI6I3kLubW1Ft5BNLQqOt32ufdRBrv QRdqyVGuZ9G73mpGhnHY6hzF8StoProePrni/iXcjXZc+pKZrRyDup/pZ2VtnzcIAzTDst3ah Ovzmw66eyn77d2PcJjn394+z/FZB1TH8+rrc4Qd8EVR7PX5w8QDFY9BE5WaAg1eUEloKCfGM6 PckBgSsdP/1QEObbrkRbRFIya9m0Z20YHaQeybgvGdxoxK+MS3fVH/n/Ln4LvaXdbVw5e7fZG bd7WEfN3DfcSYsEkVPGWrJJg4FUFZjFwrrGn6/K2j+AJItPawInKiZvACqKNH8LiLAs/3kRnD K/udraqJUtuwlkHnJOUaXcuYuwHQmORb5o7aDGltEGhMfUJVjbdXs2qIPp+s= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, Am 11.10.19 um 21:31 schrieb Florian Fainelli: > On 10/11/19 11:48 AM, matthias.bgg@kernel.org wrote: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. >> >> Signed-off-by: Matthias Brugger >> >> --- >> >> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 22 ++++++++++++++++++++++ >> arch/arm/boot/dts/bcm2711.dtsi | 18 ++++++++++++++++++ >> 2 files changed, 40 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/= bcm2711-rpi-4-b.dts >> index cccc1ccd19be..958553d62670 100644 >> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts >> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts >> @@ -97,6 +97,28 @@ >> status =3D "okay"; >> }; >> >> +&genet { >> + phy-handle =3D <&phy1>; >> + phy-mode =3D "rgmii"; > Can you check that things still work against David Miller's net-next? > Tree, in particular the BCM54213PE PHY might be matched by the BCM54210E > entry in drivers/net/phy/broadcom.c and I just fixed an issue in how > RGMII delays were configured: > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commi= t/?id=3Dfea7fda7f50a6059220f83251e70709e45cc8040 > > This might require you to change the 'phy-mode' property to what is > appropriate. since i didn't get a reply from the Pi folks yet, i tried all the other rgmii variants on top of this branch [1]. But none of them worked. In case of "rgmii-id" i'm getting: unknown phy mode: 9 and for "rgmii-rxid": unknown phy mode: 10 In those cases the PHY didn't even probe. Did i missed something? [1] - https://github.com/lategoodbye/rpi-zero/commits/bcm2711-genet