From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52CA01DFDE for ; Thu, 29 Jan 2026 14:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769696460; cv=none; b=qdRr2HXxjXflzy92rN4t4EPjUsZ/edxEoSw+4MdLyCnkfi3OyApJTeockIoMFbPZ0oSTL98TPmsnT/6kmqPfZqfjkGpBRtrZ1yAz5AIsULdPyQ/CTXPudvcPFo6Bretyleh3ggD3RncN2jAKiAG5iNeS2llhCwS5Nkm6dkEgYN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769696460; c=relaxed/simple; bh=zRxvCVVQMJYVkVUNGE2Tyt26/eIK+Sk2Jr4h2yQLT94=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fEsLZpBkCl/4oWRSXHF/BeqaASG5uUm14lFv8dJ/Usxej+8tEEVDonsORxiYj+bIz29WtAX1LkKGcCL0vNsawPeg2Bo7X+mIlXRSGsnnIlVEtKzCQUtERODTmC8qckW4PTJSoECzuWkk9V4TI3qSPWnYir5fVRvimP6/Mh0BPtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KiQea7gQ; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KiQea7gQ" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-29f2676bb21so8449765ad.0 for ; Thu, 29 Jan 2026 06:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769696459; x=1770301259; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=TS0KWx3bT5mxvGxI2toZXmxExTcE6y7ZRb/LECbq+2I=; b=KiQea7gQQLr3Q6HPhk/1zbwRNQpPFboQ5IhzV7Evj5avdT37QEaQBUKEl9paYm06HH OXLxIaNijBTy4z5WFJ3fN2LGOtYWIiAPCKlEJ02rAzNuwdA8QPW+zNycwI0UtGoJofTy AyRLKHxpb2eXmN0tyVQXYho3FEPYfXSzSHJWX5NLjCdzcTAyreU9jbuTMC+zoyc1cPnj PzMUrMNIY6TDDsbmhhgSl7r23iZ07/k5GVLY0521CiJorMGeZdnaKzYYmhx5qs58Dh4c SyOqSaqSk596DT5ACZLj5ZNSw7CDqz3WPS+uQlfkzC6dwFtoQyCeKokkl9W0Bqv1ogKV 36Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769696459; x=1770301259; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TS0KWx3bT5mxvGxI2toZXmxExTcE6y7ZRb/LECbq+2I=; b=FqDjcE54QM83Wed6IzaEMbtt3sZQXppaYs6RT2rmoiUFXiNGg5R4v9SQrjn/4ozmvn oW3bHW/pKByhDyoxUgukPVGbY/uNTEyt9Vnt7dMT/BNb85smCXw3ge0A92MIqQGugHk3 JZzSAhLkeadbThVKHDGnkomNdXDYh2zvqs9HjUrRryUr4lCWjyByrSvn307SmzTr+qj4 6ztbVAKDR7yelJCOW2JT3DJvGw84pjEh4N3vNvF/HXMGUEgzjLXVYfMPrdF9lcYQkW4U QEBDS1uqEaPYahb2vBBs2IRTuvSGACvrrnIAUOjJYuZ98ePTvE+yJR/hjiC23SWbdgug H4Tg== X-Forwarded-Encrypted: i=1; AJvYcCVN+vdeLri/i8X3CkCDg3T4+1ykiKiQE7ACE2lyUT0Sj5ANqVj2T0/tdlf8agcYVSR66Wyxn7FpjjmiQN0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1FDFuJof/YtYP4ub65hdN1LYAjmsOxnzf/zKXEzwRWMg5qvyY l801+2hUH0XRsPuTurBcWLtsowxVtkS4mPfoiz++qzVvkuw1gWRSUwtn X-Gm-Gg: AZuq6aJynFrczsSUQtIUYTkt0aSrqUk5mUF6r+z6oLNhUQA28dtst3qqm7gZuJyXP1c jK70gjo1IDmuiE+TWozGUED8cK4QRmJzDwh4KnL8PCbYotUZHJ8ZoK90SQWeDbmZvm0s/ukGmxV 4Ju1GETWaC/OjRZGXRvEzMkgNJ7+RNrvmd8Y26HVJtfjKnVYo7AOExTaOwcusXDGtLIuow9abcY kH+xGnMEMhA+Z/aw3tW91XEGPUfGd/cC2opBge4UbG2Thn2iEfcuVxSd6ho984UCBt1FjobGUxe VF7jGGiZ2+HdVvqDKNjZgWM5Y4oNXZcb4k70xzlCO3Qa/QIHVyCRKKPuq33uLxUsWUjG0UIOZfl n1PFTqO3QKlY+Q8REmHYyckDtrHKP7lg2Mf5N/0IFsAuGU3DK8vqLvyBwlLoDpEgskEmxOjb7lq lWNmOGsVRDCtw08Oo/09AT4TqL X-Received: by 2002:a17:903:249:b0:2a5:99e9:569d with SMTP id d9443c01a7336-2a870d6483fmr82656725ad.18.1769696458634; Thu, 29 Jan 2026 06:20:58 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a8980c8623sm40581465ad.94.2026.01.29.06.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 06:20:58 -0800 (PST) Sender: Guenter Roeck Date: Thu, 29 Jan 2026 06:20:57 -0800 From: Guenter Roeck To: Chen Ni Cc: etremblay@distech-controls.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: (tmp513) Add missing check for device_property_read_u32_array Message-ID: <7ade6258-8df6-483b-9f55-3d38e9a50cb3@roeck-us.net> References: <20260128073021.2476709-1-nichen@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128073021.2476709-1-nichen@iscas.ac.cn> On Wed, Jan 28, 2026 at 03:30:21PM +0800, Chen Ni wrote: > Add check for the return value of device_property_read_u32_array() and > return the error if it fails in order to catch the error. > > Signed-off-by: Chen Ni > --- > drivers/hwmon/tmp513.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c > index 5acbfd7d088d..f201d0a9ba14 100644 > --- a/drivers/hwmon/tmp513.c > +++ b/drivers/hwmon/tmp513.c > @@ -676,8 +676,10 @@ static int tmp51x_read_properties(struct device *dev, struct tmp51x_data *data) > if (ret < 0) > return ret; > > - device_property_read_u32_array(dev, "ti,nfactor", data->nfactor, > - data->max_channels - 1); > + ret = device_property_read_u32_array(dev, "ti,nfactor", data->nfactor, > + data->max_channels - 1); > + if (ret) > + return ret; NACK. The default is 0, and the property is optional. Guenter > > // Check if shunt value is compatible with pga-gain > if (data->shunt_uohms > data->pga_gain * 40 * MICRO) { > -- > 2.25.1 > >