mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <jiangjian@cdjrlc.com>, <rth@twiddle.net>,
	<ink@jurassic.park.msu.ru>, <mattst88@gmail.com>
Cc: <linux-alpha@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] alpha: irq_i8259: drop unexpected word 'and' in the comments
Date: Wed, 22 Jun 2022 14:08:14 +0000	[thread overview]
Message-ID: <7ae0e6b2-39e8-2453-b154-6c02734028b6@microchip.com> (raw)
In-Reply-To: <20220622140201.5458-1-jiangjian@cdjrlc.com>


On 22/06/2022 15:02, Jiang Jian wrote:
> there is an unexpected word 'and' in the comments that need to be dropped
> 
> file: arch/alpha/kernel/irq_i8259.c
> line: 150
> 
> *  Therefore, read the mask register and and out those lines
> 
> changed to:
> 
> *  Therefore, read the mask register and and out those lines
> 
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
>   arch/alpha/kernel/irq_i8259.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/alpha/kernel/irq_i8259.c b/arch/alpha/kernel/irq_i8259.c
> index 1dcf0d9038fd..db574dcd6675 100644
> --- a/arch/alpha/kernel/irq_i8259.c
> +++ b/arch/alpha/kernel/irq_i8259.c
> @@ -147,7 +147,7 @@ isa_no_iack_sc_device_interrupt(unsigned long vector)
>   	 */
>   	/*
>   	 *  The first read of gives you *all* interrupting lines.
> -	 *  Therefore, read the mask register and and out those lines
> +	 *  Therefore, read the mask register and out those lines

This does not look like a typo? Surely the second and means the
operator? Maybe it could be reworded for more clarity to something
like "and mask out", but the initial meaning looks sane

Thanks,
Conor.

>   	 *  not enabled.  Note that some documentation has 21 and a1
>   	 *  write only.  This is not true.
>   	 */

  reply	other threads:[~2022-06-22 14:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 14:02 Jiang Jian
2022-06-22 14:08 ` Conor.Dooley [this message]
     [not found]   ` <tencent_6EA3802C352872BC44FBD555@qq.com>
2022-06-22 14:28     ` 回复:[PATCH] " Conor.Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ae0e6b2-39e8-2453-b154-6c02734028b6@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jiangjian@cdjrlc.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®