From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F39C83F3E for ; Tue, 5 Sep 2023 19:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241824AbjIETIf (ORCPT ); Tue, 5 Sep 2023 15:08:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241782AbjIETI3 (ORCPT ); Tue, 5 Sep 2023 15:08:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ABF2EB for ; Tue, 5 Sep 2023 12:07:16 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-207-HStV7FijOPG1Z9hZuKMAcw-1; Tue, 05 Sep 2023 15:06:06 -0400 X-MC-Unique: HStV7FijOPG1Z9hZuKMAcw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 47A1D282380D; Tue, 5 Sep 2023 19:06:06 +0000 (UTC) Received: from [10.22.9.87] (unknown [10.22.9.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0D85140E968; Tue, 5 Sep 2023 19:06:05 +0000 (UTC) Message-ID: <7ae52eec-0df3-9bef-e4f6-e33a1873c464@redhat.com> Date: Tue, 5 Sep 2023 15:06:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATH] cgroup: add cgroup_favordynmods= command-line option Content-Language: en-US From: Waiman Long To: Luiz Capitulino , tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lcapitulino@gmail.com References: <20230831142046.37177-1-luizcap@amazon.com> <20230905170318.GA16629@dev-dsk-luizcap-1d-37beaf15.us-east-1.amazon.com> <664019c3-c4b1-6603-7a3d-f44a81737178@redhat.com> In-Reply-To: <664019c3-c4b1-6603-7a3d-f44a81737178@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/5/23 15:03, Waiman Long wrote: > > On 9/5/23 14:59, Waiman Long wrote: >> >> On 9/5/23 13:03, Luiz Capitulino wrote: >>> On Thu, Aug 31, 2023 at 10:20:46AM -0400, Luiz Capitulino wrote: >>>> We have a need of using favordynmods with cgroup v1, which doesn't >>>> support >>>> changing mount flags during remount. Enabling CONFIG_FAVOR_DYNMODS at >>>> build-time is not an option because we want to be able to selectively >>>> enable it for certain systems. >>>> >>>> This commit addresses this by introducing the cgroup_favordynmods= >>>> command-line option. This option works for both cgroup v1 and v2 and >>>> also allows for disabling favorynmods when the kernel built with >>>> CONFIG_FAVOR_DYNMODS=y. >>>> >>>> Signed-off-by: Luiz Capitulino >>> Hi, >>> >>> Would somebody take a look at this patch please? >>> >>> Thanks, >>> >>> - Luiz >> >> The patch looks good to me. I do have a minor comment that it may be >> better to use the relatively new __ro_after_init qualifier instead of >> __read_mostly. >> > With this patch, CGROUP_FAVOR_DYNMODS kconfig option will have no > user. So this config option should be removed as well. My bad. That is not true. Please ignore this comment. Regards, Longman