From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F5EF32E757 for ; Mon, 3 Aug 2026 15:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785772223; cv=none; b=N6FFjyRamWW6XR9hhxUJrAuFv8/i8yZg86FF21ZBArR+6rxAToZTznFL/bzneQGC8p5yUnjDuPmhWEOP59nRNePNf/kECvpU2hfbxXqSANbzLCmAjrFNrGoTO13QtHAzESECUln23a16gyeh5FZ+vPftTy46ZuakDFuSzIF/IUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785772223; c=relaxed/simple; bh=mzSuL7MszcrY2PnDeJbOJ2bs9P669YqWeObHSK0sayg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q1N1Df8wtE0/qQalfiDNsiIMVgxig2w2pisYnevrBFU1n2nSmAwIN8sRNkVU5jB6urfBwgmxEGOXneVgUSaQPHseZIe2EelaEVDIomnZaAXk7nF5gEv7dJQrXpW5aPR5yqceqIIhUNGxWucuDtRZUGf7NVJApsNRBOg1Bz1MEPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YHFN4YII; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PT2ZXH7e; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YHFN4YII"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PT2ZXH7e" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 673EC3hn655711 for ; Mon, 3 Aug 2026 15:50:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VCgP14LAVui9SPYNKhXy8/aCYBM7qTFR8oqPud903Vg=; b=YHFN4YIITmGnIbV/ Bo+2+UzW0OJEP6YiebwbATiRqEHVmr7T/Bm3MDW8mrKKPQqIad+C0b218ot+Wx1b uEa12Ki8Q/E3zFswoZFWYopH/VqU0cdJ5DDHRegivt0hlB6a3FMSTJ+NW/BdDaue a7OmZv7oWdGHu2zMtQhCmyvG3HSbIKEOPg7fv4RNVs3CZwIYzmo28Nf6Gm9CW4fK cXmetIwCI0OAJLawSGdd/6wmC3cLcYFWaj3xu4rcdNOBM7F7ZpaRlFneqjErC3fg 4EuW/Lfh1VO67X8YbmUApDHulJiEdX7y/MiBe7xBYYvguBUKUfETzUlFr/eCqbab oFrs1A== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftnrntb3a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 15:50:20 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38fa7b09921so6223789a91.1 for ; Mon, 03 Aug 2026 08:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785772220; x=1786377020; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VCgP14LAVui9SPYNKhXy8/aCYBM7qTFR8oqPud903Vg=; b=PT2ZXH7eex9M+DD/GpguuSCEb5UXgbuY5FZWcy4fSaUbLzPf00W1rWR0JpFZLn7xwi 8gv9gJUthNBLO+DyRCvTYfgY0mFnGuNPGcr13AhVwdFqsHICn7miFMl8Drl6s9U/2EkQ LjTW9GqqevMnG5WXD5U20d6OQBcvhJG7S5/mBe7QSYGt1AivoYV5wFav7xDD0IAeTFRz ri0vOxZePSuehTwvKlkMg5Egpuruc1ydxDLmNb6ihBpDN0EDzZfS8pR6ApOnjIfCt5dO bouY693Jrp7sO1b5tUaliLxu5drm/YtkoSvI7a97Dmfe7nwf+VL+DTQhcCYLBzJaHn2H F3bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785772220; x=1786377020; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VCgP14LAVui9SPYNKhXy8/aCYBM7qTFR8oqPud903Vg=; b=MhIHlk87m9jCr2uKw41sV0PcOgioQawKuw2a74zdeF1K0l9SWr5zBMKXhrcUWS0wz3 hOTrCZKn2V8rMS7sSAWjpQnEYe4YVSAKvMTrCWLzupzYB4MN6fsCal99jFj6wl0VwDnd BdPgimx/1gkHNA53+GvrinnvYvc0H734QIEJV/yG0EfxxYFPRZVhwJtU2C3kRFGiXQ/S GUCtdE0zp13nSIJAW9/WTcWyqoXMB64mnKmsll7RMXxod3z2FVmfS7obQ5Do6JVyYKMJ gQhLkjU01gCEoQuM0L2tAVdVjd8/dVZdYOPFpAXgseP3hKRxSFA7PjgpcKFmkq2mWhaO YJ2g== X-Forwarded-Encrypted: i=1; AHgh+RrXAB+iHD8UNnfDaqUcTo+2/2ZtXw2En2+HZeG/S69QE5UwpJRiS49gjPhzwIfdnEXatif5+AmHP0yaq44=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/pRRsIVj7bavNWevs4PxfoEdvmzAHJWs/OOmgECS7l5Xqpjk7 qRZtyXSdcnDK/uOnTmyHsWrvIHmoJgn8Aylthyn6GRl9tMMJeRF+zIUqFVp5NFHmWLnaZbkQgnt FvqwgcaksfeaEGScR+LCHjmDBSAnf0upBvjZ2ySW32+XKDJpZ+/ykMDdD51abMCUWQao= X-Gm-Gg: AR+sD120mAxUWK+iPm2Cngd6PTiBw52+mkWiO6H5QRtzrZxAnCUay1mqNJqNxlgRjO2 He/E9WUn5lCant7kVfv4QQaH7WVEPH83FyOzBgAH+Oep7GoRQUSHFhHKf+rXY0sxfjbOXag29VO 6ZfzJ4QMs1YdkPtOmq/5xHhsLkN8L/IKlx4uPKn9qCD3oz55v5fYTzCboB/kp0QCr4dO1TlzCv+ ykoANQROgMJ0f8N6nKK9n5uuGgFIzG/qO16kotH0YIZciySIwyhzePl68EwARmXRsp7XvAxxAQi Cau8Thfaa1PYDeJsFibxsowJruaK/Wd0gCM4X8VRP0paI0SdWl3p2EyDbqsaPJaMPn3cXCg5yzl 1Tdd4lO8Xc1qofKOUDSXJw6+nHbnFdnoeWg== X-Received: by 2002:a17:90b:5807:b0:37d:ee77:78ac with SMTP id 98e67ed59e1d1-38fbc45585emr10216181a91.19.1785772219769; Mon, 03 Aug 2026 08:50:19 -0700 (PDT) X-Received: by 2002:a17:90b:5807:b0:37d:ee77:78ac with SMTP id 98e67ed59e1d1-38fbc45585emr10216162a91.19.1785772219302; Mon, 03 Aug 2026 08:50:19 -0700 (PDT) Received: from [10.219.49.187] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e045016sm56104807eec.19.2026.08.03.08.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 08:50:18 -0700 (PDT) Message-ID: <7ae5b4b5-708b-4c8a-94e8-3582cac1b762@oss.qualcomm.com> Date: Mon, 3 Aug 2026 21:20:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/7] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks To: Srinivas Kandagatla , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260801054610.4047089-1-prasad.kumpatla@oss.qualcomm.com> <20260801054610.4047089-4-prasad.kumpatla@oss.qualcomm.com> Content-Language: en-US From: Prasad Kumpatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDE0MSBTYWx0ZWRfXyL+sDkonb+PW rQXeB59OHgNPRK/DrXRTRED5VnquHZ4UFevrKmqSXbN8UT7/nl5ZSdmGef8bwK3TgDfjsnKDjcL TcO3+i9Ae+l6V0kg2DlZzXmG3rqvHBE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDE0MSBTYWx0ZWRfX9iLomom3M/0Y NfM1S/CkhmAcJv+8L2NCsFvKhLmAr/VdKlRN3zFx8Akhgsbu6e3KwZDqcaGMT/mrDwFyREzY4UN pASyr11chdaW+CMLbshaFempShRSEWum8gxlE5IcuoGjmfqn+szIwN7ekDpwYYuU1fyE7hxVK1C Ymom0E9UnqvSbBxNUyIHIklcGe/RLlZOPbMP1shurZhdiSFsdWuN5Kf7iViScSOyYtKvEyUwAam 3+P9mhueI4HKSTSSC4EAgJhaKgmuzCUsBElYtGbR7dNlo6t2myizzrZI5EG3xgtyZs/AKf2LEtk qsTC5xqagDRGj/Jl583jQsJEPyPHqLsAs6h4TKz9zDiy2lwQ5mnUGPOlo2k4J/exb8vZO4rdiTW yEnFl8PkJhZSAz6uvFNiGZFiY6vpaZlVfZQltAcK6hWYedWLkDwoWIM1WtcMQ04vOHOvFedZcJ7 gFfeOD97v8DnmowCdWg== X-Authority-Analysis: v=2.4 cv=Zest8MVA c=1 sm=1 tr=0 ts=6a70b8bc cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=TjsEG-x9bXOF-Ie2ovQA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: soT25L95rGroMFF12q7JU9jPKAK-ZrXX X-Proofpoint-ORIG-GUID: soT25L95rGroMFF12q7JU9jPKAK-ZrXX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-03_03,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030141 On 8/2/2026 7:00 PM, Srinivas Kandagatla wrote: > On 8/1/26 6:46 AM, Prasad Kumpatla wrote: >> Add the LPASS Audio IF clock IDs used by newer backend interfaces. >> >> Platforms using Audio IF module backends request the interface bit >> clocks through q6prm. Add the Audio IF IBIT and EBIT IDs to the binding >> header so these clocks can be referenced from device trees. >> >> Signed-off-by: Prasad Kumpatla >> --- > >> .../sound/qcom,q6dsp-lpass-ports.h | 29 +++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> >> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> index 7b553a73bc92..fbcf1ef9ce22 100644 >> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> @@ -233,6 +233,35 @@ >> /* Clock ID for RX CORE MCLK2 2X MCLK */ >> #define LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK 70 >> >> +#define LPASS_CLK_ID_INTF0_IBIT 71 > Patch itself looks fine for me, > But the naming seems to be bit odd and misleading, what does INTF mean > is it QAIF or some other Interface. > > Please prefix the interface name something like > LPASS_CLK_ID_QAIF_IF0_EBIT or LPASS_CLK_ID_TDM_IF0_EBIT.. etc. Hi Srini, Thanks for the suggestion. This LPASS_CLK_ID_QAIF_IF0_EBIT looks good and appropriately. I'll use it in the next revision. Thanks, Prasad > > --srini > >> +#define LPASS_CLK_ID_INTF0_EBIT 72 >> +#define LPASS_CLK_ID_INTF1_IBIT 73 >> +#define LPASS_CLK_ID_INTF1_EBIT 74 >> +#define LPASS_CLK_ID_INTF2_IBIT 75 >> +#define LPASS_CLK_ID_INTF2_EBIT 76 >> +#define LPASS_CLK_ID_INTF3_IBIT 77 >> +#define LPASS_CLK_ID_INTF3_EBIT 78 >> +#define LPASS_CLK_ID_INTF4_IBIT 79 >> +#define LPASS_CLK_ID_INTF4_EBIT 80 >> +#define LPASS_CLK_ID_INTF5_IBIT 81 >> +#define LPASS_CLK_ID_INTF5_EBIT 82 >> +#define LPASS_CLK_ID_INTF6_IBIT 83 >> +#define LPASS_CLK_ID_INTF6_EBIT 84 >> +#define LPASS_CLK_ID_INTF7_IBIT 85 >> +#define LPASS_CLK_ID_INTF7_EBIT 86 >> +#define LPASS_CLK_ID_INTF8_IBIT 87 >> +#define LPASS_CLK_ID_INTF8_EBIT 88 >> +#define LPASS_CLK_ID_INTF9_IBIT 89 >> +#define LPASS_CLK_ID_INTF9_EBIT 90 >> +#define LPASS_CLK_ID_INTF10_IBIT 91 >> +#define LPASS_CLK_ID_INTF10_EBIT 92 >> +#define LPASS_CLK_ID_INTF11_IBIT 93 >> +#define LPASS_CLK_ID_INTF11_EBIT 94 >> +#define LPASS_CLK_ID_INTF12_IBIT 95 >> +#define LPASS_CLK_ID_INTF12_EBIT 96 >> +#define LPASS_CLK_ID_VA_INTF0_IBIT 97 >> +#define LPASS_CLK_ID_VA_INTF0_EBIT 98 >> + >> #define LPASS_HW_AVTIMER_VOTE 101 >> #define LPASS_HW_MACRO_VOTE 102 >> #define LPASS_HW_DCODEC_VOTE 103