mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhang Qiao <zhangqiao22@huawei.com>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	<linux-kernel@vger.kernel.org>, Wander Costa <wcosta@redhat.com>
Subject: Re: [PATCH] sched/deadline: Fix imbalanced task reference
Date: Wed, 7 Aug 2024 17:39:44 +0800	[thread overview]
Message-ID: <7ae6fa16-80d3-4478-baae-b5bc06531e0c@huawei.com> (raw)
In-Reply-To: <ZrM3rZFGg_nPEjjV@jlelli-thinkpadt14gen4.remote.csb>



Hi,
在 2024/8/7 17:00, Juri Lelli 写道:
> Hi,
> 
> On 07/08/24 16:30, Zhang Qiao wrote:
>> When starting a deadline inactive_timer, the task_struct refs will
>> be incremented only if dl_server is not set. But when canceling the
>> inactive_timer, the task refs will be decremented whether dl_server is
>> set or not, leading to a task reference imbalance issue.
>>
>> This patch fixes the imbalanced reference by adding a '!dl_server()'
>> checker before calling put_task_struct().
>>
>> Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
>> Signed-off-by: Zhang Qiao <zhangqiao22@huawei.com>
> 
> Isn't this equivalent to Wander's patch below?
> 

Yeah, i didn't notice it.

> https://lore.kernel.org/lkml/20240724142253.27145-3-wander@redhat.com/
> 



Thanks,
Zhang Qiao.
> Thanks,
> Juri
> 
> 
> 

  reply	other threads:[~2024-08-07  9:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07  8:30 Zhang Qiao
2024-08-07  9:00 ` Juri Lelli
2024-08-07  9:39   ` Zhang Qiao [this message]
2024-08-07  9:46     ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ae6fa16-80d3-4478-baae-b5bc06531e0c@huawei.com \
    --to=zhangqiao22@huawei.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wcosta@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®