mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jeongin Yeo" <jeongin.yeo@luaberry.com>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: hansg@kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, andy@kernel.org,
	matt@mattwardle.net, linux-media@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: use __func__ in debug messages in binary.c
Date: Wed, 27 May 2026 04:25:37 +0900	[thread overview]
Message-ID: <7aecd867-68a8-4c83-a154-a96da89a269b@app.fastmail.com> (raw)
In-Reply-To: <2026052613-glamour-caress-1b8a@gregkh>

On Wed, May 27, 2026, at 1:21 AM, Greg KH wrote:
> dev_dbg() already has __func__ in the output, why is it needed again?

You're right, dynamic_debug's 'f' flag can already emit the function
name, so both __func__ and the "ia_css_binary_find()" prefix were redundant.

I'll send v2 that removes the function name strings entirely instead
of converting them to __func__.

Thanks for the review.

Jeongin Yeo

      reply	other threads:[~2026-05-26 19:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 10:47 Jeongin Yeo
2026-05-26 16:21 ` Greg KH
2026-05-26 19:25   ` Jeongin Yeo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aecd867-68a8-4c83-a154-a96da89a269b@app.fastmail.com \
    --to=jeongin.yeo@luaberry.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=matt@mattwardle.net \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®