From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbcITHii (ORCPT ); Tue, 20 Sep 2016 03:38:38 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:33531 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089AbcITHie (ORCPT ); Tue, 20 Sep 2016 03:38:34 -0400 X-AuditID: cbfec7f2-f79556d000002c42-28-57e0e774144d Subject: Re: [PATCH] leds: Only remove trigger if one is actually configured. To: Daniel Romell , rpurdie@rpsys.net Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Romell From: Jacek Anaszewski Message-id: <7aece952-ce5a-6f8f-eddc-4267d6964d20@samsung.com> Date: Tue, 20 Sep 2016 09:38:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <75e5d60e-39e4-574f-5417-7532f1f19f1f@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42LZduznOd2S5w/CDb78NLJ4vqyXyeJI83cW i8u75rBZbH2zjtFi966nrA6sHjtn3WX36Hl8gN1jz/wfrB6fN8kFsERx2aSk5mSWpRbp2yVw ZVxq+stY0MRT8eHwfOYGxgauLkZODgkBE4nLXzewQNhiEhfurWfrYuTiEBJYyijxtO8+O4Tz mVGi7+0UdpiOz192QVUtY5Tonf6UBcJ5xijxouc8M0iVsIC/xN2NC5lAbBEBW4ndr1+AxZkF oiVaDs8Hi7MJGEr8fPEazOYVsJNY9vQdI4jNIqAqsbR7M1Ccg0NUIEJi991UiBJBiR+T74Gd yilgLzGnayo7xEhHiQeLdrJC2PISm9e8ZQa5R0Kgm12ic10bC8gcCQFZiU0HmCEecJG429wO 9bKwxKvjW6Aek5G4PLmbBaJ3MqPExWM3WSGc1YwSGzs7oTqsJRr+/2KB2MYnMWnbdGaIBbwS HW1CECUeEo2dk6DCjhLHZ4hCwucIo8SG/mfMExjlZyH5ZxaSH2Yh+WEBI/MqRpHU0uLc9NRi Y73ixNzi0rx0veT83E2MwJRx+t/xTzsYv56wOsQowMGoxMO74vH9cCHWxLLiytxDjBIczEoi vNeePggX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzrtnwZVwIYH0xJLU7NTUgtQimCwTB6dUAyPH swni1puaC4KtvxwtYHoV7eKxtnH9vlOvbNcsnbjvzqOHfbfXtW6RD+/Puy9g276//bPd5stv lMpmiNneEXSaxLpqrqfz7Rifmwt659muP17ZknmhfnbuV2sjvklrH5qGa9/90OrGdMnqm/vT iJtB+7z7KyftDd1nIG+mIPF3+ZsLBQyn3/gpsRRnJBpqMRcVJwIAIOmsfRUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsVy+t/xy7puzx+EGxxrEbF4vqyXyeJI83cW i8u75rBZbH2zjtFi966nrA6sHjtn3WX36Hl8gN1jz/wfrB6fN8kFsES52WSkJqakFimk5iXn p2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLeNS01/Ggiae ig+H5zM3MDZwdTFyckgImEh8/rKLDcIWk7hwbz2QzcUhJLCEUaK9rY8VwnnGKDH39D52kCph AV+Jrb8ngNkiArYSu1+/YIYoOsYo8WpyLyNIglkgWuLb2rPMIDabgKHEzxevmUBsXgE7iWVP 34HVsAioSizt3gwWFxWIkLi16iMjRI2gxI/J91hAbE4Be4k5XVPZIWbaSix4v44FwpaX2Lzm LfMERoFZSFpmISmbhaRsASPzKkaR1NLi3PTcYiO94sTc4tK8dL3k/NxNjMAI2nbs55YdjF3v gg8xCnAwKvHwBjy8Hy7EmlhWXJl7iFGCg1lJhPf00wfhQrwpiZVVqUX58UWlOanFhxhNgZ6Y yCwlmpwPjO68knhDE0NzS0MjYwsLcyMjJXHeqR+uhAsJpCeWpGanphakFsH0MXFwSjUwikad X164T+LT/O+TzxZFNSjaeX8o6HB1+F71o/2JUPL08PU/im+8yBBzzPi656ZF95vbSz6fXK3/ kCes9lLWfoFGoeKI+JwC0UWVGyN1Y8s/z5je+P4T61z5gunM19zqXqwNWZP2/Edk4BWH/PYC 25DbZxvl7er2TAzo8Qxce+aYdvjXYtnZSizFGYmGWsxFxYkASDxN4LYCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160920073828eucas1p174bcf6598d691e9d77b9172d6ebc28b2 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160914092340eucas1p27f875a415de6684be5b09872ab1b9ab6 X-RootMTR: 20160914092340eucas1p27f875a415de6684be5b09872ab1b9ab6 References: <1473844987-21112-1-git-send-email-daro@hms.se> <75e5d60e-39e4-574f-5417-7532f1f19f1f@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, I dropped that patch because we need to fix the problem at the origin, i.e. inside led_trigger_set(). I submitted the patch [0] doing that, and credited you by adding Reported-by tag to the commit message. Thanks, Jacek Anaszewski On 09/15/2016 01:48 PM, Jacek Anaszewski wrote: > Hi Daniel, > > On 09/14/2016 11:23 AM, Daniel Romell wrote: >> In led_trigger_remove(), check if there is a trigger >> configured before calling led_trigger_set(). This will >> prevent some unnecessary work, and more importantly stop >> sending uevent change events when no change has in fact >> occurred. >> >> Signed-off-by: Daniel Romell >> --- >> drivers/leds/led-triggers.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c >> index 59d6a3e..28c7a66 100644 >> --- a/drivers/leds/led-triggers.c >> +++ b/drivers/leds/led-triggers.c >> @@ -147,7 +147,8 @@ EXPORT_SYMBOL_GPL(led_trigger_set); >> void led_trigger_remove(struct led_classdev *led_cdev) >> { >> down_write(&led_cdev->trigger_lock); >> - led_trigger_set(led_cdev, NULL); >> + if (led_cdev->trigger) >> + led_trigger_set(led_cdev, NULL); >> up_write(&led_cdev->trigger_lock); >> } >> EXPORT_SYMBOL_GPL(led_trigger_remove); >> > > Thanks for the patch. Applied. > [0] https://git.kernel.org/cgit/linux/kernel/git/j.anaszewski/linux-leds.git/commit/?h=for-next&id=19afa7b4c4c9deebd312d293df2e2703de29e26a