From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FEBBC433EF for ; Wed, 15 Sep 2021 07:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7C1B61164 for ; Wed, 15 Sep 2021 07:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236548AbhIOHOB (ORCPT ); Wed, 15 Sep 2021 03:14:01 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:60112 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234862AbhIOHOA (ORCPT ); Wed, 15 Sep 2021 03:14:00 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 01C3E1FE47; Wed, 15 Sep 2021 07:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631689961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6bfTUsetN6ewLSVGJM0Xk5gc+BqIXK4MyH/8xgJBOew=; b=ZEGszKZuN3ou+cwEoPDB031g/MU6ELAQUN4+AhyNziA2a/APO/5qqvXAIOaoSymxsRlHPH KM7eXOrVLhPMsO9BlrCFO2NUZFTc5C8+lC1Wp4LhPYAJ0N8sBKVGVLDg9eru+layXKGNZi x3A39tn97qZVHwdZm+5Os4mbW8HB7Ig= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631689961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6bfTUsetN6ewLSVGJM0Xk5gc+BqIXK4MyH/8xgJBOew=; b=8BjqgYs/JMtJ9YquxfjlUdUysrKNAu9sG1+ciPjuPpJkUunW5jE6SGwjceay6Zx7QrUx6V 4XlkYIVioRTn6SBg== Received: from ggherdovich.udp.ovpn1.nue.suse.de (unknown [10.163.29.78]) by relay2.suse.de (Postfix) with ESMTP id 752F9A3B95; Wed, 15 Sep 2021 07:12:40 +0000 (UTC) Message-ID: <7af6051cfc0a40a2461cfaa645cff3dd885d8671.camel@suse.cz> Subject: Re: [PATCH] x86/smp: Unused value freq_scale From: Giovanni Gherdovich To: Tim Gardner , x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Peter Zijlstra (Intel)" , "Rafael J. Wysocki" , Vitaly Kuznetsov , Alison Schofield , Nathan Fontenot , Balbir Singh , linux-kernel@vger.kernel.org Date: Wed, 15 Sep 2021 09:12:34 +0200 In-Reply-To: <20210910184405.24422-1-tim.gardner@canonical.com> References: <20210910184405.24422-1-tim.gardner@canonical.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-09-10 at 12:44 -0600, Tim Gardner wrote: > Coverity warns of an unused value in arch_scale_freq_tick(). > > CID 100778 (#1 of 1): Unused value (UNUSED_VALUE) > assigned_value: Assigning value 1024ULL to freq_scale here, but that stored > value is overwritten before it can be used. > > e2b0d619b400a ("x86, sched: check for counters overflow in frequency invariant > accounting") introduced this warning. > > Fix this by removing the variable initializer. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: "Peter Zijlstra (Intel)" > Cc: Giovanni Gherdovich > Cc: "Rafael J. Wysocki" > Cc: Vitaly Kuznetsov > Cc: Alison Schofield > Cc: Nathan Fontenot > Cc: Balbir Singh > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Tim Gardner > --- > arch/x86/kernel/smpboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index 85f6e242b6b4..c453b825a57f 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -2166,7 +2166,7 @@ DEFINE_PER_CPU(unsigned long, arch_freq_scale) = SCHED_CAPACITY_SCALE; > > void arch_scale_freq_tick(void) > { > - u64 freq_scale = SCHED_CAPACITY_SCALE; > + u64 freq_scale; > u64 aperf, mperf; > u64 acnt, mcnt; > Reviewed-by: Giovanni Gherdovich Thanks, Giovanni