From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Jaakko Karrenpalo <jkarrenpalo@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Lukasz Majewski <lukma@denx.de>,
MD Danish Anwar <danishanwar@ti.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jaakko Karrenpalo <jaakko.karrenpalo@fi.abb.com>
Subject: Re: [PATCH net-next v2 2/2] net: hsr: Add KUnit test for PRP
Date: Tue, 11 Mar 2025 10:00:40 -0700 [thread overview]
Message-ID: <7af90d36-028c-4f82-8ef0-d86252dd1342@oss.qualcomm.com> (raw)
In-Reply-To: <20250221101023.91915-2-jkarrenpalo@gmail.com>
On 2/21/25 02:10, Jaakko Karrenpalo wrote:
...
> +MODULE_LICENSE("GPL");
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. Please add a MODULE_DESCRIPTION()
to avoid this warning.
This is a canned review based upon finding a MODULE_LICENSE without a
MODULE_DESCRIPTION.
/jeff
next prev parent reply other threads:[~2025-03-11 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 10:10 [PATCH net-next v2 1/2] net: hsr: Fix PRP duplicate detection Jaakko Karrenpalo
2025-02-21 10:10 ` [PATCH net-next v2 2/2] net: hsr: Add KUnit test for PRP Jaakko Karrenpalo
2025-02-25 11:04 ` Paolo Abeni
2025-03-11 17:00 ` Jeff Johnson [this message]
2025-02-25 10:58 ` [PATCH net-next v2 1/2] net: hsr: Fix PRP duplicate detection Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7af90d36-028c-4f82-8ef0-d86252dd1342@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jaakko.karrenpalo@fi.abb.com \
--cc=jkarrenpalo@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®