From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752601AbeADRrN (ORCPT + 1 other); Thu, 4 Jan 2018 12:47:13 -0500 Received: from vern.gendns.com ([206.190.152.46]:43899 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbeADRrM (ORCPT ); Thu, 4 Jan 2018 12:47:12 -0500 Subject: Re: [PATCH v4 5/7] clk: Introduce davinci clocks To: Sekhar Nori , linux-arm-kernel@lists.infradead.org Cc: Kevin Hilman , Adam Ford , linux-kernel@vger.kernel.org References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-6-git-send-email-david@lechnology.com> From: David Lechner Message-ID: <7af9bf5a-317e-0bcd-99b8-5a1ad1d894b8@lechnology.com> Date: Thu, 4 Jan 2018 11:47:07 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/4/18 6:43 AM, Sekhar Nori wrote: > Hi David, > > On Monday 01 January 2018 05:09 AM, David Lechner wrote: >> + /* TODO: old davinci clocks for da850 set MDCTL_FORCE bit for sata and >> + * dsp here. Is this really needed? >> + */ > > The commit that introduced this flag suggests so. > > commit aad70de20fc69970a3080e7e8f02b54a4a3fe3e6 > Author: Sekhar Nori > AuthorDate: Wed Jul 6 06:01:22 2011 +0000 > Commit: Sekhar Nori > CommitDate: Fri Jul 8 11:10:09 2011 +0530 > > davinci: enable forced transitions on PSC > > Some DaVinci modules like the SATA on DA850 > need forced module state transitions. > > Define a "force" flag which can be passed to > the PSC config function to enable it to make > forced transitions. > > Forced transitions shouldn't normally be attempted, > unless the TRM explicitly specifies its usage. > > ChangeLog: > v2: > Modified to take care of the fact that > davinci_psc_config() now takes the flags > directly. > > Signed-off-by: Sekhar Nori > > I can check without that flag again, but I do recall it being needed. > OK, I will add it back. I need to add some other flags as well anyway.