From: "Csókás Bence" <csokas.bence@prolan.hu>
To: Markus Elfring <Markus.Elfring@web.de>,
<dmaengine@vger.kernel.org>, <linux-sunxi@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Chen-Yu Tsai <wens@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [v6] dma-engine: sun4i: Simplify error handling in probe()
Date: Tue, 25 Mar 2025 09:58:57 +0100 [thread overview]
Message-ID: <7afcbbee-6261-4b2f-be14-a3076746d53c@prolan.hu> (raw)
In-Reply-To: <7332ccd2-ebe6-4b9d-a2ae-8f33641e7bd4@web.de>
Hi,
On 2025. 03. 25. 9:47, Markus Elfring wrote:
> Implementation details are probably worth for another look.
What don't you like in the implementation? Let's discuss that then.
>> On 2025. 03. 24. 18:20, Bence Csókás wrote:
>>> Clean up error handling by using devm functions and dev_err_probe(). This
>>> should make it easier to add new code, as we can eliminate the "goto
>>> ladder" in sun4i_dma_probe().
> Please distinguish better between information from the “changelog”
> and items in a message subject.
What do you mean? The email body will be the commit message.
> Regards,
> Markus
Bence
next prev parent reply other threads:[~2025-03-25 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 17:20 [PATCH v6] " Bence Csókás
2025-03-24 17:55 ` Markus Elfring
2025-03-25 8:26 ` Csókás Bence
2025-03-25 8:47 ` [v6] " Markus Elfring
2025-03-25 8:58 ` Csókás Bence [this message]
2025-03-25 9:12 ` Markus Elfring
2025-03-25 12:20 ` Julian Calaby
2025-03-25 12:38 ` Markus Elfring
2025-03-25 12:39 ` Csókás Bence
2025-03-25 13:04 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7afcbbee-6261-4b2f-be14-a3076746d53c@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=Markus.Elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®