From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52604263F22 for ; Wed, 5 Nov 2025 09:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762333780; cv=none; b=DUex7SM0AiTklWDTy1bmlGvL9VH3QCoOQ0PmIAjKBtVA80BRemzpVJ0d3Xk26srRwjqv84zBM1N+KeoqCQn+QG6vnX1+l8G/qEuPv7+FDqDjV8Bu0GJGhXfd0/RQLgZZoRT4ViBTY34DrvTvP8h/aBVuz9WyaZocpIFh0H3CP0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762333780; c=relaxed/simple; bh=DuyibBwlS16eTmbuqE4VFLviK3weahnDnhuDAdd587E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KXvmoTiWkI9b7hr3iGBewn9HlmQ/ZuXnfntaOw6UPOVxV17o6soIAEMLUnohWt2jwo0gqsci9C2rQJJJBJoGFJr3nb/boAWBhW8DgzJO4lO2aPIy6O/Up87pHTwRkT+xxQEbE4HRCxDIiqW1ktmYfjCTHQ0DHNY+urNKuN9Vz70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CeGv7ysD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QYgG/wr8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CeGv7ysD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QYgG/wr8" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A57ucHq159604 for ; Wed, 5 Nov 2025 09:09:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nK7DC1IMtSjbTQ9eM6xGUT/x7vNfyLmo7q+p1AF+pTc=; b=CeGv7ysDx9vEl5Fj aMqMyyM4ecNJjpH+EvWJxm1G2o3tj49/ZmygOxzBHGwLTngNabXrJkMnmPPhv9bn +7wPceXBWfc3szHNzKWmrAqUfz+epWnW87KuCD1uMRsrQec5Pe18ClnrVtasJPhS d8YVjWl02vHQ3qjnhBJsqAy3NgUHzkTeYxy12JwNGy/U+NRgripwa6JVUKFO6Fb2 TdcAQAC1Zco251JsuBWWnsKo4lUnhH2rGUBIkBZ9e3SQmZE7M/81VO1EmKaB4Qk3 Tk1+sD7uX2DxVYQ0007knodvUWBT0Tbfo4O84h4j2qybyu+thCdDaflJ/inngERe Xxh+ig== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a82mt06xx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 05 Nov 2025 09:09:38 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8800460ca8dso23929246d6.3 for ; Wed, 05 Nov 2025 01:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762333777; x=1762938577; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nK7DC1IMtSjbTQ9eM6xGUT/x7vNfyLmo7q+p1AF+pTc=; b=QYgG/wr8ApOnyM+VlAzE183l7DBU2Jd+ikGKKLnMoBi9/qPgTqL06K+sXBKT9gF5e/ 0v2hl9BhTIwCfa/ye+iSO74urb/1ZT33Iig3AC2VGuJzlEwKVhcMCX8cRr6/1s52yN1u BfcjOdLq1Rtuj455d4Zw07rt4EpOmmVlLCdM4y4Bx2vyIJWLbUPGmXiaZZMbPm/ACimG oVpHLSI4VHlRTN5LtBmUCLybuvxwt0Zkh1o2DM+QRqECbB05djDADoKE8LUn/ybhYSZq EwjACtuOIZzYgKd27Visy8z+ARZYEoNNmVpm3Mw5jB794LitrPmDAJ5LvS+qFIs7W5c3 9Aag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762333777; x=1762938577; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nK7DC1IMtSjbTQ9eM6xGUT/x7vNfyLmo7q+p1AF+pTc=; b=m4zBxY56wp3wl5hhs28V7AXlCza915IY03GYbj98S0xkEt+kbfY+Xn3FnafURrDeeM qmASWh/YymuaMHIQN8BS3SGCnOqz5uF99Vj7s/CrQ+FryVZaMEU95fElMDoakIhDyKn5 G2GV2fTjSldJyLSWTFlZRCA2KqFFq/6+FdL/5sAuXMkbAZolhzmpIn0ZLlM/ocApp7J9 QCWvaJCBTBVqf/uTdAYMvVTP3qFQLnY55AODR79ByUM1UVWnfLwyA65zVh5nGN5l5XGZ a9N4rK+GCVPIg1cdIgBA3/+KPO5LIQxQhYLI06Kfz+K/w+GPp89Q8S15LJ76VlV9XyXf hgFw== X-Forwarded-Encrypted: i=1; AJvYcCUgBnozFSCBDfCILgRM1G12mnoZS+chfYU3tAN8sFVNMdI2K6xg0rKRzXPIai6zjv+LFcx5NMiTNi58WlI=@vger.kernel.org X-Gm-Message-State: AOJu0YxkoM6DBdteHIAY/9k/hn5Z1rapNygeFPLs3cby4xk5dbOLw9nh 1wQVS0k0mAniqzdWOGBIDAyhpLVUzmdkuBaJtG6deLxPpVUABtDzOXhs1dx+E2Nk83x4ADp29ol uDrLq484lHifW5qQtHfj/zA394kS5lHhAUI1qg4CfwsN39jEVUN/JYvEN9q9FZs3Tys8= X-Gm-Gg: ASbGnctlIRtqutzTKAPmXaaG70zthuv8frG0IKwQ9b6h8n7a6p5P1jVcHi+RxOyjrId pjPRMuOF0KfxYgNRiMkQIEiGuXxFeC//ECxi67bvQpO1iI0ddySWMDpVVPWAbys18EHXlb+I3CX JbtS79dWbO4CljzF78yS28uastIy+h0efFGbez8AIqBwjRHI/BkG6TtwTpFiBge+OtdLsEX6OzT 4tWXa1CAJcSFvowcNgjGOivqAT53BRHRbQaEwdB2ktl1HfD1ZHHCwmPIpnvjjAQ86r+yQz3kMCR R6rsNdTgLnyjGakti5+bUn/pwpNq3Bzb5ffUdbrGztXuU+5LcJZ6Y/H83AwND+hwUYA57BqW/gO xiXSQzG/4zFrK9xYYA9ZjMkuOB+eL3PHBAedU5RyZP5DADq+SKnhhTUSA X-Received: by 2002:a05:622a:1a0a:b0:4e6:eaff:3a4b with SMTP id d75a77b69052e-4ed7233253bmr20208861cf.4.1762333777445; Wed, 05 Nov 2025 01:09:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJ8qazVdRxb2HPWUGZnt0hJ3G3Yu31pg3BrDUWBi9VZDTTGHvUX8RIKyYz1xHi/Pys6k6MmQ== X-Received: by 2002:a05:622a:1a0a:b0:4e6:eaff:3a4b with SMTP id d75a77b69052e-4ed7233253bmr20208571cf.4.1762333776901; Wed, 05 Nov 2025 01:09:36 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-640e6a5cb52sm4081058a12.23.2025.11.05.01.09.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Nov 2025 01:09:36 -0800 (PST) Message-ID: <7affc5e7-14b9-4959-9943-40e416f64d92@oss.qualcomm.com> Date: Wed, 5 Nov 2025 10:09:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: hamoa: enable ETR and CTCU devices To: Jie Gan , Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251104-enable-etr-and-ctcu-for-hamoa-v1-0-af552cfb902c@oss.qualcomm.com> <20251104-enable-etr-and-ctcu-for-hamoa-v1-2-af552cfb902c@oss.qualcomm.com> <25b7abfe-1881-41e5-914b-ee16ce63ed3e@oss.qualcomm.com> <8a7dd1b4-505a-4507-8cc1-75d955c706eb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <8a7dd1b4-505a-4507-8cc1-75d955c706eb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA1MDA2NyBTYWx0ZWRfX/sy9dxITlTKI 0wypERo8N0kNYy6JSLvKgkGsrgkLeBKyo4eb66LuTBlypfLk3UPrnoy7MXPIyTsAMV3gJTi0XQp rsr6qX2cvg2G55+yFuNDTpoogJ+C956AGmIqs/tKR748jbzt06b9Vc2FASZTYaB5GJTeHazKBWy IbscGjWAz87WlQZGcFcjd6U3UF3rsHHgjQm4K3Iq+Wb8dH4LOMnG7Ilmtoqz5mquthq0lkowVrz H7EK8QuCbmIKmuGWuiFTAkpBNH03vJh6Mo/8eikAymREYAvEf7GIUh0wB5ed25eOu3a0cVk0LjJ rkDoqngPUNl1lI7i0KirHl1n5ZIqpzUT4R2hOteO7G4uB/LWskm2SRY6Ik+KOZ4r/31nOoj1CAT Mx3z9XTyjz/hxtNNfQyzQNkl6/3ZLg== X-Proofpoint-GUID: x7jvccJQMQ4hA2ifOOD3xvz5-kzA_Jel X-Authority-Analysis: v=2.4 cv=LLtrgZW9 c=1 sm=1 tr=0 ts=690b1452 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=qzgm85ZZqHKQ8I3g2P4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: x7jvccJQMQ4hA2ifOOD3xvz5-kzA_Jel X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-05_03,2025-11-03_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511050067 On 11/5/25 2:14 AM, Jie Gan wrote: > > > On 11/4/2025 8:47 PM, Konrad Dybcio wrote: >> On 11/4/25 9:10 AM, Jie Gan wrote: >>> Embedded Trace Router(ETR) is working as a DDR memory sink to collect >>> tracing data from source device. >>> >>> The CTCU serves as the control unit for the ETR device, managing its >>> behavior to determine how trace data is collected. >>> >>> Signed-off-by: Jie Gan >>> --- >>>   arch/arm64/boot/dts/qcom/hamoa.dtsi | 160 +++++++++++++++++++++++++++++++++++- >>>   1 file changed, 159 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi >>> index a17900eacb20..ca4a473614ee 100644 >>> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi >>> @@ -6713,6 +6713,35 @@ data-pins { >>>               }; >>>           }; >>>   +        ctcu@10001000 { >>> +            compatible = "qcom,hamoa-ctcu","qcom,sa8775p-ctcu"; >> >> Missing space between after the comma >> >> no issues otherwise > > sorry for the mistake. Do I need send a new version to fix it? I think you do since Krzysztof made some comments Konrad