From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9F7417369 for ; Mon, 6 Jul 2026 12:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783341725; cv=none; b=TuZJIOSKj5mCTfWShXbJ0BaG9UDp8Qmbc3UoMlclsYCYpXeOZY8g9CmlxemLz99z6NPDY9ho4xthsdChKOUlnvKW1XDOcHkOwZxR0syCT7lpjszEKs5HRPzISh5Iv1UT1z5BOJuzeyTTazftCRi011dJCQyEMidQhbHUsMMZ9KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783341725; c=relaxed/simple; bh=5d5qoXwl6X/5EBmgduABc6v7RYTqWqznF2Ylbfa9TqA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GKeTWLzFeiM/pumGq+dauHAaC6Q/wdWGxMFxpwGBvrFy0JVHG7PKmriJs8U08QL3ACDXSRAXSzGPimZJ2v9X9cVMunElh33OmdR36QBcme2SP2LvGGv5LoiVEj9WfgHp3NnsMH8p5W1Nu0mNp2uPV6lc2xxbFGE7alqHNa6OWIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D2GfBjLY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NATlTPT2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D2GfBjLY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NATlTPT2" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxCNv238119 for ; Mon, 6 Jul 2026 12:42:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=E7a8FZgAvm2jtvI2nBoVIO8e /0jyCPrf9wufDVot4/A=; b=D2GfBjLYdRe1tLMLQF1YWlnizNBaOHEkRx8Eg8HC 8dqKiG/a6cYKufC4d7/iy2x37ogIE8KIpXQQfO1F2NRU6qKQn4/tBO76n0uSD4Wm XUKDZZEOFmxCMuTZT3qej0eBsA14+iBArEWGQelS00rbBW/QIOMaa1EmsSLG1Cxa 2IhW1DVVHbARbDv8B0iKq5EWnnUvLk4ObT+O+2Ddfa8PaJhwE1eAozGbpxmTJb6Y +ss/uWvVSojTX6HZYxRQO/dlqz6hzictxXfreMihG82MUlqoRkf6GHy7ajLfuAVf m/6mudTI+I2j7L3uK9a+fr/NMbTnYg00OQsW1NekaM90Ug== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88t88yj0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 12:42:00 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5bdaa7039d7so3996720e0c.1 for ; Mon, 06 Jul 2026 05:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783341719; x=1783946519; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=E7a8FZgAvm2jtvI2nBoVIO8e/0jyCPrf9wufDVot4/A=; b=NATlTPT2OBA1sMfmqJiuzPUYyFa4/t+5WX4d4rgJARKf2k1UXi/4nbv2qDEcmrhigw 3D9HJWLzs/vaugtNy+5jT1cmELppi00oApJPXRfMB4xoBRFIdbQCWgPw/AmRyx0vaf2y cfJl4bl4hfmQpZqDbfc0N+UxZx0M0jWnIDSyneNg1OrMKeT4UUZ/3kgGU9+DgrSdsLp8 rFIaonLjin8NHfxDW3WEx79vFGj+6n1cfoOE56ErDFwvWLx4JIh8KJWMdwfpLPKRfwBv V+tntSFCP4aEn0G8GwNDGSTZR7hdQQFnpKAuAt9eT59jfs/NXTgGNRD7aXHD/1voROQR ISyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783341719; x=1783946519; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E7a8FZgAvm2jtvI2nBoVIO8e/0jyCPrf9wufDVot4/A=; b=OYxOP/EkcfyKCjLWUe1xRf3gsESSpAo11s9wh37V5icYu7P0TSnLLSbMOKXLVFaQFR MbJ+EQgqjGpzOFILvY9X7xoI85gUxjNOsq/t/4KTHKQVi9tdV3SqEqAkIWWUOHS9ji0K Y/vrQ+7ATnD4YIhKKjUGaJoIxC1Z1WRt7/Vs5by6h706GslnRdXRxWo23Wr9HByaOqRo UyX1UUwGnOKZldYhq95pBQS4xQhke25jMZVJhznD9n9ndUyvfhkVSMlS8Lvi/OrP9QMz 14CT946ZVv54jUQFMviGwwls6u+mLogODMO8lUMJOTWTOhEfINn43PMfCjMEIU4bX9jV ChFA== X-Forwarded-Encrypted: i=1; AHgh+Rqp28TcdznDP56fy2bH9R1nr+V+nk2Et3VT8UZqsc9g/aJx30RbV3MH/uO/oJG7Ke2HPAKIZ/uj4/rbGIw=@vger.kernel.org X-Gm-Message-State: AOJu0YwtRXyoNtheILMfSMkhdAJdDINPnluIWKt/RLVpQYyEAHgu0iS9 xIBcZz9P6tpNy/TjKJJYiehjvAlBR9XZSeWhi6ScisxvjDCVbvJew32GHNlTXPDnyfxqeOO4/Nd nfXnqW61i6FUdoiCMzl7Wrb9D6SUjNbcnE1Th8SOlHK8dAnOSwpVANm3K4p/C3lmsgYI= X-Gm-Gg: AfdE7cm76tz9I4sGxpskovipS3eZXcbbRWLQAmpJZjkoNEgE0/OIArZHwcEO1NTPU25 Z7wkRaFlhKHlECxWJtZaAwFi6ihhNWJjWTb1Ur+9oOCcN1kERMStfwggw/sM3hDUqXfj52smket R8V2GoAn3Wk8hgYncYam1CpMKPo16nJZEFzRTPpiy6i2nbjHFGtkRh2G0cWAtuFhIhHusiq9IGT HnR5JbPQZHI2Ny3gj2nXj5ZJ/8BtJhw9+Uj97KjY0XyWHLo/BsnfdztVuRIn5SkQyc2mkBH43JG HnHdHlHRZu0NSHWjf6vfXHHNc/JIbKbgQ49bxv2+HO1nhIV7EhcRirEUjWH/Ayi3iPFKINPIFvX S6KEXRk0Xo56fCrtgO+blpNLoxi0if4Q4zQxZDodk36T0Zf2K+U6/2C8ymy9Jsao7rSA1r1IDmM R5vkCBjAeKcWPjG4Zbv9fzZDoV X-Received: by 2002:a05:6122:1809:b0:5bc:58d:ce4 with SMTP id 71dfb90a1353d-5be8952c6d3mr190094e0c.0.1783341719196; Mon, 06 Jul 2026 05:41:59 -0700 (PDT) X-Received: by 2002:a05:6122:1809:b0:5bc:58d:ce4 with SMTP id 71dfb90a1353d-5be8952c6d3mr190070e0c.0.1783341718729; Mon, 06 Jul 2026 05:41:58 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13bb685sm2849659e87.46.2026.07.06.05.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 05:41:57 -0700 (PDT) Date: Mon, 6 Jul 2026 15:41:55 +0300 From: Dmitry Baryshkov To: Atanas Filipov Cc: linux-media@vger.kernel.org, bryan.odonoghue@linaro.org, vladimir.zapolskiy@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/5] media: qcom: camss: Populate CAMSS child devices via DT Message-ID: <7agyvdlmpnvvjnhigs2plukv26johazvxw23qg62v6eroavkih@dz45xwot36mx> References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-2-atanas.filipov@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706071113.383215-2-atanas.filipov@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDEyOSBTYWx0ZWRfX5+l+EpK/h4Vk d9jjDfju8/SxRJS5lu+ZY4XIWa3jvodCNRcGzQSivAx+lpGg3gh6nvMTqlLCGUlKwZmW9Gycwvg bzIpzc+xnACX1gekalCekQrN9uW22xE= X-Proofpoint-GUID: CnpV25qFkUuJE0NhI6GgSBx7XKHfP6sg X-Authority-Analysis: v=2.4 cv=C6zZDwP+ c=1 sm=1 tr=0 ts=6a4ba298 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=jnYD6DY7q27B8yBxuWgA:9 a=CjuIK1q_8ugA:10 a=XD7yVLdPMpWraOa8Un9W:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: CnpV25qFkUuJE0NhI6GgSBx7XKHfP6sg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDEyOSBTYWx0ZWRfX3Bzegzikqn3v y8coQLVIwTSD0S+iCK173bkA60QEt9Z4sTG+3jvKCgKTSOgk/wi7iu/8dvP5GHNF8l4rxIzeivu RpKsiTSog1AjrAEhKcsQSuxrPjSgm7XegyQwe620zxmWa3s8zBw9EeOrLHjTy0yFEfjWG6Ksljb zQ4LCox5AaDlk0XvXz1/XogqLhIAFiAr1IXy24wpQPe5cDvTz0xa0X/FviV/cTVpgmXq6H647aQ Ay6jUzKmbgK0hO/ot0tlxnv+77HOMFv2ORL7Ki0+uSXxpB63w6Te6ATFCrTbFY7osJ5BAHqiS6L 9wb0QzeVtImQBUHwzH3n7Ayczl/yqXcCOScUm83adIzcUxLG6Ke9O4Kp/RT7gpwhns42TBKRuTY s0mTPITf5RPURX9t4d4NqTEZidk6E64NoEBMz4/eSj6rMkGZ8gchHaGWHWgb8BJrdtA0fzQkcH2 zbIwZEmHSJyLKKkM6pQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060129 On Mon, Jul 06, 2026 at 10:11:09AM +0300, Atanas Filipov wrote: > From: Bryan O'Donoghue > > Use devm_of_platform_populate() so that child nodes declared under the > CAMSS device tree node (e.g. OPE) are automatically instantiated as > platform devices. This is required now that CAMSS is modelled as a > simple-bus and ISP blocks such as OPE are described as child nodes. > > Signed-off-by: Bryan O'Donoghue > Reviewed-by: Loic Poulain > Signed-off-by: Atanas Filipov > --- > drivers/media/platform/qcom/camss/camss.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 2123f6388e3d..95e655a8b6aa 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -5362,6 +5363,8 @@ static int camss_probe(struct platform_device *pdev) > if (!camss) > return -ENOMEM; > > + devm_of_platform_populate(dev); Don't ignore the error code. Also, are the children ready to be probed at this point? Usually, it should happen _After_ the camss is being fully set up. > + > camss->res = of_device_get_match_data(dev); > > atomic_set(&camss->ref_count, 0); > -- > 2.34.1 > -- With best wishes Dmitry