From: Hannes Reinecke <hare@suse.de>
To: John Garry <john.garry@huawei.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com,
jinpu.wang@cloud.ionos.com, damien.lemoal@wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, ipylypiv@google.com, changyuanl@google.com
Subject: Re: [PATCH v4 5/7] scsi: pm8001: Use sas_task_find_rq() for tagging
Date: Tue, 18 Oct 2022 14:03:50 +0200 [thread overview]
Message-ID: <7b049690-b3e8-6e45-ffef-967df77a7f48@suse.de> (raw)
In-Reply-To: <1666091763-11023-6-git-send-email-john.garry@huawei.com>
On 10/18/22 13:16, John Garry wrote:
> The request associated with a scsi command coming from the block layer
> has a unique tag, so use that when possible for getting a CCB.
>
> Unfortunately we don't support reserved commands in the SCSI midlayer yet,
> so in the interim continue to manage those tags internally (along with
> tags for private commands).
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/scsi/pm8001/pm8001_init.c | 12 ++++--------
> drivers/scsi/pm8001/pm8001_sas.c | 13 +++++++++----
> drivers/scsi/pm8001/pm8001_sas.h | 11 ++++++++---
> drivers/scsi/pm8001/pm80xx_hwi.c | 19 +++----------------
> 4 files changed, 24 insertions(+), 31 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
next prev parent reply other threads:[~2022-10-18 12:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 11:15 [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers John Garry
2022-10-18 11:15 ` [PATCH v4 1/7] scsi: libsas: Add sas_task_find_rq() John Garry
2022-10-18 11:15 ` [PATCH v4 2/7] scsi: hisi_sas: Use sas_task_find_rq() John Garry
2022-10-18 11:15 ` [PATCH v4 3/7] scsi: hisi_sas: Put reserved tags in lower region of tagset John Garry
2022-10-18 12:02 ` Hannes Reinecke
2022-10-18 11:16 ` [PATCH v4 4/7] scsi: pm8001: Remove pm8001_tag_init() John Garry
2022-10-18 11:16 ` [PATCH v4 5/7] scsi: pm8001: Use sas_task_find_rq() for tagging John Garry
2022-10-18 12:03 ` Hannes Reinecke [this message]
2022-10-18 11:16 ` [PATCH v4 6/7] scsi: mvsas: Delete mvs_tag_init() John Garry
2022-10-18 11:16 ` [PATCH v4 7/7] scsi: mvsas: Use sas_task_find_rq() for tagging John Garry
2022-10-22 3:05 ` [PATCH v4 0/7] scsi: libsas: Use request tag in more drivers Martin K. Petersen
2022-10-27 2:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b049690-b3e8-6e45-ffef-967df77a7f48@suse.de \
--to=hare@suse.de \
--cc=changyuanl@google.com \
--cc=damien.lemoal@wdc.com \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®