From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C3BC7EE25 for ; Fri, 9 Jun 2023 03:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235558AbjFIDb3 (ORCPT ); Thu, 8 Jun 2023 23:31:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjFIDb0 (ORCPT ); Thu, 8 Jun 2023 23:31:26 -0400 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79DCB30ED for ; Thu, 8 Jun 2023 20:31:23 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VkgUALR_1686281479; Received: from 30.97.48.228(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VkgUALR_1686281479) by smtp.aliyun-inc.com; Fri, 09 Jun 2023 11:31:20 +0800 Message-ID: <7b0ac912-6606-0a76-608d-59f8e2b113ea@linux.alibaba.com> Date: Fri, 9 Jun 2023 11:31:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v6 1/5] erofs: use absolute position in xattr iterator To: Jingbo Xu , chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230608113020.66626-1-jefflexu@linux.alibaba.com> <20230608113020.66626-2-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230608113020.66626-2-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/8 19:30, Jingbo Xu wrote: > Replace blkaddr/ofs with pos in 'struct erofs_xattr_iter'. > > After erofs_bread() is introduced to replace raw page cache APIs for > metadata I/Os handling, xattr_iter_fixup() is no longer needed anymore. > > In addition, it is also unnecessary to check if the iterated position is > span over the block boundary as absolute offset is used instead of > blkaddr + offset pairs. > > Signed-off-by: Jingbo Xu ... > > @@ -399,9 +365,10 @@ static int shared_getxattr(struct inode *inode, struct getxattr_iter *it) > > for (i = 0; i < vi->xattr_shared_count; ++i) { > xsid = vi->xattr_shared_xattrs[i]; > - it->it.blkaddr = erofs_xattr_blkaddr(sb, xsid); > - it->it.ofs = erofs_xattr_blkoff(sb, xsid); > - it->it.kaddr = erofs_bread(&it->it.buf, it->it.blkaddr, EROFS_KMAP); > + it->it.pos = erofs_pos(sb, EROFS_SB(sb)->xattr_blkaddr) + > + xsid * sizeof(__u32); ^ sizeof(__le32); ? > + it->it.kaddr = erofs_bread(&it->it.buf, > + erofs_blknr(sb, it->it.pos), EROFS_KMAP); > if (IS_ERR(it->it.kaddr)) > return PTR_ERR(it->it.kaddr); > > @@ -604,9 +571,10 @@ static int shared_listxattr(struct listxattr_iter *it) > > for (i = 0; i < vi->xattr_shared_count; ++i) { > xsid = vi->xattr_shared_xattrs[i]; > - it->it.blkaddr = erofs_xattr_blkaddr(sb, xsid); > - it->it.ofs = erofs_xattr_blkoff(sb, xsid); > - it->it.kaddr = erofs_bread(&it->it.buf, it->it.blkaddr, EROFS_KMAP); > + it->it.pos = erofs_pos(sb, EROFS_SB(sb)->xattr_blkaddr) + > + xsid * sizeof(__u32); ^ sizeof(__le32); ? Otherwise it looks good to me. Thanks, Gao Xiang