From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Brown <broonie@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
open list <linux-kernel@vger.kernel.org>,
<lkft-triage@lists.linaro.org>, Emese Revfy <re.emese@gmail.com>,
<hsinyi@chromium.org>, Will Deacon <will@kernel.org>,
Willy Tarreau <w@1wt.eu>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: arm64: pointer_auth.h:40:3: error: implicit declaration of function ‘get_random_bytes’; did you mean ‘get_random_once’?
Date: Thu, 30 Jul 2020 22:04:32 +0300 [thread overview]
Message-ID: <7b0c0f44-f56d-5e71-cf86-dbdea190267a@ti.com> (raw)
In-Reply-To: <CAHk-=whn8OB-QbxpffK=Lhh6Mhj+Y2ALFZ1asCgtnQOnmQgWUw@mail.gmail.com>
On 30/07/2020 21:56, Linus Torvalds wrote:
> On Thu, Jul 30, 2020 at 11:47 AM Grygorii Strashko
> <grygorii.strashko@ti.com> wrote:
>>
>>
>> I'd like to note that below set of patches:
>> 1c9df907da83 random: fix circular include dependency on arm64 after addition of percpu.h
>> 83bdc7275e62 random32: remove net_rand_state from the latent entropy gcc plugin
>> f227e3ec3b5c random32: update the net random state on interrupt and activity
>>
>> also break ARM build for the case:
>> #if defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6)
>
> Lovely.
>
> I think I'll have to revert 1c9df907da83 after all, and use Marc
> Zyngier's patch to just remove that troublesome <asm/pointer_auth.h>
> include in arm64 instead.
>
> This turned out to be much messier than it should have been.
FYI. Below diff seems fixes build:
diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h
index f44f448537f2..1a3eedbac4a2 100644
--- a/arch/arm/include/asm/percpu.h
+++ b/arch/arm/include/asm/percpu.h
@@ -5,6 +5,8 @@
#ifndef _ASM_ARM_PERCPU_H_
#define _ASM_ARM_PERCPU_H_
+#include <asm/thread_info.h>
+
/*
* Same as asm-generic/percpu.h, except that we store the per cpu offset
* in the TPIDRPRW. TPIDRPRW only exists on V6K and V7
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-07-30 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:55 Naresh Kamboju
2020-07-30 11:15 ` Stephen Rothwell
2020-07-30 18:46 ` Grygorii Strashko
2020-07-30 18:56 ` Linus Torvalds
2020-07-30 19:04 ` Grygorii Strashko [this message]
2020-07-30 19:40 ` Linus Torvalds
2020-07-30 19:43 ` Grygorii Strashko
2020-07-31 2:16 ` arm64: pointer_auth.h:40:3: error: implicit declaration of function 'get_random_bytes'; did you mean 'get_random_once'? Willy Tarreau
2020-07-31 5:25 ` Linus Torvalds
2020-07-31 5:46 ` Willy Tarreau
2020-07-31 7:52 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0c0f44-f56d-5e71-cf86-dbdea190267a@ti.com \
--to=grygorii.strashko@ti.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=hsinyi@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mark.rutland@arm.com \
--cc=naresh.kamboju@linaro.org \
--cc=re.emese@gmail.com \
--cc=richard.henderson@linaro.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®