From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933687AbdCURD1 (ORCPT ); Tue, 21 Mar 2017 13:03:27 -0400 Received: from foss.arm.com ([217.140.101.70]:56244 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932660AbdCURD0 (ORCPT ); Tue, 21 Mar 2017 13:03:26 -0400 Subject: Re: [PATCH] mailbox: check ->last_tx_done for NULL in case of timer-based polling To: Alexey Klimov , jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org References: <1490115454-32308-1-git-send-email-alexey.klimov@arm.com> Cc: Sudeep Holla , jaswinder.singh@linaro.org From: Sudeep Holla Organization: ARM Message-ID: <7b0ee7c4-6470-bfe8-1609-79283c4f4de3@arm.com> Date: Tue, 21 Mar 2017 17:03:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1490115454-32308-1-git-send-email-alexey.klimov@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/03/17 16:57, Alexey Klimov wrote: > It is allowed by code to register mailbox controller that sets txdone_poll > flag to request timer-based polling with missed ->last_tx_done() method. > If such thing happens and since presence of last_tx_done() is not checked > it will fail in hrtimer callback function txdone_hrtimer() when first > message will be transmitted. > > This patch adds check for this method and logging of error on > registration of mailbox controller if it requested timer-based polling. > Good to have check. Acked-by: Sudeep Holla -- Regards, Sudeep