From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>, Sidharth Sharma <wednisegit@gmail.com>
Cc: venkataprasad.potturu@amd.com, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, Mario.Limonciello@amd.com,
"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>
Subject: Re: [PATCH v2] ASoC: amd: ps: Add support for MSI Crosshair A16 HX
Date: Mon, 18 May 2026 14:21:51 +0530 [thread overview]
Message-ID: <7b1501cd-081b-44b7-82f7-41d4584a4fe6@amd.com> (raw)
In-Reply-To: <d6776836-9a1c-4663-b435-8d5b05b8b956@sirena.org.uk>
On 5/18/26 14:09, Mark Brown wrote:
> On Mon, May 18, 2026 at 02:09:55AM +0530, Sidharth Sharma wrote:
>> The MSI Crosshair A16 HX (D8WFKG) uses a Ryzen 9 8940HX processor,
>> which identifies with ACP PCI revision 0x62. This revision is currently
>> unlisted in the Pink Sardine driver, causing the probe to return -ENODEV.
>> @@ -587,6 +605,7 @@ static int snd_acp63_probe(struct pci_dev *pci,
>>
>> /* ACP PCI revision id check for ACP6.3, ACP7.0 & ACP7.1 platforms */
>> switch (pci->revision) {
>> + case ACP62_PCI_REV:
>> case ACP63_PCI_REV:
>> case ACP70_PCI_REV:
>> case ACP71_PCI_REV:
> Don't we also need an update to acp_hw_init_ops()?
This patch should be dropped. ACP PCI rev id:0x62 support is included
in sound/soc/amd/yc folder. Code changes related to any new platform
addition for ACP PCI rev id 0x62 should be included in yc folder.
prev parent reply other threads:[~2026-05-18 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 20:39 Sidharth Sharma
2026-05-18 2:20 ` Mukunda,Vijendar
2026-05-18 8:39 ` Mark Brown
2026-05-18 8:51 ` Mukunda,Vijendar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b1501cd-081b-44b7-82f7-41d4584a4fe6@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=wednisegit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®