From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: Franklin S Cooper Jr <fcooper@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@kernel.org>,
Axel Haslam <ahaslam@baylibre.com>,
Alexandre Bailon <abailon@baylibre.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Jiri Slaby <jslaby@suse.com>, <linux-serial@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] serial: 8250: Add new port type for TI DA8xx/OMAPL13x/AM17xx/AM18xx/C66x
Date: Thu, 5 Jan 2017 13:51:50 +0530 [thread overview]
Message-ID: <7b175d65-7193-32e4-999b-e3cdd0005c3a@ti.com> (raw)
In-Reply-To: <1483561814-21953-3-git-send-email-david@lechnology.com>
On Thursday 05 January 2017 02:00 AM, David Lechner wrote:
> This adds a new UART port type for TI DA8xx/OMAPL13x/AM17xx/AM18xx/C66x.
The Keystone2 processors do include the C66x DSP. But the SoCs being
targeted with this patch are the ARM + DSP variants. Using 66AK2x is
more appropriate.
http://www.ti.com/lsds/ti/processors/dsp/c6000_dsp-arm/66ak2x/overview.page
Also, DA8xx includes DA830 which is pin-compatible with AM17x. So you
can shorten the list of supported processors to DA8xx/66AK2x.
> These SoCs have standard 8250 registers plus some extra non-standard
> registers.
>
> The UART will not function unless the non-standard Power and Emulation
> Management Register (PWREMU_MGMT) is configured correctly. This is
> currently handled in arch/arm/mach-davinci/serial.c for non-device-tree
> boards. Making this part of the UART driver will allow UART to work on
> device-tree boards as well and the mach code can eventually be removed.
>
> Signed-off-by: David Lechner <david@lechnology.com>
Looks good to me, apart from the minor change above.
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
next prev parent reply other threads:[~2017-01-05 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 20:30 [PATCH v2 0/4] TI DA8xx/OMAPL13x/AM17xx/AM18xx/C66x UART David Lechner
2017-01-04 20:30 ` [PATCH v2 1/4] doc: DT: Add ti,da830-uart to serial/8250 bindings David Lechner
2017-01-04 20:30 ` [PATCH v2 2/4] serial: 8250: Add new port type for TI DA8xx/OMAPL13x/AM17xx/AM18xx/C66x David Lechner
2017-01-05 8:21 ` Sekhar Nori [this message]
2017-01-04 20:30 ` [PATCH v2 3/4] ARM: da850: Add ti,da830-uart compatible for serial ports David Lechner
2017-01-04 20:30 ` [PATCH v2 4/4] ARM: dts: keystone: Add "ti,da830-uart" compatible string David Lechner
2017-01-04 22:00 ` Santosh Shilimkar
2017-01-05 9:04 ` Sekhar Nori
2017-01-05 17:10 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b175d65-7193-32e4-999b-e3cdd0005c3a@ti.com \
--to=nsekhar@ti.com \
--cc=abailon@baylibre.com \
--cc=ahaslam@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®