From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E3172D73B5 for ; Thu, 29 Jan 2026 12:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769689082; cv=none; b=ryb+oGhMzMSQuxoB7FREtlZmGnXChXOR12bkqp/WafjtO4dDU4DTCFrZVFuauruYO99beoCdr3sVCc8CHKzy4Qm1qb61v/CHRTnhxMBFH3VIo752am4gPKlRPCpJ7yp7aKTUjojAVp+eVyXc3OWY7UWzw6GP1QOsoAKFBErpHXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769689082; c=relaxed/simple; bh=7G2vAEHNegfOtPP4Ox8PcGDR2+nERnG0SVVl7JqceYQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RiESGxA4pwIFQgOEKQGjOF9VvBrp6DhSyIXeQ84NtDQPC82fu6KFK2lyrGzLnsOj97XwG9CKRXhyVOKTChndD31rM0ZJJKFYF3JIGaBpQzZHWP8UpRoCojOpqnmtAEexII8ZFEA4mVOtP8Ty8DBsnavo4O02aJRnpJ6zXs6kzIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LsTVVIj1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZXFyN9qJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LsTVVIj1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZXFyN9qJ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TABiUu2033509 for ; Thu, 29 Jan 2026 12:17:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FcrwN2wnlNsCPb8qZU41GPI4nI5ZkjV4GQKGB3maAUU=; b=LsTVVIj1PPZjodkk FzATDHzgchsILT5pTnWw+S3WwzG++XE4y01Jn9CugZTGE66vc3qYVXQnDpr6JIxJ 5N1BkRcLeDQWje7A78/HUZDVLBYLWH0DeG05FmqWylhhMivXQPyUnW//tWlXmi1w jzHhv6UEhEBblfmAIO2Pxx/Ku1c+VJjmJcfCUjIMATgQSEjE4QViRVUsdEw1KGma Dkf5wbTwXiAdbvwfY9rytvPrF/uN9ThvBTeKhboNR9FT+tTidJ4mlTdNda82dvzY UtDQIgoqFx7PCTZEnAAwWfgaYUXKkx32Nd0JqHG9UlSh2g1J5KG/9V0Mj0BEPqXS ksbGBQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bytqy2cyr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 12:17:57 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b2fdf3a190so14983385a.0 for ; Thu, 29 Jan 2026 04:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769689077; x=1770293877; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FcrwN2wnlNsCPb8qZU41GPI4nI5ZkjV4GQKGB3maAUU=; b=ZXFyN9qJ3GY2MUcQfhGYxP1CAAWB4eW3Jhho8DfRSHklzxiQLsdgUQhH3Ls/pN4o39 JfphziZGOk8TEFsG7wTWC+GZc4qQ3bf/spGxTQXjuxLnHfeUhOeY/M8Vzj8qV6OjP20U I1wOo6yOpbx0OZLFcb3+UZFoR4VMZd6ochJ/9kzGEkFWnJgmlr80uLWh2MVZnfX65oBw 0p+sNzGWvxK0XjFOj6pCWg1pvuUnkTdvCLswePlvmulM8cHdtR4ORw/Fvy8hzCyOtx/h m42ANmGcawhoq0ljPwoRp8Z18nTGr72ZYGgHWgg3IcH16nzGUFu7XPT2RsT9GJljxUMn borw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769689077; x=1770293877; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FcrwN2wnlNsCPb8qZU41GPI4nI5ZkjV4GQKGB3maAUU=; b=hRRnbRbRiDiw/F6neU28zRcLOq6fzjseaRXeqcHtm8zuTZxQrkKcI8KVoCAGZfZfp5 h8NppediMpG5c7iaH3hr9gOBrrBf2VljK50aH3yzOQ0E8N29PA62AP50PHW3UWuQc9Xd ZsWRQnz1ruQaysjZaTNlwF2xIMf1YLivbXCyndfziD45ncwL5Sw9W5KscNPy5JFMAMoZ bgfjNzx8JfipMPaQarGEVUqOuhyo1qg+RMOYIY0+c4O2kH1T1VCHhIpC8az6m9FiPJYD 5wkrMD/385jE5Wwl3d9cRlcT1X6luYY1EmdKPz0YAGHt9JgNRqezcRM8jGzaqcgPfx0b EBEA== X-Forwarded-Encrypted: i=1; AJvYcCUNlsovbTuuyj01gr1ePakorijoQWlp1np3KdXrNk/2y5wcAqR1ibsVjcgYOIUzgUHOkVYtrd7GrmZIL2k=@vger.kernel.org X-Gm-Message-State: AOJu0YzatpCZ+MjW8wXbNS7p0dS5hK5mtUp1D5aW3AcFkrM2fOo8gvDA +zmRG1cgazfFFvSmj3O9W6O5KG9BJhk5uGA7+W0uSu4hMHerdKx0eShcG78q2SVdn0Cv8xUYk+k ZqCOOkqIeN1t+DuWzwXyKxAhK+/eWqwnGAa6kuGMrzL1NnrPLvxNPBAWc1SPaB9AyjUk= X-Gm-Gg: AZuq6aKvzUelM5h46ACAFlTZbiP6z3AT56mKOIFBysPcN93ACc5x8VCfvHVmcx8G/ym VJDo6TQS/+ovDR3jNkmJdTBLPl8lX/lEePMHsRmE2WkU/ra1rQ2tXCuGdTxruSG4OclZPF4JD63 29qNNiafMFHEzRX89dl/WTwRAno4Dn1TprXgHCehOf7Gl9SKmoTA521gHTblEVetKm/B/jbIGUt 8Q9tNoH90Il6zVZfj7uuPDSF2wE88Pn9ltyLHM+MCFvxNnyMm4LrFXlL8XNZt/jQ6nnXlhKJYJO gmf+rfYpkGX3+BS57qE1XmQ50Y1GbOHs9WAk5VjH0PMFD4B5r7uPqwdWLAxvsNW9ojL/4I6v2Rm fMOjEng2w9nn7PXhQIIZcW+ZN2JWDKaKoNYgZRaaULPL3FqeVXtxPxZP5xG+3lzd5Uc8= X-Received: by 2002:a05:620a:bc5:b0:7e6:9e2b:6140 with SMTP id af79cd13be357-8c71ade7be3mr352929485a.8.1769689076965; Thu, 29 Jan 2026 04:17:56 -0800 (PST) X-Received: by 2002:a05:620a:bc5:b0:7e6:9e2b:6140 with SMTP id af79cd13be357-8c71ade7be3mr352926785a.8.1769689076547; Thu, 29 Jan 2026 04:17:56 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b46abea5sm2831410a12.31.2026.01.29.04.17.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 04:17:55 -0800 (PST) Message-ID: <7b219a50-6971-4a0c-a465-418f8abd5556@oss.qualcomm.com> Date: Thu, 29 Jan 2026 13:17:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/4] Enable ICE clock scaling To: Abhinaba Rakshit , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA4MiBTYWx0ZWRfX52A2kueiuF3M GeCKM0aaY7LewboB3NEL3A0jiMoe88KONt/wO6Y4DSADxiF0ODuHQP3q+jVX4OAoYGFAMABNwQI M8xUCYCC4Vu4lkqfcJ0xjeHa7roUswy6p6Q6Hh8xUqGSpiUUp/RCxXiR/TSx4S6zTIskLhEHNQW S4Uo2L04UTT6qBS4dlr7s4VhVbWVeJcPs2Rd+ashGrxL/A+uiBXZMpiLz4EAE+PXDD9AQAc1lrM PsfL4U5EdFfDZs1wyZ92WzkqnK9jNJ6VrERTjUkRzUqNf62I3VnFH63wIMbZcZajdPYH5j5yL+N uNkCX9ArmUoiju5Tr2JhkscyaZjJ2J7X5NwnOtnzmC3GwpYL45/TgKbp5RPpNhWw2IwAbPyGzeb 5tOEv+XGH7EVg2/G1v+2N3PzkrMmUYJRXDPc/scdsZvYFhx2QSP1haSs0cDujxjySAq0JDSXV3p Evh7j1CWb7R/6EuWw4w== X-Authority-Analysis: v=2.4 cv=Je2xbEKV c=1 sm=1 tr=0 ts=697b4ff5 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=4MEm5NcWsPKhGJVxAVQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: zBX0CWc-Cth59iJxYDo_c49z2ivkOhNk X-Proofpoint-GUID: zBX0CWc-Cth59iJxYDo_c49z2ivkOhNk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290082 On 1/28/26 9:46 AM, Abhinaba Rakshit wrote: > Introduce support for dynamic clock scaling of the ICE (Inline Crypto Engine) > using the OPP framework. During ICE device probe, the driver now attempts to > parse an optional OPP table from the ICE-specific device tree node to > determine minimum and maximum supported frequencies for DVFS-aware operations. > API qcom_ice_scale_clk is exposed by ICE driver and is invoked by UFS host > controller driver in response to clock scaling requests, ensuring coordination > between ICE and host controller. > > For MMC controllers that do not support clock scaling, the ICE clock frequency > is kept aligned with the MMC controller’s clock rate (TURBO) to ensure > consistent operation. You skipped that bit, so I had to do a little digging.. This paragraph sounds scary on the surface, as leaving a TURBO vote hanging would absolutely wreck the power/thermal profile of a running device, however sdhci-msm's autosuspend functions quiesce the ICE by calling qcom_ice_suspend() I think you're missing a dev_pm_opp_set(dev, NULL) or so in that function and a mirrored restore in _resume Konrad