From: Ping-Ke Shih <pkshih@realtek.com>
To: "Ondřej Jirman" <megi@xff.cz>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v3 2/2] wifi: rtw89: Fix inadverent sharing of struct ieee80211_supported_band data
Date: Wed, 30 Apr 2025 00:16:47 +0000 [thread overview]
Message-ID: <7b2405f82b8f4b879d10453dde55a7f3@realtek.com> (raw)
In-Reply-To: <20250429122916.1734879-3-megi@xff.cz>
Ondřej Jirman <megi@xff.cz> wrote:
>
> Internally wiphy writes to individual channels in this structure,
> so we must not share one static definition of channel list between
> multiple device instances, because that causes hard to debug
> breakage.
>
> For example, with two rtw89 driven devices in the system, channel
> information may get incoherent, preventing channel use.
>
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thanks for your prompt work. :-)
next prev parent reply other threads:[~2025-04-30 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 12:29 [PATCH rtw-next v3 0/2] " Ondřej Jirman
2025-04-29 12:29 ` [PATCH rtw-next v3 1/2] wifi: rtw89: Convert rtw89_core_set_supported_band to use devm_* Ondřej Jirman
2025-05-05 2:21 ` Ping-Ke Shih
2025-04-29 12:29 ` [PATCH rtw-next v3 2/2] wifi: rtw89: Fix inadverent sharing of struct ieee80211_supported_band data Ondřej Jirman
2025-04-30 0:16 ` Ping-Ke Shih [this message]
2025-04-30 13:25 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b2405f82b8f4b879d10453dde55a7f3@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®