From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D0F5361DCF for ; Fri, 20 Mar 2026 07:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773993598; cv=none; b=LbzUHamua4xMBDQ/FwkhuoKFh0unNh44qncF7bMB6iEUI9uthwBTw4taOx71lyqISpjILf6Y8j+Df2rYPXVUFvz4SGeAhtWb+5uk38NtP1qGaY48iG1JBoO6ZF76WnQFChAXAbNPhitAgQYv6s7YQM8Wx1kYn32VGS7cTn02DB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773993598; c=relaxed/simple; bh=HPpGwfuFzXf1sMOcck8YSRZm2+TSPrhGY9dG07VqcUc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=gPK1DywtpNDuTZkb5840ibEZbjtS2RzrJ4FMYKV5uuHBYfmgEQ4bIwXYe3s0GjGPlkSBMTHgHHQyP+IdQdsphWr+jym8o+pL6FHgSgw/gfY10MyAEDIN9XOVxyxpCLtjshbq6oAnPx+Y9ULodX5NsvSxKWZLv5aHXkNLyR3gq1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=Pscm422y; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="Pscm422y" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20260320075952euoutp026efcb2e09dc618aed3c9770a7dcafdee~efcXgac0t2986329863euoutp02M for ; Fri, 20 Mar 2026 07:59:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20260320075952euoutp026efcb2e09dc618aed3c9770a7dcafdee~efcXgac0t2986329863euoutp02M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1773993592; bh=bagVJH+MEvrpzI0KecUI8aBmeZE84fBwnnlwBT7sG9I=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=Pscm422ye0MT5g/mYXfjxJpczYYq2KnO0AAsBJmHHmY1m/gKGzuOFbOCBF/6afiIF edTrwG2OKaoas2e2mR7aXNz6fmNxb/3doFWD3qa/iHu2btNIrNlShTBsySYrAcD3/e edu6osNO8TfDYxaYUhMMiUfByRPOF9uC8nAGP9xk= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260320075951eucas1p2ee4f774eec93464aa99acb3509bfd4a7~efcXOCUOP0250502505eucas1p26; Fri, 20 Mar 2026 07:59:51 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20260320075950eusmtip1136c02642e2399f808c9bfd2329dbaf5~efcWgSL8Q0430404304eusmtip1f; Fri, 20 Mar 2026 07:59:50 +0000 (GMT) Message-ID: <7b2a7e76-9025-41b8-8136-7af867d8146d@samsung.com> Date: Fri, 20 Mar 2026 08:59:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [RFC PATCH] media: vb2: use ssize_t for vb2_read/vb2_write To: Zile Xiong , Tomasz Figa , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20260320065445.75351-1-xiongzile99@gmail.com> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260320075951eucas1p2ee4f774eec93464aa99acb3509bfd4a7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260320065508eucas1p10be4e6428076c2f2d396eb4474d64935 X-EPHeader: CA X-CMS-RootMailID: 20260320065508eucas1p10be4e6428076c2f2d396eb4474d64935 References: <20260320065445.75351-1-xiongzile99@gmail.com> On 20.03.2026 07:54, Zile Xiong wrote: > vb2_read() and vb2_write() return size_t, but propagate > negative errno values from __vb2_perform_fileio(). > > This relies on implicit signed/unsigned conversions in callers > (e.g. vb2_fop_read()) to recover error codes: > > __vb2_perform_fileio() -> -EINVAL > vb2_read() -> (size_t)-EINVAL > vb2_fop_read() -> -EINVAL > > This relies on implicit conversions that are not obvious. > > These helpers are exported (EXPORT_SYMBOL_GPL) and part of the > vb2 API, so changing their return type may affect existing users. > > However, they conceptually follow read/write semantics, where > ssize_t is typically used to return either a byte count or a > negative error code. > > Switch vb2_read() and vb2_write() to ssize_t, and update > __vb2_perform_fileio() accordingly. > > This is an RFC to gather feedback. > > Signed-off-by: Zile Xiong Acked-by: Marek Szyprowski vb2_fop_read() and vb2_fop_write() return ssize_t type, so the same should be used for vb2_read() and vb2_write(), as well as __vb2_perform_fileio(). This issue was there from the beginning of this code, so it would make sense to add: Fixes: b25748fe6126 ("[media] v4l: videobuf2: add read() and write() emulator") > --- > drivers/media/common/videobuf2/videobuf2-core.c | 6 +++--- > include/media/videobuf2-core.h | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c > index adf668b213c2..8a2b8156e9da 100644 > --- a/drivers/media/common/videobuf2/videobuf2-core.c > +++ b/drivers/media/common/videobuf2/videobuf2-core.c > @@ -2990,7 +2990,7 @@ static int __vb2_cleanup_fileio(struct vb2_queue *q) > * @nonblock: mode selector (1 means blocking calls, 0 means nonblocking) > * @read: access mode selector (1 means read, 0 means write) > */ > -static size_t __vb2_perform_fileio(struct vb2_queue *q, char __user *data, size_t count, > +static ssize_t __vb2_perform_fileio(struct vb2_queue *q, char __user *data, size_t count, > loff_t *ppos, int nonblock, int read) > { > struct vb2_fileio_data *fileio; > @@ -3154,14 +3154,14 @@ static size_t __vb2_perform_fileio(struct vb2_queue *q, char __user *data, size_ > return ret; > } > > -size_t vb2_read(struct vb2_queue *q, char __user *data, size_t count, > +ssize_t vb2_read(struct vb2_queue *q, char __user *data, size_t count, > loff_t *ppos, int nonblocking) > { > return __vb2_perform_fileio(q, data, count, ppos, nonblocking, 1); > } > EXPORT_SYMBOL_GPL(vb2_read); > > -size_t vb2_write(struct vb2_queue *q, const char __user *data, size_t count, > +ssize_t vb2_write(struct vb2_queue *q, const char __user *data, size_t count, > loff_t *ppos, int nonblocking) > { > return __vb2_perform_fileio(q, (char __user *) data, count, > diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h > index 4424d481d7f7..bf20bcb1d366 100644 > --- a/include/media/videobuf2-core.h > +++ b/include/media/videobuf2-core.h > @@ -1093,7 +1093,7 @@ __poll_t vb2_core_poll(struct vb2_queue *q, struct file *file, > * @ppos: file handle position tracking pointer > * @nonblock: mode selector (1 means blocking calls, 0 means nonblocking) > */ > -size_t vb2_read(struct vb2_queue *q, char __user *data, size_t count, > +ssize_t vb2_read(struct vb2_queue *q, char __user *data, size_t count, > loff_t *ppos, int nonblock); > /** > * vb2_write() - implements write() syscall logic. > @@ -1103,7 +1103,7 @@ size_t vb2_read(struct vb2_queue *q, char __user *data, size_t count, > * @ppos: file handle position tracking pointer > * @nonblock: mode selector (1 means blocking calls, 0 means nonblocking) > */ > -size_t vb2_write(struct vb2_queue *q, const char __user *data, size_t count, > +ssize_t vb2_write(struct vb2_queue *q, const char __user *data, size_t count, > loff_t *ppos, int nonblock); > > /** Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland