From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+9fc046ab2b0cf295a063@syzkaller.appspotmail.com,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: Re: [PATCH 0/2] KVM: x86: Revert to fix apic_hw_disabled underflow
Date: Fri, 15 Oct 2021 11:02:35 +0200 [thread overview]
Message-ID: <7b2c41cb-31fd-3755-dd34-86e7926f2f49@redhat.com> (raw)
In-Reply-To: <20211013003554.47705-1-seanjc@google.com>
On 13/10/21 02:35, Sean Christopherson wrote:
> Revert (mostly) a patch from the vCPU RESET cleanup that open coded some
> APIC shenanigans to avoid stuffing vcpu->arch.apic_base at vCPU creation,
> and completely overlooked the side effects on apic_hw_disabled. I went
> for a revert as I think the original behavior is the least awful solution,
> just somewhat poorly documented.
>
> The second patch adds WARNs to detect "overflow", where "overflow" means
> KVM incorrectly increments apic_hw_disabled.
>
> Sean Christopherson (2):
> Revert "KVM: x86: Open code necessary bits of kvm_lapic_set_base() at
> vCPU RESET"
> KVM: x86: WARN if APIC HW/SW disable static keys are non-zero on
> unload
>
> arch/x86/kvm/lapic.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
Queued for 5.15, thanks.
Paolo
prev parent reply other threads:[~2021-10-15 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 0:35 Sean Christopherson
2021-10-13 0:35 ` [PATCH 1/2] Revert "KVM: x86: Open code necessary bits of kvm_lapic_set_base() at vCPU RESET" Sean Christopherson
2021-10-13 0:35 ` [PATCH 2/2] KVM: x86: WARN if APIC HW/SW disable static keys are non-zero on unload Sean Christopherson
2021-10-15 9:02 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b2c41cb-31fd-3755-dd34-86e7926f2f49@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=seanjc@google.com \
--cc=syzbot+9fc046ab2b0cf295a063@syzkaller.appspotmail.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®