mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shiji Yang <yangshiji66@outlook.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
	"Srinivas Kandagatla" <srini@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: nvmem: add env-size property for u-boot env layout
Date: Wed, 30 Jul 2025 15:20:12 +0200	[thread overview]
Message-ID: <7b2d0166-8bf8-4f48-ab20-ea1082515e9f@kernel.org> (raw)
In-Reply-To: <OSBPR01MB16702D6947772E526F64D63CBC24A@OSBPR01MB1670.jpnprd01.prod.outlook.com>

On 30/07/2025 15:17, Shiji Yang wrote:
> This newly introduced property allows users to declare the size of
> the environment storage area.

Bindings come before the user.

Your commit msg should explain WHY you are doing this, not what you did
here. I see from the diff everything what you said above. I don't see
the reason to limit the env size.

Best regards,
Krzysztof

  reply	other threads:[~2025-07-30 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 13:17 [PATCH 1/2] nvmem: u-boot-env: support specifying the env storage size Shiji Yang
2025-07-30 13:17 ` [PATCH 2/2] dt-bindings: nvmem: add env-size property for u-boot env layout Shiji Yang
2025-07-30 13:20   ` Krzysztof Kozlowski [this message]
2025-07-30 23:52   ` Rob Herring
2025-07-31  8:33     ` Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b2d0166-8bf8-4f48-ab20-ea1082515e9f@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®