From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39324D528 for ; Thu, 2 Jan 2025 21:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735852249; cv=none; b=vEnrvIHQexJ2+U7n4mR0xcmLEwfxW4MpA44pFMzqRl0UnErosjYYZPhKNk8gijx04ZVlCqnc+JH+cuKAy6OrrEg5jkF3u3oqlhCTYZkqG6fIEQDXwn76vXeGOBbSWZ7+lyQCf/jh2nyjIWA9LvxiO24fpPe+q60P8/wVHLV0jq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735852249; c=relaxed/simple; bh=Eq5W+nlVIBj2dLigCJUlkzCAbLsA03Jc6vtkqAg52Lg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aQgqPPQbnBtegNf2oEgDJFvdNBOjqnovKyrchICLEcu1QSkxh+xVlvzJWrwMysfj0kKEqQmXtcOHjM/1fM5I3uDjfYRROazpsTvtvUa8oNG6h0qFVwb6GfPysijwcfaezMTcQNQIEumvPCbdYc9Cb7yxqo643gZi6wJvSp8WD4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VX1AHgyP; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VX1AHgyP" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-844dfe4b136so382920439f.3 for ; Thu, 02 Jan 2025 13:10:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1735852246; x=1736457046; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=deBZWtBO2Rql5MGEECC7BVBsZ9SXSslOvwjRAQYiN8I=; b=VX1AHgyPTPOb8O2cjT/o/alnN8h8V3wFgabfU6oVrWvEnS89LYuM2K1V//dsIrI4vN 4zHWmveYkCAJdAou11+QUalFcyY2CzHd5V+eMN9xGZte3JNhf/JUD/3pPx9J29L32NjC UGQbvy5+jbrV0fsForD9bD+VNhqZAJt5iKPto= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735852246; x=1736457046; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=deBZWtBO2Rql5MGEECC7BVBsZ9SXSslOvwjRAQYiN8I=; b=HYKJb8Mk8lzwbieNU2yFy72plxBbU1oG8cTIH/ZvlJ/HfEOLTZ4PMjiBWymBG5bl+4 qBXzX+k6zefvbdMyOCXNt5203FizAv+PVFAzHr2k2jk0JNvDq70EOWPjqyI0GNZ8tXig EcOwKczwCFSIJvuCdp6ebi7odq0XWN900rI0kmaXZHRRtLIqCc8R7XcXdlZSIhRojs4O B73uDrygF+XVpKMqkA9JVJ+OJecoYWCcEd7cPPy8eZw0q1bIrsVeCKeq5WmEpiYBijKz 0OauAVdmYA2b0sqnabNFigUweqsOXdD6I5Slwwe670enIGF2lYjOtv1KGvsfVQtOeNIe E2ng== X-Forwarded-Encrypted: i=1; AJvYcCUoVJt5Cr8teqWx4XZxZToi/Crw4Smn1bHp4BIxv3wZZCc0nkfrjl0Gn2jc8P4btVETGXRdQTnxdk2z9OE=@vger.kernel.org X-Gm-Message-State: AOJu0YwbYeYio9wRd5zgfNhRIv95418PRHsdu30LpbdntoEhs6t0UHOp 1PROm9SYN+ntQbp7l4AN3hqdp9Azcxz1XVWKTpZ/exGM0RFvpsMvUUqCAWNgIzg= X-Gm-Gg: ASbGncvY8mcwdZOsL2jCRWDDTIECh/aYcrHLbXhe0dZ6ikh7JoRQbqtgkCmrTtaeMai t8tdl2fy6qXl2Ih12QNOfjSBGc1Bp+aZBozkJis53n1bjK44m4wkjQ6cletJNNdDbj69KN/AOqW 2gWyamjqKQVPJ4ulGxA6tCSBFLYwdpalxMI//m6N0Fs5d0Wl1/YjT1Z5NFdx+Es//9eqcAJZFwR gotICdZsVAiR1zv0wEc2A0JBsBwkPsqIbjkaOhRAKF4JwlEeF5BjH488okIKN33Dkm6 X-Google-Smtp-Source: AGHT+IFczBG3Zmz4pta4ydTwyFuZbPoCtqR/zmSfDX+fnZp2HVVoA8aMFQQGitPh8lFBDiQ/xnmKdQ== X-Received: by 2002:a05:6602:641c:b0:82d:9b0:ecb7 with SMTP id ca18e2360f4ac-8499e499299mr4092284739f.3.1735852246236; Thu, 02 Jan 2025 13:10:46 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e68bf50f75sm6987880173.5.2025.01.02.13.10.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 13:10:45 -0800 (PST) Message-ID: <7b2e2d2e-6ba8-490e-ad80-229982cdd6d8@linuxfoundation.org> Date: Thu, 2 Jan 2025 14:10:45 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] selftests: tmpfs: Add kselftest support to tmpfs To: Shivam Chaudhary , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20250102100459.1291426-1-cvam0000@gmail.com> <20250102100459.1291426-3-cvam0000@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20250102100459.1291426-3-cvam0000@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/2/25 03:04, Shivam Chaudhary wrote: > Replace direct error handling with 'ksft_test_result_*' > macros for better reporting. > > Test logs: > > Before change: > - Without root > error: unshare, errno 1 > > - With root > No, output > > After change: > - Without root > TAP version 13 > 1..1 > ok 2 # SKIP This test needs root to run! > Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 > > - With root > TAP version 13 > 1..1 > ok 1 Test : Success > Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > > Signed-off-by: Shivam Chaudhary > --- > .../selftests/tmpfs/bug-link-o-tmpfile.c | 28 +++++++++---------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c b/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c > index 657b64857e82..290f11a81d2b 100644 > --- a/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c > +++ b/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c > @@ -41,39 +41,39 @@ int main(void) > > if (unshare(CLONE_NEWNS) == -1) { > if (errno == ENOSYS || errno == EPERM) { > - fprintf(stderr, "error: unshare, errno %d\n", errno); > - return 4; > + ksft_exit_skip("unshare() error: unshare, errno %d\n", errno); > + } else { > + ksft_exit_fail_msg("unshare() error: unshare, errno %d\n", errno); > } > - fprintf(stderr, "error: unshare, errno %d\n", errno); > - return 1; > } > + > if (mount(NULL, "/", NULL, MS_PRIVATE|MS_REC, NULL) == -1) { > - fprintf(stderr, "error: mount '/', errno %d\n", errno); > - return 1; > + ksft_exit_fail_msg("mount() error: Root filesystem private mount: Fail %d\n", errno); > } > > /* Our heroes: 1 root inode, 1 O_TMPFILE inode, 1 permanent inode. */ > if (mount(NULL, "/tmp", "tmpfs", 0, "nr_inodes=3") == -1) { > - fprintf(stderr, "error: mount tmpfs, errno %d\n", errno); > - return 1; > + ksft_exit_fail_msg("mount() error: Mounting tmpfs on /tmp: Fail %d\n", errno); > } > > fd = openat(AT_FDCWD, "/tmp", O_WRONLY|O_TMPFILE, 0600); > if (fd == -1) { > - fprintf(stderr, "error: open 1, errno %d\n", errno); > - return 1; > + ksft_exit_fail_msg("openat() error: Open first temporary file: Fail %d\n", errno); > } > + > if (linkat(fd, "", AT_FDCWD, "/tmp/1", AT_EMPTY_PATH) == -1) { > - fprintf(stderr, "error: linkat, errno %d\n", errno); > - return 1; > + ksft_exit_fail_msg("linkat() error: Linking the temporary file: Fail %d\n", errno); > + /* Ensure fd is closed on failure */ > + close(fd); > } > close(fd); > > fd = openat(AT_FDCWD, "/tmp", O_WRONLY|O_TMPFILE, 0600); > if (fd == -1) { > - fprintf(stderr, "error: open 2, errno %d\n", errno); > - return 1; > + ksft_exit_fail_msg("openat() error: Opening the second temporary file: Fail %d\n", errno); > } > > + ksft_test_result_pass("Test : Success\n"); There is no need to print success here. > + ksft_exit_pass(); > return 0; > } thanks, -- Shuah