From: Deepak Mishra <linux.dkm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, joe@perches.com, wlanfae@realtek.com,
Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
linux.dkm@gmail.com, himadri18.07@gmail.com,
straube.linux@gmail.com
Subject: [PATCH v2 8/9] staging: rtl8712: fixed enable_rx_ff0_filter as bool and CamelCase
Date: Sun, 2 Jun 2019 15:55:37 +0530 [thread overview]
Message-ID: <7b32a7cf85ef0c3f6d2ba82480a1f8d0ad651779.1559470738.git.linux.dkm@gmail.com> (raw)
In-Reply-To: <cover.1559470737.git.linux.dkm@gmail.com>
This patch fixes CamelCase blnEnableRxFF0Filter by renaming it
to enable_rx_ff0_filter in drv_types.h and related files rtl871x_cmd.c
xmit_linux.c
It was reported by checkpatch.pl
This fix also makes enable_rx_ff0_filter a bool and uses true false than
previously used u8 as suggested by joe@perches.com
Signed-off-by: Deepak Mishra <linux.dkm@gmail.com>
---
drivers/staging/rtl8712/drv_types.h | 2 +-
drivers/staging/rtl8712/rtl871x_cmd.c | 2 +-
drivers/staging/rtl8712/xmit_linux.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
index ddab6514a549..e3e2b32e964e 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging/rtl8712/drv_types.h
@@ -164,7 +164,7 @@ struct _adapter {
struct iw_statistics iwstats;
int pid; /*process id from UI*/
struct work_struct wk_filter_rx_ff0;
- u8 blnEnableRxFF0Filter;
+ bool enable_rx_ff0_filter;
spinlock_t lockRxFF0Filter;
const struct firmware *fw;
struct usb_interface *pusb_intf;
diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
index 05a78ac24987..6a8d58d97873 100644
--- a/drivers/staging/rtl8712/rtl871x_cmd.c
+++ b/drivers/staging/rtl8712/rtl871x_cmd.c
@@ -238,7 +238,7 @@ u8 r8712_sitesurvey_cmd(struct _adapter *padapter,
mod_timer(&pmlmepriv->scan_to_timer,
jiffies + msecs_to_jiffies(SCANNING_TIMEOUT));
padapter->ledpriv.LedControlHandler(padapter, LED_CTL_SITE_SURVEY);
- padapter->blnEnableRxFF0Filter = 0;
+ padapter->enable_rx_ff0_filter = false;
return _SUCCESS;
}
diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
index e65a51c7f372..9fa1abcf5e50 100644
--- a/drivers/staging/rtl8712/xmit_linux.c
+++ b/drivers/staging/rtl8712/xmit_linux.c
@@ -103,11 +103,11 @@ void r8712_SetFilter(struct work_struct *work)
r8712_write8(padapter, 0x117, newvalue);
spin_lock_irqsave(&padapter->lockRxFF0Filter, irqL);
- padapter->blnEnableRxFF0Filter = 1;
+ padapter->enable_rx_ff0_filter = true;
spin_unlock_irqrestore(&padapter->lockRxFF0Filter, irqL);
do {
msleep(100);
- } while (padapter->blnEnableRxFF0Filter == 1);
+ } while (padapter->enable_rx_ff0_filter == true);
r8712_write8(padapter, 0x117, oldvalue);
}
--
2.19.1
next prev parent reply other threads:[~2019-06-02 10:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 10:25 [PATCH v2 0/9] staging: rtl8712: Fixed CamelCase in struct _adapter Deepak Mishra
2019-06-02 10:25 ` [PATCH v2 1/9] staging: rtl8712: Fixed CamelCase rename ImrContent to imr_content Deepak Mishra
2019-06-02 17:11 ` Greg KH
2019-06-02 10:25 ` [PATCH v2 2/9] staging: rtl8712: Fixed CamelCase EepromAddressSize rename to eeprom_address_size Deepak Mishra
2019-06-02 10:25 ` [PATCH v2 3/9] staging: rtl8712: Fixed CamelCase cmdThread rename to cmd_thread Deepak Mishra
2019-06-02 10:25 ` [PATCH v2 4/9] staging: rtl8712: Fixed CamelCase renames evtThread to evt_thread Deepak Mishra
2019-06-02 17:12 ` Greg KH
2019-06-02 10:25 ` [PATCH v2 5/9] staging: rtl8712: Fixed CamelCase renames IsrContent to isr_content Deepak Mishra
2019-06-02 17:13 ` Greg KH
2019-06-02 10:25 ` [PATCH v2 6/9] staging: rtl8712: Fixed CamelCase renames xmitThread and recvThread Deepak Mishra
2019-06-02 17:13 ` Greg KH
2019-06-02 10:25 ` [PATCH v2 7/9] staging: rtl8712: Fixed CamelCase wkFilterRxFF0 to wk_filter_rx_ff0 in Deepak Mishra
2019-06-02 10:25 ` Deepak Mishra [this message]
2019-06-02 17:14 ` [PATCH v2 8/9] staging: rtl8712: fixed enable_rx_ff0_filter as bool and CamelCase Greg KH
2019-06-04 4:19 ` Deepak Kumar Mishra
2019-06-02 10:25 ` [PATCH v2 9/9] staging: rtl8712: Fixed CamelCase lockRxFF0Filter Deepak Mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b32a7cf85ef0c3f6d2ba82480a1f8d0ad651779.1559470738.git.linux.dkm@gmail.com \
--to=linux.dkm@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himadri18.07@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
--cc=wlanfae@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®