mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "hjl.tools@gmail.com" <hjl.tools@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/shstk: Enable shadow stack for x32
Date: Fri, 22 Mar 2024 14:07:27 +0000	[thread overview]
Message-ID: <7b341bef9c0cab324350873cab75b7e1313a5172.camel@intel.com> (raw)
In-Reply-To: <CAMe9rOrgAtQvA=Tj0=T095JmdoRZ8pLuNOY3sT_RwwnznJN2Ow@mail.gmail.com>

On Fri, 2024-03-15 at 07:34 -0700, H.J. Lu wrote:
> > How many people do you think will use this?

I'm concerned that the only use of this will ever be exercise via the
glibc unit tests, but will still require work to support.

> > 
> > I would have thought it would require more changes for basic x32
> 
> This is all needed.
> 
> > operation. What was the testing exactly?
> 
> I configured x32 glibc with --enable-cet, build glibc and
> run all glibc tests with shadow stack enabled.  There are
> no regressions.  I verified that shadow stack is enabled
> via /proc/pid/status.

The shadow stack is supposed to be mapped above 4G, so how is this
supposed to work for x32?

  reply	other threads:[~2024-03-22 14:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15 14:04 H.J. Lu
2024-03-15 14:20 ` Edgecombe, Rick P
2024-03-15 14:34   ` H.J. Lu
2024-03-22 14:07     ` Edgecombe, Rick P [this message]
2024-03-22 14:28       ` Edgecombe, Rick P
2024-03-22 15:06       ` H.J. Lu
2024-03-22 15:58         ` Edgecombe, Rick P
2024-03-22 16:07           ` H.J. Lu
2024-03-22 16:21             ` Edgecombe, Rick P
2024-03-22 16:35               ` H.J. Lu
2024-03-22 10:59 ` [tip: x86/shstk] x86/shstk: Enable shadow stacks " tip-bot2 for H.J. Lu
2024-03-22 16:49   ` Borislav Petkov
2024-03-22 16:49 ` [PATCH] x86/shstk: Enable shadow stack " Dave Hansen
2024-03-22 16:52   ` H.J. Lu
2024-03-22 16:56     ` Dave Hansen
2024-03-22 17:00       ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b341bef9c0cab324350873cab75b7e1313a5172.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=hjl.tools@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®