From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A887935581F for ; Thu, 5 Feb 2026 07:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770276258; cv=none; b=ccldyu57hrCwZT4hpmytlz3adi+YP7lPpoBb5fTQjvWH35ZdNsDm9NvHVdqkG8OMQGGcN8Lt4Toiun5iJ6dU1FjzPkF7+MN6sZo08jXOCzbpgWixmmhWDav7UucI5H1OIGnDFBNdUAU+BgR6vrp4I4b2EVmiYKAYkc8MkWsj8b8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770276258; c=relaxed/simple; bh=4f8mTigMIqXkFwFt839fQ3ocfQnHUH8K1Gu4Z//aYps=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jUjay3/mse1lNLhc+CTVgmE2EtNWA/MphIcIKxHv8elBw5wl3eINaIjKeWqNsSmdmeFrHZqm/8aJp8SvYhU2cg1o3OyAApyh6hqN907t+pVKgNrjE/x2FxSvBnCOzw6Ohi3JVFZ1+d3+z7G3D8Jz1RM/mNzKFo8SBSK7dVQ8jFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IIRulT3M; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DSO7qzxV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IIRulT3M"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DSO7qzxV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770276256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4f8mTigMIqXkFwFt839fQ3ocfQnHUH8K1Gu4Z//aYps=; b=IIRulT3MfdtTefioi7PirGqRYadho9EVeMB8XIxnewvvp6Tkv/YcLQBRlbfnkn+MLr2P4R kQGbfj4HHyOWaQSH38I7l73CCLwSp/PEx7p3ZkPpyvEmCiiHM/5ZoHmAbgsAqRi2YeQ4QO DwX6mQz7KVTHqR5NKzcodF4Eku2M/ZQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-i9otTiwdMiWUaYv0nZr4cQ-1; Thu, 05 Feb 2026 02:24:15 -0500 X-MC-Unique: i9otTiwdMiWUaYv0nZr4cQ-1 X-Mimecast-MFC-AGG-ID: i9otTiwdMiWUaYv0nZr4cQ_1770276254 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-483129eb5ccso5652565e9.2 for ; Wed, 04 Feb 2026 23:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770276254; x=1770881054; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=4f8mTigMIqXkFwFt839fQ3ocfQnHUH8K1Gu4Z//aYps=; b=DSO7qzxV90MCaTFzsMN5Jpj0smQN6tyMaTE48TsnolaCYzrHNQ00bqtSbKEDK6D+Q3 Vons41ulscUdZqneu/NtdLe8u2SaDFKbOq52dR6WHHTRr7ztdka1VgQWUMfI1cTpjhFC G9+ggWWeeZmN1J+FxZxHOICld3k3bVwFCAGxOjmRTmHG4eyDXdt18UATSOn1wM99p7Fj T7tyjwVq85lLDSQ0rWlZSFWjEVUotGdfxZpTXIrc4nuBzWjDoyVK4TkdDxUowk4xJFZM ncF0BFixInA/3EtV/9faIZFNanae5mxTg3HB5ftYKNlwAJ2oJqHgbJ8rQf8T5SP2tWU1 C4zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770276254; x=1770881054; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4f8mTigMIqXkFwFt839fQ3ocfQnHUH8K1Gu4Z//aYps=; b=X4Mm1CTIa+xBj3Qup1SlsxEC8g41weGWNuaP7vi4ZtOb9axIYxfO9s/dLBXjVunfIR oJjSwWnS7yx3cU4Gvrnw2mD6Cwv4lUdH3NJex+rgJslvYEly+rbPHyL0OHNYXbu6TP7c LEwVciF5pPNcQDZtnSzHiioPTBzDrYk/vj04P8LOPff9vwqw4sFZBVUYSzSxyHa8ffNg rwPvv60iBd5/jWdudgm0KL7CgEWeVXTWvf7+h0L1OkDsNyC/4mrItZKCdt4Ue3J7Tk2A 0ycbNnXCSbd6pGsYjIDYkzBnG35aEAobbP82hUT40C8ov4aBlnlgoWOA7I59mHqRu+9O hmOA== X-Forwarded-Encrypted: i=1; AJvYcCU5ZIUzE4wRdera9ftxqBpXiAm9/5zw01paDInHtYQc3uCZz9xVCuFmBblDt4YeMj/f9UC5GbrpehA5VzA=@vger.kernel.org X-Gm-Message-State: AOJu0YzOWNpRXQUpJG7F5uGVr/9cOeAxvL4Cy/rBLuJ+OF97M6Qem4Rw oYEUmBvPY1J12JTBg0WBWmfKWwLpl9RxNemhGBUfiFU55AytrUlGw3L0wthxPEaS1eHg5OoQKz+ m7DqnftaataQWUR2vLU9QC5DLhkZz+kpe1syxF3eWKEtnezGWDrWreeyyzjZIsWX5Ig== X-Gm-Gg: AZuq6aItQrSBiLPPkqIhCG7usPUypxRbJjXpfy6TKnFBg9+wvQUb+Rph0WQdGr2bL+8 HdK7qZxKNUG5C3+QOcne/+P+7ynvyqGpqv84H/oKuEZqNd3pv/YxHt/mPZAKlkUIh7+Gavpjx7Y 3nSH0aNvte3DVvYZg2cbSwmJjAv29qCX9Am90h053BxncUAgwCnamMSvizyp4vhlM9lkcbylMDb jNXXnV4PtSYWe50g2+dUdLyGqEr9ANBAoEJ+vD6klVN1QyiGD0pDzQgpA1jy/SE/ohIykXgO5OB OWsiYld8R3FgK1xtiIIlp/j89jFmFB7JBr/E+EQXXP0q2iHoJni8iqkHgVpjbm4tB8Py/I5B3lM B+kq2aZxdSbsYqtM4kvNhP+GXN7z8m0irkOf2XOGotS1JJ71Nbl73DNyLoVwrxzdMiPnG93fo4I kV03W58c9S X-Received: by 2002:a05:600c:19cd:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-4830e950d34mr79235905e9.16.1770276253695; Wed, 04 Feb 2026 23:24:13 -0800 (PST) X-Received: by 2002:a05:600c:19cd:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-4830e950d34mr79235605e9.16.1770276253302; Wed, 04 Feb 2026 23:24:13 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830ffc9f3asm39046345e9.19.2026.02.04.23.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 23:24:13 -0800 (PST) Message-ID: <7b35a21f1b85e6510b3653ab520920e459160679.camel@redhat.com> Subject: Re: [PATCH v2 19/20] rv/rvgen: fix _fill_states() return type annotation From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , "open list:RUNTIME VERIFICATION (RV)" , open list Date: Thu, 05 Feb 2026 08:24:11 +0100 In-Reply-To: <20260204144914.104028-20-wander@redhat.com> References: <20260204144914.104028-1-wander@redhat.com> <20260204144914.104028-20-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-02-04 at 11:42 -0300, Wander Lairson Costa wrote: > The _fill_states() method returns a list of strings, but the type > annotation incorrectly specified str. Update the annotation to > list[str] to match the actual return value. >=20 > Signed-off-by: Wander Lairson Costa > --- Looks good, thanks. I would keep all annotation changes together (i.e. squa= sh with the next patch), but if you prefer this way, I'm fine too. Reviewed-by: Gabriele Monaco > =C2=A0tools/verification/rvgen/rvgen/ltl2k.py | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/ltl2k.py > b/tools/verification/rvgen/rvgen/ltl2k.py > index 2c564cc937235..de765b8486bd1 100644 > --- a/tools/verification/rvgen/rvgen/ltl2k.py > +++ b/tools/verification/rvgen/rvgen/ltl2k.py > @@ -71,7 +71,7 @@ class ltl2k(generator.Monitor): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if not self.name: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = self.name =3D Path(file_path).stem > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def _fill_states(self) -> str: > +=C2=A0=C2=A0=C2=A0 def _fill_states(self) -> list[str]: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 buf =3D [ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = "enum ltl_buchi_state {", > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ]