From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Jiakai Xu <xujiakai24@mails.ucas.ac.cn>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/mmcid: Bound the CID allocation busy wait
Date: Fri, 13 Nov 2026 09:52:40 -0500 [thread overview]
Message-ID: <7b3aa2f3-aeae-45f9-a8a8-8d8b56fed90d@efficios.com> (raw)
In-Reply-To: <87eccossye.ffs@fw13>
On 2026-11-13 09:32, Thomas Gleixner wrote:
> On Wed, Nov 11 2026 at 20:48, Mathieu Desnoyers wrote:
>> On Tue, Oct 20 2026 at 15:54, Thomas Gleixner wrote:
>> I have a reproducer for a lockup that starts from the stale state you
>> describe. It needs two more things: the execve() fails, and the task is
>> moved to another CPU during that execve().
>
> That has been reported already privately to me and a few others and the
> reporter provided a similar patch as you.
>
> While both variants seem simpler, I prefer the explicit
> re-initialization for the failed exec() case.
>
> It's a NOOP for newly initialized MMs and avoids the pointless fixup
> dance for the last user in the common case.
I integrated your approach, tested it and wrote a commit message for
it. My reproducer passes with it, and so do my other mm_cid tests, on
guests with 2 to 64 CPUs.
Do you want to take care of it yourself, or should I route it through
an mm_cid fixes series I am preparing? If you want me to pick it up, I
need your Signed-off-by.
The series has four other fixes of mine, selftests for them, and
Weiming Shi's teardown fix.
One of those four was found by a Spin model of the per task / per CPU
state machine. I then confirmed it on a real kernel, with delays
inserted by hand in the window. The model is not part of the series. I
can send it if you want to look at it.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
prev parent reply other threads:[~2026-11-13 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 1:34 Jiakai Xu
2026-09-18 10:43 ` Peter Zijlstra
2026-10-15 20:37 ` Thomas Gleixner
2026-10-20 13:54 ` Thomas Gleixner
2026-10-21 1:30 ` Jiakai Xu
2026-11-12 1:48 ` Mathieu Desnoyers
2026-11-13 14:32 ` Thomas Gleixner
2026-11-13 14:52 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3aa2f3-aeae-45f9-a8a8-8d8b56fed90d@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=xujiakai24@mails.ucas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®