From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28C9C433ED for ; Thu, 22 Apr 2021 16:50:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC482613C3 for ; Thu, 22 Apr 2021 16:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238089AbhDVQuj (ORCPT ); Thu, 22 Apr 2021 12:50:39 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:31784 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236668AbhDVQug (ORCPT ); Thu, 22 Apr 2021 12:50:36 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FR3Lb3c3JzB09Zx; Thu, 22 Apr 2021 18:49:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id lcywnQgTiB-L; Thu, 22 Apr 2021 18:49:59 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FR3Lb1b2pzB09Zr; Thu, 22 Apr 2021 18:49:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8448C8B849; Thu, 22 Apr 2021 18:50:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id CI9IXV71NSlk; Thu, 22 Apr 2021 18:50:00 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DE1988B846; Thu, 22 Apr 2021 18:49:59 +0200 (CEST) Subject: Re: [PATCH 2/2] powerpc: Print esr register when hitting Program Interrupt From: Christophe Leroy To: Xiongwei Song , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, npiggin@gmail.com, ravi.bangoria@linux.ibm.com, mikey@neuling.org, aneesh.kumar@linux.ibm.com, 0x7f454c46@gmail.com Cc: Xiongwei Song , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20210422151022.17868-1-sxwjean@me.com> <20210422151022.17868-2-sxwjean@me.com> Message-ID: <7b3ad970-707d-ffcd-e4a3-0b6e622db403@csgroup.eu> Date: Thu, 22 Apr 2021 18:49:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 22/04/2021 à 17:29, Christophe Leroy a écrit : > > > Le 22/04/2021 à 17:10, Xiongwei Song a écrit : >> From: Xiongwei Song >> >> The esr register has the details of Program Interrupt on BookE/4xx cpus, >> printing its value is helpful. >> >> Signed-off-by: Xiongwei Song >> --- >>   arch/powerpc/kernel/process.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c >> index 5c3830837f3a..664aecf8ee2e 100644 >> --- a/arch/powerpc/kernel/process.c >> +++ b/arch/powerpc/kernel/process.c >> @@ -1459,6 +1459,7 @@ static bool interrupt_detail_printable(int trap) >>       case INTERRUPT_MACHINE_CHECK: >>       case INTERRUPT_DATA_STORAGE: >>       case INTERRUPT_ALIGNMENT: >> +    case INTERRUPT_PROGRAM: > > With this, it will also print the DSISR on 8xx/6xx so it will print garbage. > > 8xx/6xx provide the information in SRR1. If you want to proceed, you have to do the same as in ISI: > Copy the content of SRR1 into regs->dsisr in the assembly handler in head_book3s_32.S and in the > instruction TLB error handler in head_8xx.S In fact, we already have get_reason() called by do_program_check() to retrieve the reason of the program check exception. Maybe it could be used to print usefull information instead of starting doing almost the same is another way. Or we do as I suggested above, and we remove that get_reason() stuff. But get_reason() is also used by the alignment exception. So that doesn't look easy. I don't know what the best approach is. > >>           return true; >>       default: >>           return false; >>