From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7609B28AB0B for ; Fri, 17 Apr 2026 04:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776400573; cv=none; b=N0YGBzbt5IjKi6oVwM0d7LQiIEymmJ/JvwIsNryyvz9czeWpthBejA1+TrReXzbGkKi+BWa2FgpR35qZU8yoG4PrLNyfnxRf1Rk3IoJDXgCSANdhpB0Vef37+emhAV7Z1Y13RFWD6+o8ey1H8lS73T6+v6bdbfq03l27diSgOZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776400573; c=relaxed/simple; bh=90o4aEhp/60OFkjYC46uO16dPK47O4Jrb2V8TuLKjQc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PQKYENXkXKqg39Q9ob/yAxcKpeH24VnfdWxDeQasLrgHqqqILFtUai1XyBLy+xLn0wG/IYdV4rsYjgFGHjIWwlXqAUd/Hu1K1M8SMJ76E+nb74OJv8gmHrFn9z5w2vdC8+peAf1w8TewONzvv5F51nZfrGtt/PZfuvnU/QRBFmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epBNGKvZ; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epBNGKvZ" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-8a016799d2cso2852726d6.1 for ; Thu, 16 Apr 2026 21:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776400571; x=1777005371; darn=vger.kernel.org; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=wJCWVp8OC7bbbAgdbMwdNkUeylvTtEVIhbLpUvTx1Rk=; b=epBNGKvZlMSwXKheOjFCsVvEhjMzJ04w83cKU8q9LIZyOkdnTizHCjY4Ucyc6S7/fR wuvHc8M92pmok46PsO9GgCkuFAdYpJpGEqngZq2ycRHKsgdEJEr13UEIWbjX1WCfHCQ4 VaDaD7Fm7DlJ/yKTQxdBJ/EufV6m9ROTy9ZFBkOrGfc4MJKPWqyjTuCSTNq04Kef3s/I I/IOsEFR8JJjYVygGyPKNxvWRULlUu96CD4eTLM8fpnGaVajEADic73VCBkoZJ1H82WB R9PFxR/KeA1Il20Ge+OPrOHrDU7mlHTPNsMt+MCeaZQ6Livtk60buxj457fR1ReYf9JW b44w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776400571; x=1777005371; h=in-reply-to:autocrypt:from:content-language:references:cc:to :subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wJCWVp8OC7bbbAgdbMwdNkUeylvTtEVIhbLpUvTx1Rk=; b=Qy0OGEGl+DJKN8pz04DDKp2nQJqLk+NqEAlAZPSRZDvW04B3lgY1z9zbzolIgyoWCc 5M0+jxPLH2/MTGWGJYOzt92dCqMAfe8g16tflxm8vl7SEvZBLEzxywxfWClvAoDrEsKn cH2xXZAxkGzxJjdXDhss30mKBCvhxMaABnTBg7fi8rD08SZrTIUJMCEjevI7PFh/er2S 1+lyw4WzfyrOdS26v4x1vndgbOgurDIc+ZBthO69XQ74NA6yN1QTw6AK8/dGe5cMQ+rN Va6n4Gm5NLBz+wGLxQ6vLy4bkvvfeoTCe4s7SXh20uUlF/OaEkYQy0ZdV8ARJjQW7RPj 0YbQ== X-Forwarded-Encrypted: i=1; AFNElJ/t64w9kkmJO8fX8uWDi3TWDcxb4G8nrSIBnITS0reJY5/deRCcTgI+bH8xSwAArHYt0xJBRMHqcXIqEBg=@vger.kernel.org X-Gm-Message-State: AOJu0YzPluHh1D75QCa7fY0Z7PiAgrkwLmYTBqYUSfxUvODCUaIpA/cH 7gLFMz8zGMEahuFRxIzveT1cRgwoqFytle5AMA2eqgFcbsPTPULoS7OzH6nt+pj9hZCtPg== X-Gm-Gg: AeBDiesUMMCo04BQcTkvsK1CHCs3OOh2AFbz9g7dZs4Ga1I6D8L+f0m1rKIa3Y8tJkE VG2xrwCrPfS2d7K16zs079l0V5OJidrrA+WhD7OpmvI84bbNnPhm935cNUJ0+VgWENmzOry+hO8 Dh+e3lidX0CHF1lnHeqDjMvwzwzdOGSApRqIaFH5mmi494j6I2NlIpviWpHeWxM9Qcp/g2EDLyh Q1R5+Qjrti5yNkxX7U3OY0j7dk+Xz3Dox8OyhbkQqvXS5jvlAkv4cFvu+L8qj6Y1QXwlKkaFB5u 3ciGqCwJDgQ0JA46golSJeJ8vBNUIMVBP7pzvPl1sGaNDlUJfAtVv5VdFm7Q8e4d/yqD18yFUi5 ofvS6w1ETczETYgrlgIx/by+dyEBf0Sn0oVBsXe/psYoz6QBwEuraueaftQZ2OGVHpCkI6pSD6Q Xj8XN46GnDbvre7s9fQQY1kxJSSNz5vyY1HfYz7zTWUEG3WTw9 X-Received: by 2002:a05:6214:4a08:b0:89c:ac72:2f6e with SMTP id 6a1803df08f44-8b02813f8e0mr21757356d6.43.1776400571385; Thu, 16 Apr 2026 21:36:11 -0700 (PDT) Received: from [192.168.2.25] ([184.146.175.99]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ac72915sm2745626d6.15.2026.04.16.21.36.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 21:36:10 -0700 (PDT) Message-ID: <7b4509b0-9c35-40ca-9388-881236c82a32@gmail.com> Date: Fri, 17 Apr 2026 00:35:58 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:136.0) Gecko/20100101 Thunderbird/136.0 Subject: Re: [PATCH v2 1/2] drm/sched: Make drm_sched_entity_kill() a public function To: Philipp Stanner , Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , =?UTF-8?Q?Christian_K=C3=B6nig?= , Dave Airlie , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260415144956.272506-2-phasta@kernel.org> Content-Language: en-CA, en-US From: Luben Tuikov Autocrypt: addr=ltuikov89@gmail.com; keydata= xjMEZTohOhYJKwYBBAHaRw8BAQdAWSq76k+GsENjDTMVCy9Vr4fAO9Rb57/bPT1APnbnnRHN Ikx1YmVuIFR1aWtvdiA8bHR1aWtvdjg5QGdtYWlsLmNvbT7CmQQTFgoAQRYhBJkj7+VmFO9b eaAl10wVR5QxozSvBQJlOiE6AhsDBQkJZgGABQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheA AAoJEEwVR5QxozSvSm4BAOwCpX53DTQhE20FBGlTMqKCOQyJqlMcIQ9SO1qPWX1iAQCv3vfy JwktF7REl1yt7IU2Sye1qmQMfJxdt9JMbMNNBs44BGU6IToSCisGAQQBl1UBBQEBB0BT9wSP cCE8uGe7FWo8C+nTSyWPXKTx9F0gpEnlqReRBwMBCAfCfgQYFgoAJhYhBJkj7+VmFO9beaAl 10wVR5QxozSvBQJlOiE6AhsMBQkJZgGAAAoJEEwVR5QxozSvSsYA/2LIFjbxQ2ikbU5S0pKo aMDzO9eGz69uNhNWJcvIKJK6AQC9228Mqc1JeZMIyjYWr2HKYHi8S2q2/zHrSZwAWYYwDA== In-Reply-To: <20260415144956.272506-2-phasta@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------tyfpZ8tXo0NFX30pwA0Og5IZ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------tyfpZ8tXo0NFX30pwA0Og5IZ Content-Type: multipart/mixed; boundary="------------gaPimzysG4nviCSPOZwz55y1"; protected-headers="v1" From: Luben Tuikov To: Philipp Stanner , Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , =?UTF-8?Q?Christian_K=C3=B6nig?= , Dave Airlie , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <7b4509b0-9c35-40ca-9388-881236c82a32@gmail.com> Subject: Re: [PATCH v2 1/2] drm/sched: Make drm_sched_entity_kill() a public function References: <20260415144956.272506-2-phasta@kernel.org> In-Reply-To: <20260415144956.272506-2-phasta@kernel.org> --------------gaPimzysG4nviCSPOZwz55y1 Content-Type: multipart/mixed; boundary="------------5h2gFf0j1Vd2PHE5Iw2i7zdd" --------------5h2gFf0j1Vd2PHE5Iw2i7zdd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2026-04-15 10:49, Philipp Stanner wrote: > Some drivers do not care on teardown whether the last jobs pending in a= n > entity are actually executed before teardown completed. For such > scenarios, drm_sched_entity_flush() is not the ideal function since it'= s > intended to wait for jobs to complete. >=20 > Make drm_sched_entity_kill() public for that use-case and update the > documentation. This is a good patch and great suggestion by Danilo. >=20 > Suggested-by: Danilo Krummrich > Signed-off-by: Philipp Stanner > --- > Changes in v2: > - Improve wording, fix typo. > --- > drivers/gpu/drm/scheduler/sched_entity.c | 13 +++++++++++-- > include/drm/gpu_scheduler.h | 1 + > 2 files changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm= /scheduler/sched_entity.c > index 61a4818cc87b..7be5811b90cd 100644 > --- a/drivers/gpu/drm/scheduler/sched_entity.c > +++ b/drivers/gpu/drm/scheduler/sched_entity.c > @@ -267,8 +267,16 @@ static void drm_sched_entity_kill_jobs_cb(struct d= ma_fence *f, > schedule_work(&job->work); > } > =20 > -/* Remove the entity from the scheduler and kill all pending jobs */ > -static void drm_sched_entity_kill(struct drm_sched_entity *entity) > +/** > + * drm_sched_entity_kill - kill an entity's pending jobs and remove it= > + * @entity: the entity to remove > + * > + * Removes the entity from the scheduler's run queue and kills all pen= ding jobs. > + * > + * This function should be used over drm_sched_entity_flush() if it is= not > + * desired to actually wait for all pending jobs to finish. > + */ I felt that the email body above describing this patch was somewhat clear= er. Perhaps something like: (Notice the change "if" --> "when".) "Use this function over drm_sched_entity_flush(), when the caller is not = interested to wait for pending jobs to complete. This function kills any pending jobs." --=20 Regards, Luben --------------5h2gFf0j1Vd2PHE5Iw2i7zdd Content-Type: application/pgp-keys; name="OpenPGP_0x4C15479431A334AF.asc" Content-Disposition: attachment; filename="OpenPGP_0x4C15479431A334AF.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEZTohOhYJKwYBBAHaRw8BAQdAWSq76k+GsENjDTMVCy9Vr4fAO9Rb57/bPT1A PnbnnRHNIkx1YmVuIFR1aWtvdiA8bHR1aWtvdjg5QGdtYWlsLmNvbT7CmQQTFgoA QRYhBJkj7+VmFO9beaAl10wVR5QxozSvBQJlOiE6AhsDBQkJZgGABQsJCAcCAiIC BhUKCQgLAgQWAgMBAh4HAheAAAoJEEwVR5QxozSvSm4BAOwCpX53DTQhE20FBGlT MqKCOQyJqlMcIQ9SO1qPWX1iAQCv3vfyJwktF7REl1yt7IU2Sye1qmQMfJxdt9JM bMNNBs44BGU6IToSCisGAQQBl1UBBQEBB0BT9wSPcCE8uGe7FWo8C+nTSyWPXKTx 9F0gpEnlqReRBwMBCAfCfgQYFgoAJhYhBJkj7+VmFO9beaAl10wVR5QxozSvBQJl OiE6AhsMBQkJZgGAAAoJEEwVR5QxozSvSsYA/2LIFjbxQ2ikbU5S0pKoaMDzO9eG z69uNhNWJcvIKJK6AQC9228Mqc1JeZMIyjYWr2HKYHi8S2q2/zHrSZwAWYYwDA=3D=3D =3DqCaZ -----END PGP PUBLIC KEY BLOCK----- --------------5h2gFf0j1Vd2PHE5Iw2i7zdd-- --------------gaPimzysG4nviCSPOZwz55y1-- --------------tyfpZ8tXo0NFX30pwA0Og5IZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQSZI+/lZhTvW3mgJddMFUeUMaM0rwUCaeG4rgUDAAAAAAAKCRBMFUeUMaM0r6j4 AQDr7lP/kQhrH/SqboZz98qXO5P5Ea7iUmqRubR6r9+G/gEAqaquNDOvBw2OUFmYIobPxbdWZ2if glf+8pI8YLWZ9g0= =vuh+ -----END PGP SIGNATURE----- --------------tyfpZ8tXo0NFX30pwA0Og5IZ--