mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
	linux-kselftest@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, sumit.semwal@linaro.org,
	naresh.kamboju@linaro.org, Shuah Khan <shuahkh@osg.samsung.com>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function
Date: Wed, 1 Nov 2017 15:15:40 -0600	[thread overview]
Message-ID: <7b45330e-1817-87d6-4469-c530e19b784d@kernel.org> (raw)
In-Reply-To: <150908463014.28027.15385023102033596689.stgit@devbox>

On 10/27/2017 12:10 AM, Masami Hiramatsu wrote:
> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
> 
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
>  .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>  
>  FILTER=set_ftrace_filter
>  FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>  
>  ALL_FUNCS="#### all functions enabled ####"
>  
> 
> 
> 

Looks good to me. I will queue this for 4.15-rc1

thanks,
-- Shuah

      parent reply	other threads:[~2017-11-01 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  6:10 Masami Hiramatsu
2017-10-31 19:37 ` Steven Rostedt
2017-10-31 19:51   ` Shuah Khan
2017-11-01 21:15 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b45330e-1817-87d6-4469-c530e19b784d@kernel.org \
    --to=shuah@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=rostedt@goodmis.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®