From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from l2mail1.panix.com (l2mail1.panix.com [166.84.1.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B221721CC6D; Wed, 26 Feb 2025 15:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.84.1.75 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740584993; cv=none; b=CM2IZxBS5VddB+uziutYGVC9hEpohKYrzdhp1cwO5yKA9VC6a2SB2StmqRgDYeBdM54vJZCTfvntfoBzR5dXZajjxiSdOKbnR25sWLy9l7uPKeWefLPvD/O0gNKmtIFrlV/wZQCTa3xMtl75KFid1ShFgWWf35omAfMyn3yHkfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740584993; c=relaxed/simple; bh=Vj5uE4ESzohsxDwURRoN/xqYlLO93wlxFGqvOeU2v0Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YfjR3AllY26UMVzIVCgbwGbLgQiXJpxjvD7J8SezWhnbku6vNfhz/eaxgO80mmXdwr+/oblG/WrFkle+wrKYWvkDp8FxQNSbhTZBojDYfMsQ0O6xhcuiekK1Jny4O6dKy43p3IL6uCuCgLGB+lRRaHfu95GzqqIxSKx939y+RK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=panix.com; spf=pass smtp.mailfrom=panix.com; dkim=pass (1024-bit key) header.d=panix.com header.i=@panix.com header.b=BXgM6QBV; arc=none smtp.client-ip=166.84.1.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=panix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=panix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=panix.com header.i=@panix.com header.b="BXgM6QBV" Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (1024 bits) server-digest SHA256) (No client certificate requested) by l2mail1.panix.com (Postfix) with ESMTPS id 4Z2z3S3y1QzDSH; Wed, 26 Feb 2025 10:31:48 -0500 (EST) Received: from [172.16.225.207] (unknown [47.154.181.182]) by mailbackend.panix.com (Postfix) with ESMTPSA id 4Z2z3H0zQqz56g5; Wed, 26 Feb 2025 10:31:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix; t=1740583900; bh=Vj5uE4ESzohsxDwURRoN/xqYlLO93wlxFGqvOeU2v0Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=BXgM6QBVMxwP3HtMLYG4ARsarO/GAmA/r+WnIFR2oNA23NwVHsnuLEh0L+6KLiHzR zvPLpInkIjwPGTmJI4/IzrWXf4g53/MAVosroZNl6NJj6Ktt0L8HDYhAfCTyifKOC6 BeQOfik9xOSbLC6e4zLTnMNqzX/kh4I44VOrwn4k= Message-ID: <7b472880-32d0-4783-b9d2-3d4230403975@panix.com> Date: Wed, 26 Feb 2025 07:31:37 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: diagnosing resume failures after disconnected USB4 drives (Was: Re: PCI/ASPM: Fix L1SS saving (linus/master commit 7507eb3e7bfac)) To: Mika Westerberg Cc: Bjorn Helgaas , ilpo.jarvinen@linux.intel.com, Bjorn Helgaas , Jian-Hong Pan , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?TmlrbMSBdnMgS2/EvGVzxYZpa292cw==?= , Andreas Noever , Michael Jamet , Lukas Wunner , Yehezkel Bernat , linux-usb@vger.kernel.org, Kenneth Crudup References: <20250210210502.GA15655@bhelgaas> <21b72adf-aac6-49fa-af40-6db596c87432@panix.com> <20250211055722.GW3713119@black.fi.intel.com> <83d9302a-f743-43e4-9de2-2dd66d91ab5b@panix.com> <20250213135911.GG3713119@black.fi.intel.com> <20250214162948.GJ3713119@black.fi.intel.com> <661459dd-67d0-4e1c-bb28-9adf1417f660@panix.com> <20250226084404.GM3713119@black.fi.intel.com> Content-Language: en-US From: Kenneth Crudup In-Reply-To: <20250226084404.GM3713119@black.fi.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Trying to do a "control" test before I try out your bisected commit, and Lukas' changes, but of course now I can't get it to fail (I'm on Linus' master as of this morning (b5799106b4). I'm using my portable USB4 dock (Plugable TBT4-HUB3C) this time (vs. my CalDigit 4 dock) but the same ASMedia USB4-to-NVMe adapter as always; in any case everything is PCIe so it shouldn't matter. I don't normally use "tbauth" (I think that's all done for me via the "boltctl" suite) but I grabbed and built the GIT and ran it anyway, for good measure. I'll keep you updated, I'll be at my CalDigit dock soon enough if I can't get any failures this morning. -K On 2/26/25 00:44, Mika Westerberg wrote: > Hi Kenneth, > > On Fri, Feb 14, 2025 at 09:39:33AM -0800, Kenneth Crudup wrote: >> >> This is excellent news that you were able to reproduce it- I'd figured this >> regression would have been caught already (as I do remember this working >> before) and was worried it may have been specific to a particular piece of >> hardware (or software setup) on my system. >> >> I'll see what I can dig up on my end, but as I'm not expert in these >> subsystems I may not be able to diagnose anything until your return. > > [Back now] > > My git bisect ended up to this commit: > > 9d573d19547b ("PCI: pciehp: Detect device replacement during system sleep") > > Adding Lukas who is the expert. > > My steps to reproduce on Intel Meteor Lake based reference system are: > > 1. Boot the system up, nothing connected. > 2. Once up, connect Thunderbolt 4 dock and Thunderbolt 3 NVMe in a chain: > > [Meteor Lake host] <--> [TB 4 dock] <--> [TB 3 NVMe] > > 3. Authorize PCIe tunnels (whatever your distro provides, my buildroot just > has the debugging tools so running 'tbauth -r 301') > > 4. Check that the PCIe topology matches the expected (lspci) > > 5. Enter s2idle: > > # rtcwake -s 30 -mmem > > 6. Once it is suspended, unplug the cable between the host and the dock. > > 7. Wait for the resume to happen. > > Expectation: The system wakes up fine, notices that the TB and PCIe devices > are gone, stays responsive and usable. > > Actual result: Resume never completes. > > I added "no_console_suspend" to the command line and the did sysrq-w to > get list of blocked tasks. I've attached it just in case it is needed. > > If I revert the above commit the issue is gone. Now I'm not sure if this is > exactly the same issue that you are seeing but nevertheless this is kind of > normal use case so definitely something we should get fixed. > > Lukas, if you need any more information let me know. I can reproduce this > easily. > >> I also saw some DRM/connected fixes posted to Linus' master so maybe one of >> them corrects this new display-crash issue (I'm not home on my big monitor >> to be able to test yet). >> >> -Kenny >> >> On 2/14/25 08:29, Mika Westerberg wrote: >>> Hi, >>> >>> On Thu, Feb 13, 2025 at 11:19:35AM -0800, Kenneth Crudup wrote: >>>> >>>> On 2/13/25 05:59, Mika Westerberg wrote: >>>> >>>>> Hi, >>>> >>>> As Murphy's would have it, now my crashes are display-driver related (this >>>> is Xe, but I've also seen it with i915). >>>> >>>> Attached here just for the heck of it, but I'll be better testing the NVMe >>>> enclosure-related failures this weekend. Stay tuned! >>> >>> Okay, I checked quickly and no TB related crash there but I was actually >>> able to reproduce hang when I unplug the device chain during suspend. I did >>> not yet have time to look into it deeper. I'm sure this has been working >>> fine in the past as we tested all kinds of topologies including similar to >>> this. >>> >>> I will be out next week for vacation but will continue after that if the >>> problem is not alraedy solved ;-) >>> >> >> -- >> Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County >> CA -- Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA