From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5475C282F01 for ; Sat, 4 Jul 2026 19:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783194466; cv=none; b=iX7MnWjnhXeS5ipEMESxVarorrRj6sNRSV2SjpCzgglPmi8PZCgMMNinztMOhQOkRde++5LJxJOFoLyXXzipZ4awmHAzGtzEwJuRW/JoowWuEvGvizo19ra72RRN+R8+dMoFYEjKvvZBxC1peOrVyrwyGfXJ4YI/4JlU3fW09xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783194466; c=relaxed/simple; bh=Snl8VegfNU3b+pp7xcK18+nJNfh+AsT7lENoZyT5PN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kp6BvB8y9g2UWeNXXskNfoxp3xzl4gBd9I46ywJXuuZ/xKy7UjVt+fJd2+TH8NSMOI+uYCEgde+NNNxWTVDgfZzICX3oWmdwqlAnoM6V36u10lYI99X1H7Quk9O5hLaRENY1bTMliV3chj7/PQffRkazScfR9bEoMfqIMrdUYuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J27VjZC9; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J27VjZC9" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4720f3bf164so1347649f8f.1 for ; Sat, 04 Jul 2026 12:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783194464; x=1783799264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3VAekp+c4ejiOh3PjpFobvfEAsfcvbc3HnHbTxtxZXg=; b=J27VjZC9+/1poANI8rslb+RtbKxlTAh6wefvMARNOLfM7Y+mKj+SfAPJ4nL7zFNGO3 x1m7WTqrk3j9LG4uC7OJ02qrUl5PELQQVS05UusQLOKfKIzM5VRV9K24UNaXTM8qg7WC 6iv50Vrds/U92gFjTHWfUwbMb0mPuSf/5uOEwTzoXpRQEMb0pqqwlip+0z7xgaSZCHPL pPKrORp+veSJgBKQtig6Ww/ooHaMk7pwzBAPsyD4vFlLd0JaDYBLP5BDB8lJdMPmGbq3 BM3Thj6v0Y1DQwTvgTAV8VCShvJeGcVof8+6Go1Vrpj+WAypf8aj8PLhrC27W8tiqzR1 2bWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783194464; x=1783799264; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3VAekp+c4ejiOh3PjpFobvfEAsfcvbc3HnHbTxtxZXg=; b=RY4VRwt7vyfql+sFevplhLMEkXMFJDaWKMRcXiycIv7N1XRlKJDZQerlmwucq7q+oi u/lJPzYowB1iQU8aagH3YrRD1OhgtwsFAaNpANeZu5wCevK6WArRnK74UKTBS2+0IUC6 XW1hVPsd2lMxnDq/zUSG+vvG9f4ZiIa9fMWRRuh3Cb6M1NOsfEvdQ5S8EY9yOV3vfRYR IlnniqjXr4bKPT/FHgxRsz5BmPDH/vv2o+EwIxyONFVbxD9ck2UAsO/yc5ekN6vR9Ipl U6WzwERyEuXwVGl+l6SQXk1rgWdAmZEOb6sgGXfV3BhsIlGaVacA4jfNsowlcENUX5z3 2vHg== X-Forwarded-Encrypted: i=1; AFNElJ/HzF7bGCFHDh/9QYAV/meSDTV5f4XDTSrV3CImK4i2UYrJ5Qe7RYDQH0Y6uI1r5lozCFwkxfFRQwOMA3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzY1rila69WNuNMYKJdIS49DVxt0QP2efxM6UKxTJo4Dcrfnlvy 11hDcpQyUDFJq2lpFt7Fx9+gQEYiNKCLKNMH/D/cRGTFwdxqKO9fE4wv X-Gm-Gg: AfdE7cm/p3d6xmdRj5w68YRtYwRMGiSfzCqTj901P8ImXmJQpoSicsttfVrI8dz1kCF 1cLiGMJrR7Ybz270g23DRp6p7Aj6G6bmkedrExrOf2WSqWOkSIwCvTLLMBk839CWSyHDJ2MPuav 2sQUQbmmP5I77vPaSnh2a5RxP+jr2tHg96AgfPySwKEL0/TrxY7apkoUvnZJZlz+C4M/+3TMAn9 aCNhV4ALIKt47JovC/xWm72zVIXS4pcm9lge24JKtJ36gXm75c0U8hU6UKtUfKDkD02Y+C1beeZ CpsW536nlMhVaGA2BAz33yPUzgrgcSYXJUGW2GLVZ+v1iYU07jZYEKfoxWnIFKopNWXFISAwcHd pOGe+JLTinb1OJQip1CaQnn21lKKjwrmxUCldN6/M858BmrIVXutUcOT8FH9MdW0W5isHAdfFdD FUev6fQKVgJzD0GsLdT8y7rwhiLA2bt2zkkbSXUy4OMEGstifzN7NCZLchEjZhJwGG+UtCJmDxa 91smxClcPU= X-Received: by 2002:a05:600c:1d0d:b0:490:5000:917 with SMTP id 5b1f17b1804b1-493d127f020mr38066405e9.1.1783194463567; Sat, 04 Jul 2026 12:47:43 -0700 (PDT) Received: from shift (p200300d5ff229f0050f496fffe46beef.dip0.t-ipconnect.de. [2003:d5:ff22:9f00:50f4:96ff:fe46:beef]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c637568dsm253713735e9.4.2026.07.04.12.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 12:47:43 -0700 (PDT) Received: from localhost ([127.0.0.1]) by shift with esmtp (Exim 4.99.4) (envelope-from ) id 1wg6Ky-00000000Jmx-2UA6; Sat, 04 Jul 2026 21:47:40 +0200 Message-ID: <7b4d5221-ed48-489a-9b24-f29758f25e4e@gmail.com> Date: Sat, 4 Jul 2026 21:47:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] wifi: carl9170: firmware trust boundary hardening To: Jeff Johnson , Tristan Madani , Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani References: <20260421134929.325662-1-tristmd@gmail.com> Content-Language: de-DE, en-US From: Christian Lamparter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/1/26 7:47 PM, Jeff Johnson wrote: > On 4/21/2026 6:49 AM, Tristan Madani wrote: >> From: Tristan Madani >> >> This series adds missing bounds checks for firmware-controlled fields >> in the carl9170 USB driver. >> >> Patch 1 bounds the cmd callback memcpy to prevent heap overflow from >> an oversized firmware response. Patch 2 fixes an off-by-two in the TX >> status handler. Patch 3 caps the failover copy to rx_failover_missing >> bytes, using min_t per Christian Lamparter. >> >> Changes in v3: >> - Regenerated from wireless-next with proper git format-patch. >> >> Changes in v2: >> - Use min_t() instead of separate if-check in patch 3, per >> Christian Lamparter. >> >> Tristan Madani (3): >> wifi: carl9170: bound memcpy length in cmd callback to prevent OOB >> read >> wifi: carl9170: fix OOB read from off-by-two in TX status handler >> wifi: carl9170: fix buffer overflow in rx_stream failover path >> >> drivers/net/wireless/ath/carl9170/rx.c | 7 +++++-- >> drivers/net/wireless/ath/carl9170/tx.c | 2 +- >> 2 files changed, 6 insertions(+), 3 deletions(-) >> > > Christian, will you be able to review this series? > I'll take it once I get reviewed-by or acked-by tags. > And then we can ignore the dups from others. From what I can tell, the "others" made the effort to also check skzkaller. i.e: https://www.spinics.net/lists/stable/msg965098.html Closes: https://syzkaller.appspot.com/bug?extid=5c1ca6ccaa1215781cac Wouldn't it be possible to merge this information with the patch? I guess not. Oh well. As for the series I do have a headache with patch 2, I wonder why none of the other AI-fueled mails proposed the same.