From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E26123C8DA for ; Sat, 8 Feb 2025 07:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739000210; cv=none; b=m1KdSK1iCCV1iO2goPoSZhFgwtxdOAZLtWJYeww6xv6XuFyyvD3qMOblVBTADlhnt1GQ9uyjmGDhxjVQzvgDFi/3OVyOSkvfGTCR+oAdyH4KSOK196TdqG0eIo8yYH/ufJ8Nh/VEqr9yMiZArciHI/VwBycnk4VElX8Y3NdVr98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739000210; c=relaxed/simple; bh=ZpDkIwRv/jYFmO8UBkwg1wlxJp9M55ti5+VYkT9s5xE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sPCgONwWfVg8JJTWOotGWGfPLqkULwOKWVabxVkyfibBLRKwuLA2TsvrGGLSB+P3070hxwU7qKKddLFXKh+6KPcACtE3QVph7fxE7UffUbv9qD1eABS+tP5n+ukdlTl7p0nrDl58bwUfYQ0KQgupkU4CMIwFnMZyzf5r9/3tcf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=J7x8sy3I; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="J7x8sy3I" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5185Klf7021897; Sat, 8 Feb 2025 07:36:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=ThbqPU VYfl1tA58Btsg9qQ4QSjuqFi+dzpNMkNcl6Q4=; b=J7x8sy3I29ecI6mZtNOMmx 3+zP/xeIn58oLELUx+lHFdI/aRK6oMxZhYmkGp8OBvjf/p4wgWHNlMXZqwDt+CNW fWjv91WU+I5oQZJjE+DacsBkmAl0MKpyik/8BSD7qgDGv224E3PpWpOltqxbmyw4 m/pDs5TwusqVDFX/fTTrMyHlXUt8GQyfYmYJMALzys6czRVbkV/wZySvwSN4pysO J8RmYZwe+Pz9Ij9bnPwIcEkK0e83//qZnW3F2QEfhsQ/xjhvPTtsi5ZoFFVssBSo DR264fKjUuG9KG4uhNvng7U2BEgBqltn+F9p7FqWSb/e01vQ1V3+0A3gRK/DAoVg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44p11c0b83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 08 Feb 2025 07:36:12 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 5187aBTT010237; Sat, 8 Feb 2025 07:36:11 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44p11c0b80-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 08 Feb 2025 07:36:11 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5185nGhX006525; Sat, 8 Feb 2025 07:36:10 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 44hyeky5ur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 08 Feb 2025 07:36:10 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5187a8p230147296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 8 Feb 2025 07:36:08 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 99A5520040; Sat, 8 Feb 2025 07:36:08 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 95E362004D; Sat, 8 Feb 2025 07:36:04 +0000 (GMT) Received: from [9.39.23.47] (unknown [9.39.23.47]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 8 Feb 2025 07:36:04 +0000 (GMT) Message-ID: <7b51f7de-8e4b-4766-85ca-dee24832c693@linux.ibm.com> Date: Sat, 8 Feb 2025 13:05:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/9] powerpc: Use preempt_model_str(). To: Sebastian Andrzej Siewior , Christophe Leroy Cc: linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Ben Segall , Catalin Marinas , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Peter Zijlstra , Steven Rostedt , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , linuxppc-dev@lists.ozlabs.org References: <20250203141632.440554-1-bigeasy@linutronix.de> <20250203141632.440554-6-bigeasy@linutronix.de> <65c6f60d-bb52-48bd-a02c-87ffd2a915d4@csgroup.eu> <20250203160103.9DikC9FJ@linutronix.de> <51999b8e-61c0-48b7-b744-c83d39e7f311@csgroup.eu> <20250204082223.6iNyq_KR@linutronix.de> From: Shrikanth Hegde Content-Language: en-US In-Reply-To: <20250204082223.6iNyq_KR@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: pi0gybTkFafi5HjxwKL0ShjNjr9t0ZtV X-Proofpoint-ORIG-GUID: 0aeLtRwpyV5lMlEGvg-TQFK2eCUfh7vs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-08_03,2025-02-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1011 adultscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 bulkscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502080059 On 2/4/25 13:52, Sebastian Andrzej Siewior wrote: > Use preempt_model_str() instead of manually conducting the preemption > model. Use pr_emerg() instead of printk() to pass a loglevel. even on powerpc, i see __die ends up calling show_regs_print_info(). Why print it twice? > > Cc: Madhavan Srinivasan > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Naveen N Rao > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Sebastian Andrzej Siewior > --- > v2…v3: > - Use printk() instead of pr_emerg() to remain consistent with the > other invocations in terms of printing context. > > arch/powerpc/kernel/traps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > index edf5cabe5dfdb..d6d77d92b3358 100644 > --- a/arch/powerpc/kernel/traps.c > +++ b/arch/powerpc/kernel/traps.c > @@ -263,10 +263,10 @@ static int __die(const char *str, struct pt_regs *regs, long err) > { > printk("Oops: %s, sig: %ld [#%d]\n", str, err, ++die_counter); > > - printk("%s PAGE_SIZE=%luK%s%s%s%s%s%s %s\n", > + printk("%s PAGE_SIZE=%luK%s %s %s%s%s%s %s\n", > IS_ENABLED(CONFIG_CPU_LITTLE_ENDIAN) ? "LE" : "BE", > PAGE_SIZE / 1024, get_mmu_str(), > - IS_ENABLED(CONFIG_PREEMPT) ? " PREEMPT" : "", > + preempt_model_str(), > IS_ENABLED(CONFIG_SMP) ? " SMP" : "", > IS_ENABLED(CONFIG_SMP) ? (" NR_CPUS=" __stringify(NR_CPUS)) : "", > debug_pagealloc_enabled() ? " DEBUG_PAGEALLOC" : "",