Re: [PATCH 1/3] drm/bridge: Add ITE IT6162 MIPI DSI to HDMI bridge driver

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 23 Feb 2026, Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org> wrote:
> +static const struct drm_edid
> +		*it6162_bridge_read_edid(struct drm_bridge *bridge,
> +					 struct drm_connector *connector)
> +{
> +	struct it6162 *it6162 = bridge_to_it6162(bridge);
> +	const struct drm_edid *edid;
> +
> +	drm_dbg(it6162->drm, "it6162_bridge_read_edid");
> +	edid = drm_edid_read_custom(connector, it6162_get_edid_block, it6162);
> +	if (!edid) {
> +		drm_err(it6162->drm, "failed to read EDID");
> +		return 0;

Just checking the EDID stuff in passing, and noticed this returns plain
0 for NULL, which is discouraged.

In any case, I'm not sure what the extra error message is worth here
anyway. Your low level it6162_infoblock_request_data() prints errors and
drm_edid_read_custom() prints (some) errors as well. Too many?

BR,
Jani.

> +	}
> +
> +	return edid;
> +}

-- 
Jani Nikula, Intel